dt-bindings: leds: Document "netdev" trigger
Subsystems (4)
PATCH v2 1/1 dt-bindings: leds: Document "netdev" trigger
Document the "netdev" trigger which is used to control LEDs by network device activity. This is an existing trigger used in existing DTs, document it so validation of those DTs would pass.
---
Cc: Conor Dooley <[email protected]>
Cc: Jacek Anaszewski <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Lee Jones <[email protected]>
Cc: Pavel Machek <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
V2: Expand the commit message slightly
--- Documentation/devicetree/bindings/leds/common.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/leds/common.yaml +2 -0
@@ -113,6 +113,8 @@ properties: # LED indicates NAND memory activity (deprecated), # in new implementations use "mtd" - nand-disk + # LED indicates network activity + - netdev # No trigger assigned to the LED. This is the default mode # if trigger is absent - none
Signature · 1 line
2.43.0
Quoted 5 lines · Marek Vasut
Document the "netdev" trigger which is used to control LEDs by network device activity. This is an existing trigger used in existing DTs, document it so validation of those DTs would pass.
Signed-off-by Marek Vasut <[email protected]>
Best regards,
Krzysztof
Lee Jones
maintainerQuoted 25 lines · Marek Vasut
Document the "netdev" trigger which is used to control LEDs by network device activity. This is an existing trigger used in existing DTs, document it so validation of those DTs would pass.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Conor Dooley <[email protected]>
Cc: Jacek Anaszewski <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Lee Jones <[email protected]>
Cc: Pavel Machek <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
V2: Expand the commit message slightly--- Documentation/devicetree/bindings/leds/common.yaml | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/leds/common.yaml +0
-0
Documentation/devicetree/bindings/leds/common.yaml properties: · line 117
Quoted 5 lines
Documentation/devicetree/bindings/leds/common.yaml +2
-0@@ -113,6 +113,8 @@ properties: # LED indicates NAND memory activity (deprecated), # in new implementations use "mtd" - nand-disk + # LED indicates network activity + - netdev
netdev is the description of the network development ML/repo, right?
Seems like an odd name for an OS agnostic property?
Quoted 6 lines
Documentation/devicetree/bindings/leds/common.yaml +0
-0# No trigger assigned to the LED. This is the default mode # if trigger is absent - noneSignature · 1 line
2.43.0
Signature · 1 line
Lee Jones [李琼斯]
Quoted 13 lines
Documentation/devicetree/bindings/leds/common.yaml properties: · line 117
Quoted 10 lines
Documentation/devicetree/bindings/leds/common.yaml +2
-0@@ -113,6 +113,8 @@ properties: # LED indicates NAND memory activity (deprecated), # in new implementations use "mtd" - nand-disk + # LED indicates network activity + - netdevnetdev is the description of the network development ML/repo, right?
Quoted 1 line
Seems like an odd name for an OS agnostic property?
I agree that one meaning is the network development community within Linux.
But it also means a network device, which is OS agnostic. I don't really see it be any different to a memory technology device, mtd.
Andrew
Lee Jones
maintainerQuoted 13 lines · Andrew Lunn
Quoted 13 lines
Documentation/devicetree/bindings/leds/common.yaml properties: · line 117
Quoted 10 lines
Documentation/devicetree/bindings/leds/common.yaml +2
-0@@ -113,6 +113,8 @@ properties: # LED indicates NAND memory activity (deprecated), # in new implementations use "mtd" - nand-disk + # LED indicates network activity + - netdevnetdev is the description of the network development ML/repo, right?
Quoted 7 lines
Quoted 1 line
Seems like an odd name for an OS agnostic property?
I agree that one meaning is the network development community within Linux.
But it also means a network device, which is OS agnostic. I don't really see it be any different to a memory technology device, mtd.
MTD is an acronym.
The only dodgy one I see in there is 'kbd-capslock'.
How about, now go with me here: 'network'?
I'd even suffer 'network-device' or 'net-device' if we really have to shorten.
Although, I'm not really sure the 'device' part needs to come into play'?
Signature · 1 line
Lee Jones [李琼斯]
Quoted 20 lines · Lee Jones
Quoted 18 lines · Andrew Lunn
Quoted 13 lines
Documentation/devicetree/bindings/leds/common.yaml properties: · line 117
Quoted 10 lines
Documentation/devicetree/bindings/leds/common.yaml +2
-0@@ -113,6 +113,8 @@ properties: # LED indicates NAND memory activity (deprecated), # in new implementations use "mtd" - nand-disk + # LED indicates network activity + - netdevnetdev is the description of the network development ML/repo, right?
Quoted 1 line
Seems like an odd name for an OS agnostic property?
I agree that one meaning is the network development community within Linux.
Quoted 8 lines
Quoted 2 lines
But it also means a network device, which is OS agnostic. I don't really see it be any different to a memory technology device, mtd.
MTD is an acronym.
The only dodgy one I see in there is 'kbd-capslock'.
How about, now go with me here: 'network'?
We could do, but we have to keep netdev around for backwards compatibility. There are DT blobs using it which we cannot break.
Andrew
Lee Jones
maintainerQuoted 24 lines · Andrew Lunn
Quoted 23 lines · Lee Jones
Quoted 20 lines · Andrew Lunn
Quoted 13 lines
Documentation/devicetree/bindings/leds/common.yaml properties: · line 117
Quoted 10 lines
Documentation/devicetree/bindings/leds/common.yaml +2
-0@@ -113,6 +113,8 @@ properties: # LED indicates NAND memory activity (deprecated), # in new implementations use "mtd" - nand-disk + # LED indicates network activity + - netdevnetdev is the description of the network development ML/repo, right?
Quoted 1 line
Seems like an odd name for an OS agnostic property?
I agree that one meaning is the network development community within Linux.
But it also means a network device, which is OS agnostic. I don't really see it be any different to a memory technology device, mtd.
Quoted 8 lines
Quoted 5 lines
MTD is an acronym.
The only dodgy one I see in there is 'kbd-capslock'.
How about, now go with me here: 'network'?
We could do, but we have to keep netdev around for backwards compatibility. There are DT blobs using it which we cannot break.
Oh, this 'just' a documentation patch? 'netdev' is already in use?
Signature · 1 line
Lee Jones [李琼斯]
Quoted 5 lines
Quoted 2 lines
We could do, but we have to keep netdev around for backwards compatibility. There are DT blobs using it which we cannot break.
Oh, this 'just' a documentation patch? 'netdev' is already in use?
A few examples:
intel/ixp/intel-ixp42x-iomega-nas100d.dts: linux,default-trigger = "netdev";intel/ixp/intel-ixp42x-dlink-dsm-g600.dts: linux,default-trigger = "netdev";
nxp/imx/imx53-m53menlo.dts: linux,default-trigger = "netdev"; rockchip/rk3128-xpi-3128.dts: * linux,default-trigger = "netdev"; ti/omap/am5729-beagleboneai.dts: linux,default-trigger = "netdev";
ti/omap/am335x-netcan-plus-1xx.dts: linux,default-trigger = "netdev";
Andrew
Lee Jones
maintainerQuoted 6 lines · Andrew Lunn
Quoted 5 lines
Quoted 2 lines
We could do, but we have to keep netdev around for backwards compatibility. There are DT blobs using it which we cannot break.
Oh, this 'just' a documentation patch? 'netdev' is already in use?
Quoted 8 lines
A few examples:
intel/ixp/intel-ixp42x-iomega-nas100d.dts: linux,default-trigger = "netdev";intel/ixp/intel-ixp42x-dlink-dsm-g600.dts: linux,default-trigger = "netdev";nxp/imx/imx53-m53menlo.dts: linux,default-trigger = "netdev"; rockchip/rk3128-xpi-3128.dts: * linux,default-trigger = "netdev"; ti/omap/am5729-beagleboneai.dts: linux,default-trigger = "netdev";
ti/omap/am335x-netcan-plus-1xx.dts: linux,default-trigger = "netdev";
Gross! Okay.
Signature · 1 line
Lee Jones [李琼斯]
Re: (subset) [PATCH v2] dt-bindings: leds: Document "netdev" trigger
In reply to Marek VasutQuoted 5 lines · Marek Vasut
Document the "netdev" trigger which is used to control LEDs by network device activity. This is an existing trigger used in existing DTs, document it so validation of those DTs would pass.
Applied, thanks!
[1/1] dt-bindings: leds: Document "netdev" trigger
commit: 616dbed65485c6e68325d00b6258a05369c14705
--
Lee Jones [李琼斯]