Skip to contentSkip to conversation

baseband/fpga_5gnr_fec: remove useless cast

PATCH Applied Stephen Hemminger 2 participants 3 messages Jul 25, 2024 – Sep 13, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 baseband/fpga_5gnr_fec: remove useless cast

The rte_pktmbuf_mtod_offset macro already includes a type cast so casting the result just adds extra cast.
Found by cocci/mtod-offset.cocci

---
 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c +2 -2
index 9b253cde28..e2ed047836 100644
@@ -2042,7 +2042,7 @@ fpga_5gnr_harq_write_loopback(struct fpga_5gnr_queue *q,
 		}
 	}
 
-	input = (uint64_t *)rte_pktmbuf_mtod_offset(harq_input, uint8_t *, in_offset);
+	input = rte_pktmbuf_mtod_offset(harq_input, uint64_t *, in_offset);
 
 	while (left_length > 0) {
 		if (fpga_5gnr_reg_read_8(q->d->mmio_base, FPGA_5GNR_FEC_DDR4_ADDR_RDY_REGS) ==  1) {
@@ -2125,7 +2125,7 @@ fpga_5gnr_harq_read_loopback(struct fpga_5gnr_queue *q,
 	}
 	left_length = harq_in_length;
 
-	input = (uint64_t *)rte_pktmbuf_mtod_offset(harq_output, uint8_t *, harq_out_offset);
+	input = rte_pktmbuf_mtod_offset(harq_output, uint64_t *, harq_out_offset);
 
 	while (left_length > 0) {
 		if (d->fpga_variant == AGX100_FPGA_VARIANT) {
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 23 lines · Stephen Hemminger

The rte_pktmbuf_mtod_offset macro already includes a type cast so casting the result just adds extra cast.
Found by cocci/mtod-offset.cocci

---
  drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c +1 -1
index 9b253cde28..e2ed047836 100644
@@ -2042,7 +2042,7 @@ fpga_5gnr_harq_write_loopback(struct fpga_5gnr_queue *q,
  		}
  	}
 
-	input = (uint64_t *)rte_pktmbuf_mtod_offset(harq_input, uint8_t *, in_offset);
+	input = rte_pktmbuf_mtod_offset(harq_input, uint64_t *, in_offset);
 
  	while (left_length > 0) {
  		if (fpga_5gnr_reg_read_8(q->d->mmio_base, FPGA_5GNR_FEC_DDR4_ADDR_RDY_REGS) ==  1) {

drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c fpga_5gnr_harq_read_loopback(struct fpga_5gnr_queue *q, · line 2131

Quoted 8 lines
drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c +1 -1
@@ -2125,7 +2125,7 @@ fpga_5gnr_harq_read_loopback(struct fpga_5gnr_queue *q,
  	}
  	left_length = harq_in_length;
 
-	input = (uint64_t *)rte_pktmbuf_mtod_offset(harq_output, uint8_t *, harq_out_offset);
+	input = rte_pktmbuf_mtod_offset(harq_output, uint64_t *, harq_out_offset);
 
  	while (left_length > 0) {
  		if (d->fpga_variant == AGX100_FPGA_VARIANT) {

Thanks,
Maxime

#2 lore raw
In reply to Stephen Hemminger
Quoted 8 lines · Stephen Hemminger

The rte_pktmbuf_mtod_offset macro already includes a type cast so casting the result just adds extra cast.
Found by cocci/mtod-offset.cocci

---
  drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to dpdk-next-baseband/for-main

Thanks,
Maxime