blk-throttle: remove more latency dead-code
Subsystems (3)
PATCH 1/1 blk-throttle: remove more latency dead-code
From: "Dr. David Alan Gilbert" <[email protected]>
The struct 'latency_bucket' and the #define 'request_bucket_index' are unused since
commit bf20ab538c81 ("blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW")
and the 'LATENCY_BUCKET_SIZE' #define was only used by the 'request_bucket_index' define.
Remove them.
Signed-off-by Dr. David Alan Gilbert <[email protected]>
--- block/blk-throttle.c | 11 ----------- 1 file changed, 11 deletions(-)
block/blk-throttle.c +0 -11
@@ -31,14 +31,6 @@ static struct workqueue_struct *kthrotld_workqueue;#define rb_entry_tg (node) rb_entry((node), struct throtl_grp, rb_node) -/* We measure latency for request size from <= 4k to >= 1M */ -#define LATENCY_BUCKET_SIZE 9 - -struct latency_bucket { -unsigned long total_latency;/* ns / 1024 */ -int samples; -}; -struct throtl_data {/* service tree for active throtl groups */
@@ -116,9 +108,6 @@ static unsigned int tg_iops_limit(struct throtl_grp *tg, int rw)return tg->iops[rw]; } -#define request_bucket_index (sectors) \ - clamp_t(int, order_base_2(sectors) - 3, 0, LATENCY_BUCKET_SIZE - 1) -/** * throtl_log - log debug message via blktrace * @sq: the service_queue being reported
Signature · 1 line
2.45.2
Quoted 8 lines · On Sat, 27 Jul 2024 16:58:24 +0100, [email protected] wrote:
The struct '
latency_bucket' and the #define 'request_bucket_index' are unused since
commitbf20ab538c81("blk-throttle: removeCONFIG_BLK_DEV_THROTTLING_LOW")and the '
LATENCY_BUCKET_SIZE' #define was only used by the 'request_bucket_index' define.[...]
Applied, thanks!
[1/1] blk-throttle: remove more latency dead-code
commit: 01aa8c869d0cdaf603f42dc1d2302b164c25353a
Best regards,
Signature · 1 line
Jens Axboe