Skip to contentSkip to conversation

client/player: Fix not setting config target_latency with edpoint.config

PATCH In review Luiz Augusto von Dentz 2 participants 2 messages Jul 29, 2024 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/1 client/player: Fix not setting config target_latency with edpoint.config

From: Luiz Augusto von Dentz <[email protected]>

This fixes not setting target_latency with endpoint.config command.

---
 client/player.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
client/player.c +4 -3
index ac595f434..1280f9a03 100644
@@ -1958,9 +1958,9 @@ static void append_ucast_qos(DBusMessageIter *iter, struct endpoint_config *cfg)
 					DBUS_TYPE_UINT32, &qos->delay);
 
 	if (cfg->target_latency) {
-		bt_shell_printf("TargetLatency 0x%02x\n", qos->target_latency);
+		bt_shell_printf("TargetLatency 0x%02x\n", cfg->target_latency);
 		g_dbus_dict_append_entry(iter, "TargetLatency", DBUS_TYPE_BYTE,
-					&qos->target_latency);
+					&cfg->target_latency);
 	}
 
 	append_io_qos(iter, &qos->io_qos);
@@ -4008,6 +4008,7 @@ static void cmd_config_endpoint(int argc, char *argv[])
 		/* Copy capabilities */
 		util_iov_append(cfg->caps, preset->data.iov_base,
 				preset->data.iov_len);
+		cfg->target_latency = preset->target_latency;
 
 		/* Set QoS parameters */
 		cfg->qos = preset->qos;
@@ -4203,7 +4204,7 @@ static void custom_target_latency(const char *input, void *user_data)
 	else if (!strcasecmp(input, "Balance"))
 		p->target_latency = 0x02;
 	else if (!strcasecmp(input, "High"))
-		p->target_latency = 0x02;
+		p->target_latency = 0x03;
 	else {
 		char *endptr = NULL;
 
Signature · 1 line
2.45.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=874593

---Test result---

Test Summary:

CheckPatch                    PASS      0.48 seconds
GitLint                       FAIL      0.57 seconds
BuildEll                      PASS      26.23 seconds
BluezMake                     PASS      2017.64 seconds
MakeCheck                     PASS      12.88 seconds
MakeDistcheck                 PASS      181.94 seconds
CheckValgrind                 PASS      257.16 seconds
CheckSmatch                   PASS      386.98 seconds
bluezmakeextell               PASS      125.74 seconds
IncrementalBuild              PASS      1613.76 seconds
ScanBuild                     PASS      1045.75 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v1] client/player: Fix not setting config target_latency with edpoint.config

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (83>80): "[BlueZ,v1] client/player: Fix not setting config target_latency with edpoint.config"

---
Regards,
Linux Bluetooth