Skip to contentSkip to conversation

net/mlx5/hws: fix the valid bit of E-Switch owner

PATCH Applied Bing Zhao 3 participants 3 messages Jul 29, 2024 Network drivers

lore
Share & tools
lore

Bing Zhao

author
#0 lore raw

PATCH 1/1 net/mlx5/hws: fix the valid bit of E-Switch owner

The 'eswitch_owner_vhca_id_valid' only depends on the 'merged_eswitch' capability. And it should be set for all vport actions.

Fixes ac8415cfe760 ("net/mlx5/hws: set E-Switch owner VHC ID valid")
---
 drivers/net/mlx5/hws/mlx5dr_action.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/mlx5/hws/mlx5dr_action.c +2 -1
index 8f6be37818..3fceb96de2 100644
@@ -826,7 +826,7 @@ mlx5dr_action_fixup_stc_attr(struct mlx5dr_context *ctx,
 			fixup_stc_attr->vport.vport_num = 0;
 			fixup_stc_attr->vport.esw_owner_vhca_id = stc_attr->vport.esw_owner_vhca_id;
 			fixup_stc_attr->vport.eswitch_owner_vhca_id_valid =
-				ctx->caps->merged_eswitch;
+				stc_attr->vport.eswitch_owner_vhca_id_valid;
 		}
 		use_fixup = true;
 		break;
@@ -1057,6 +1057,7 @@ static void mlx5dr_action_fill_stc_attr(struct mlx5dr_action *action,
 		attr->action_type = MLX5_IFC_STC_ACTION_TYPE_JUMP_TO_VPORT;
 		attr->vport.vport_num = action->vport.vport_num;
 		attr->vport.esw_owner_vhca_id =	action->vport.esw_owner_vhca_id;
+		attr->vport.eswitch_owner_vhca_id_valid = action->ctx->caps->merged_eswitch;
 		break;
 	case MLX5DR_ACTION_TYP_POP_VLAN:
 		attr->action_type = MLX5_IFC_STC_ACTION_TYPE_REMOVE_WORDS;
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: Bing Zhao <[email protected]>
Sent: Monday, July 29, 2024 16:07
To: Dariusz Sosnowski <[email protected]>; Slava Ovsiienko <[email protected]>; [email protected]; Raslan Darawsheh <[email protected]>
Cc: Ori Kam <[email protected]>; Suanming Mou <[email protected]>; Matan Azrad <[email protected]>; Erez Shitrit <[email protected]>; Alex Vesker <[email protected]>
Subject: [PATCH] net/mlx5/hws: fix the valid bit of E-Switch owner

Quoted 8 lines

The 'eswitch_owner_vhca_id_valid' only depends on the 'merged_eswitch' capability. And it should be set for all vport actions.

Fixes ac8415cfe760 ("net/mlx5/hws: set E-Switch owner VHC ID valid")

Best regards,
Dariusz Sosnowski