Skip to contentSkip to conversation

add more tests to the growfs group

PATCH In review Christoph Hellwig 2 participants 4 messages Jul 29, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 add more tests to the growfs group

xfs/127 xfs/233 exercises growfs behavior, add them to the growfs group.

---
 tests/xfs/127 | 2 +-
 tests/xfs/233 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tests/xfs/127 +1 -1
index b690ab0d5..4f008efdb 100755
@@ -7,7 +7,7 @@
 # Tests xfs_growfs on a reflinked filesystem
 #
 . ./common/preamble
-_begin_fstest auto quick clone
+_begin_fstest auto quick clone growfs
 
 # Import common functions.
 . ./common/filter
tests/xfs/233 +1 -1
index 1f691e20f..5d2c10e7d 100755
@@ -7,7 +7,7 @@
 # Tests xfs_growfs on a rmapbt filesystem
 #
 . ./common/preamble
-_begin_fstest auto quick rmap
+_begin_fstest auto quick rmap growfs
 
 # Import common functions.
 . ./common/filter
Signature · 1 line
2.43.0
#1 lore raw

PATCH 2/2 xfs/233: don't require rmap

Nothing in xfs/233 requires an rmap, it can run on any file system. And it is a very useful test because it starts out with a very small file system (or RT subvolume), which exercise some code paths no other test does.

---
 tests/xfs/233 | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tests/xfs/233 +1 -2
index 5d2c10e7d..211e5f842 100755
@@ -4,7 +4,7 @@
 #
 # FS QA Test No. 233
 #
-# Tests xfs_growfs on a rmapbt filesystem
+# Tests xfs_growfs starting with a really small file system.
 #
 . ./common/preamble
 _begin_fstest auto quick rmap growfs
@@ -12,7 +12,6 @@ _begin_fstest auto quick rmap growfs
 # Import common functions.
 . ./common/filter
 
-_require_xfs_scratch_rmapbt
 _require_no_large_scratch_dev
 
 echo "Format and mount"
Signature · 1 line
2.43.0
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] xfs/233: don't require rmap

Quoted 6 lines · Christoph Hellwig

Nothing in xfs/233 requires an rmap, it can run on any file system. And it is a very useful test because it starts out with a very small file system (or RT subvolume), which exercise some code paths no other test does.

Heh, you're right. Lets do this! :)

--D

Quoted 29 lines
---
 tests/xfs/233 | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tests/xfs/233 +1 -2
index 5d2c10e7d..211e5f842 100755
@@ -4,7 +4,7 @@
 #
 # FS QA Test No. 233
 #
-# Tests xfs_growfs on a rmapbt filesystem
+# Tests xfs_growfs starting with a really small file system.
 #
 . ./common/preamble
 _begin_fstest auto quick rmap growfs
@@ -12,7 +12,6 @@ _begin_fstest auto quick rmap growfs
 # Import common functions.
 . ./common/filter
 
-_require_xfs_scratch_rmapbt
 _require_no_large_scratch_dev
 
 echo "Format and mount"
Signature · 1 line
2.43.0
Reviewed-by on v1 1/2
#3 lore raw
In reply to Christoph Hellwig
Quoted 3 lines · Christoph Hellwig

xfs/127 xfs/233 exercises growfs behavior, add them to the growfs group.

Looks good to me,

--D

Quoted 35 lines
---
 tests/xfs/127 | 2 +-
 tests/xfs/233 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tests/xfs/127 +1 -1
index b690ab0d5..4f008efdb 100755
@@ -7,7 +7,7 @@
 # Tests xfs_growfs on a reflinked filesystem
 #
 . ./common/preamble
-_begin_fstest auto quick clone
+_begin_fstest auto quick clone growfs
 
 # Import common functions.
 . ./common/filter
tests/xfs/233 +1 -1
index 1f691e20f..5d2c10e7d 100755
@@ -7,7 +7,7 @@
 # Tests xfs_growfs on a rmapbt filesystem
 #
 . ./common/preamble
-_begin_fstest auto quick rmap
+_begin_fstest auto quick rmap growfs
 
 # Import common functions.
 . ./common/filter
Signature · 1 line
2.43.0