Skip to contentSkip to conversation

arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

PATCH Applied Parth Pancholi 4 participants 7 messages Jul 30, 2024 – Aug 6, 2024 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

From: Parth Pancholi <[email protected]>

Correct the McASP nodes - mcasp3 and mcasp4 with the right DMAs thread IDs as per TISCI documentation [1] for J784s4. This fixes the related McASPs probe failure due to incorrect DMA IDs.

---
 arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi +2 -2
index f170f80f00c1..d4ac1c9872a5 100644
@@ -2755,7 +2755,7 @@ mcasp3: mcasp@2b30000 {
 		interrupts = <GIC_SPI 550 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 551 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-names = "tx", "rx";
-		dmas = <&main_udmap 0xc500>, <&main_udmap 0x4500>;
+		dmas = <&main_udmap 0xc403>, <&main_udmap 0x4403>;
 		dma-names = "tx", "rx";
 		clocks = <&k3_clks 268 0>;
 		clock-names = "fck";
@@ -2773,7 +2773,7 @@ mcasp4: mcasp@2b40000 {
 		interrupts = <GIC_SPI 552 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-names = "tx", "rx";
-		dmas = <&main_udmap 0xc501>, <&main_udmap 0x4501>;
+		dmas = <&main_udmap 0xc404>, <&main_udmap 0x4404>;
 		dma-names = "tx", "rx";
 		clocks = <&k3_clks 269 0>;
 		clock-names = "fck";
Signature · 1 line
2.34.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

maintainer
#2 lore raw
Quoted 32 lines · Parth Pancholi

On Tue, 2024-07-30 at 11:37 +0200, Parth Pancholi wrote:
This message originated from outside your organization

From: Parth Pancholi <[email protected]>

Correct the McASP nodes - mcasp3 and mcasp4 with the right DMAs thread IDs as per TISCI documentation [1] for J784s4. This fixes the related McASPs probe failure due to incorrect DMA IDs.

---
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi +1 -1
index f170f80f00c1..d4ac1c9872a5 100644
@@ -2755,7 +2755,7 @@ mcasp3: mcasp@2b30000 {
 interrupts = <GIC_SPI 550 IRQ_TYPE_LEVEL_HIGH>,
 <GIC_SPI 551 IRQ_TYPE_LEVEL_HIGH>;
 interrupt-names = "tx", "rx";
- dmas = <&main_udmap 0xc500>, <&main_udmap 0x4500>;
+ dmas = <&main_udmap 0xc403>, <&main_udmap 0x4403>;
 dma-names = "tx", "rx";
 clocks = <&k3_clks 268 0>;
 clock-names = "fck";

arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi mcasp4: mcasp@2b40000 { · line 2779

Quoted 8 lines
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi +1 -1
@@ -2773,7 +2773,7 @@ mcasp4: mcasp@2b40000 {
 interrupts = <GIC_SPI 552 IRQ_TYPE_LEVEL_HIGH>,
 <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>;
 interrupt-names = "tx", "rx";
- dmas = <&main_udmap 0xc501>, <&main_udmap 0x4501>;
+ dmas = <&main_udmap 0xc404>, <&main_udmap 0x4404>;
 dma-names = "tx", "rx";
 clocks = <&k3_clks 269 0>;
 clock-names = "fck";

I think your patch got corrupted. Could you use git send-email or a proper client?

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#3 lore raw

Hello Nishanth,

Quoted 35 lines · Nishanth Menon
Quoted 34 lines · Parth Pancholi

On Tue, 2024-07-30 at 11:37 +0200, Parth Pancholi wrote:
This message originated from outside your organization

From: Parth Pancholi <[email protected]>

Correct the McASP nodes - mcasp3 and mcasp4 with the right DMAs thread IDs as per TISCI documentation [1] for J784s4. This fixes the related McASPs probe failure due to incorrect DMA IDs.

---
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi +1 -1
index f170f80f00c1..d4ac1c9872a5 100644
@@ -2755,7 +2755,7 @@ mcasp3: mcasp@2b30000 {
 interrupts = <GIC_SPI 550 IRQ_TYPE_LEVEL_HIGH>,
 <GIC_SPI 551 IRQ_TYPE_LEVEL_HIGH>;
 interrupt-names = "tx", "rx";
- dmas = <&main_udmap 0xc500>, <&main_udmap 0x4500>;
+ dmas = <&main_udmap 0xc403>, <&main_udmap 0x4403>;
 dma-names = "tx", "rx";
 clocks = <&k3_clks 268 0>;
 clock-names = "fck";
@@ -2773,7 +2773,7 @@ mcasp4: mcasp@2b40000 {
 interrupts = <GIC_SPI 552 IRQ_TYPE_LEVEL_HIGH>,
 <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>;
 interrupt-names = "tx", "rx";
Quoted 8 lines

arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi mcasp4: mcasp@2b40000 { · line 2779

Quoted 6 lines
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi +1 -1
- dmas = <&main_udmap 0xc501>, <&main_udmap 0x4501>;
+ dmas = <&main_udmap 0xc404>, <&main_udmap 0x4404>;
 dma-names = "tx", "rx";
 clocks = <&k3_clks 269 0>;
 clock-names = "fck";

I think your patch got corrupted. Could you use git send-email or a proper client?

Are you sure it was not your side to mess-up with it?

I tested and it applies fine to me

$ b4 shazam [email protected]
Grabbing thread from lore.kernel.org/all/20240730093754.1659782-1-parth105105%40gmail.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 2 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs
  ---
  ✓ Signed: DKIM/gmail.com
---
Total patches: 1
---
Applying: arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs
maintainer
#4 lore raw
Quoted 10 lines · Francesco Dolcini

Are you sure it was not your side to mess-up with it?

I tested and it applies fine to me

$ b4 shazam [email protected]
Grabbing thread from lore.kernel.org/all/20240730093754.1659782-1-parth105105%40gmail.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 2 messages in the thread
Checking attestation on all messages, may take a moment...

It looks like Parth had CCed Jayesh in response[1] in html email and that is what I saw in my mailbox. but anyways, no harm done.

Will wait for Jayesh to review.

[1] message-ID
[email protected] in https://lore.kernel.org/linux-arm-kernel/20240730110444.fctc2lje62ewg4ob@safari/T/#t

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#5 lore raw
In reply to Parth Pancholi

Hello,

Quoted 10 lines · Parth Pancholi

From: Parth Pancholi <[email protected]>

Correct the McASP nodes - mcasp3 and mcasp4 with the right DMAs thread IDs as per TISCI documentation [1] for J784s4. This fixes the related McASPs probe failure due to incorrect DMA IDs.

+ Jayesh that is the author of the commit fixed here.

Francesco

Reviewed-by on v1 1/1
#6 lore raw
In reply to Parth Pancholi

Hello Parth,

Thank you for the patch.

Quoted 28 lines · Parth Pancholi

From: Parth Pancholi <[email protected]>

Correct the McASP nodes - mcasp3 and mcasp4 with the right DMAs thread IDs as per TISCI documentation [1] for J784s4. This fixes the related McASPs probe failure due to incorrect DMA IDs.

---
  arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi +1 -1
index f170f80f00c1..d4ac1c9872a5 100644
@@ -2755,7 +2755,7 @@ mcasp3: mcasp@2b30000 {
  		interrupts = <GIC_SPI 550 IRQ_TYPE_LEVEL_HIGH>,
  			     <GIC_SPI 551 IRQ_TYPE_LEVEL_HIGH>;
  		interrupt-names = "tx", "rx";
-		dmas = <&main_udmap 0xc500>, <&main_udmap 0x4500>;
+		dmas = <&main_udmap 0xc403>, <&main_udmap 0x4403>;
  		dma-names = "tx", "rx";
  		clocks = <&k3_clks 268 0>;
  		clock-names = "fck";

arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi mcasp4: mcasp@2b40000 { · line 2779

Quoted 8 lines
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi +1 -1
@@ -2773,7 +2773,7 @@ mcasp4: mcasp@2b40000 {
  		interrupts = <GIC_SPI 552 IRQ_TYPE_LEVEL_HIGH>,
  			     <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>;
  		interrupt-names = "tx", "rx";
-		dmas = <&main_udmap 0xc501>, <&main_udmap 0x4501>;
+		dmas = <&main_udmap 0xc404>, <&main_udmap 0x4404>;
  		dma-names = "tx", "rx";
  		clocks = <&k3_clks 269 0>;
  		clock-names = "fck";

Warm Regards,
Jayesh

maintainer Applied
#7 lore raw
In reply to Parth Pancholi

Hi Parth Pancholi,

Quoted 6 lines · Parth Pancholi

Correct the McASP nodes - mcasp3 and mcasp4 with the right DMAs thread IDs as per TISCI documentation [1] for J784s4. This fixes the related McASPs probe failure due to incorrect DMA IDs.

I have applied the following to branch ti-k3-dts-next on [1]. Thank you!

[1/1] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

      commit: 402d336053a5d827c70ec11109e079811e86e0e8

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D