mm/z3fold: Add __percpu annotation to *unbuddied pointer in struct z3fold_pool
PATCH 1/1 mm/z3fold: Add __percpu annotation to *unbuddied pointer in struct z3fold_pool
Compiling z3fold.c results in several sparse warnings:
z3fold.c:797:21: warning: incorrect type in initializer (different address spaces)
z3fold.c:797:21: expected void const [noderef] __percpu *__vpp_verify
z3fold.c:797:21: got struct list_head *
z3fold.c:852:37: warning: incorrect type in initializer (different address spaces)
z3fold.c:852:37: expected void const [noderef] __percpu *__vpp_verify
z3fold.c:852:37: got struct list_head *
z3fold.c:924:25: warning: incorrect type in assignment (different address spaces)
z3fold.c:924:25: expected struct list_head *unbuddied
z3fold.c:924:25: got void [noderef] __percpu *_res
z3fold.c:930:33: warning: incorrect type in initializer (different address spaces)
z3fold.c:930:33: expected void const [noderef] __percpu *__vpp_verify
z3fold.c:930:33: got struct list_head *
z3fold.c:949:25: warning: incorrect type in argument 1 (different address spaces)
z3fold.c:949:25: expected void [noderef] __percpu *__pdata
z3fold.c:949:25: got struct list_head *unbuddied
z3fold.c:979:25: warning: incorrect type in argument 1 (different address spaces)
z3fold.c:979:25: expected void [noderef] __percpu *__pdata
z3fold.c:979:25: got struct list_head *unbuddied
Add __percpu annotation to *unbuddied pointer to fix these warnings.
--- mm/z3fold.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/z3fold.c +1 -1
@@ -144,7 +144,7 @@ struct z3fold_pool {const char *name;spinlock_t lock;spinlock_t stale_lock; -struct list_head *unbuddied; +struct list_head __percpu *unbuddied;struct list_head stale;atomic64_t pages_nr;struct kmem_cache *c_handle;
Signature · 1 line
2.45.2
Quoted 21 lines · Uros Bizjak
Compiling
z3fold.cresults in several sparse warnings:z3fold.c:797:21: warning: incorrect type in initializer (different address spaces)
z3fold.c:797:21: expected void const [noderef]__percpu*__vpp_verify
z3fold.c:797:21: got structlist_head*
z3fold.c:852:37: warning: incorrect type in initializer (different address spaces)
z3fold.c:852:37: expected void const [noderef]__percpu*__vpp_verify
z3fold.c:852:37: got structlist_head*
z3fold.c:924:25: warning: incorrect type in assignment (different address spaces)
z3fold.c:924:25: expected structlist_head*unbuddied
z3fold.c:924:25: got void [noderef]__percpu*_res
z3fold.c:930:33: warning: incorrect type in initializer (different address spaces)
z3fold.c:930:33: expected void const [noderef]__percpu*__vpp_verify
z3fold.c:930:33: got structlist_head*
z3fold.c:949:25: warning: incorrect type in argument 1 (different address spaces)
z3fold.c:949:25: expected void [noderef]__percpu*__pdata
z3fold.c:949:25: got structlist_head*unbuddied
z3fold.c:979:25: warning: incorrect type in argument 1 (different address spaces)
z3fold.c:979:25: expected void [noderef]__percpu*__pdata
z3fold.c:979:25: got structlist_head*unbuddied
Quoted 6 lines
Add
__percpuannotation to *unbuddied pointer to fix these warnings.Signed-off-by Uros Bizjak <[email protected]>Cc Vitaly Wool <[email protected]>Cc Miaohe Lin <[email protected]>Cc Andrew Morton <[email protected]>
Thanks.
.