fs/aio: Fix __percpu annotation of *cpu pointer in struct kioctx
PATCH 1/1 fs/aio: Fix __percpu annotation of *cpu pointer in struct kioctx
__percpu annotation of *cpu pointer in struct kioctx is put at the wrong place, resulting in several sparse warnings:
aio.c:623:24: warning: incorrect type in argument 1 (different address spaces)
aio.c:623:24: expected void [noderef] __percpu *__pdata
aio.c:623:24: got struct kioctx_cpu *cpu
aio.c:788:18: warning: incorrect type in assignment (different address spaces)
aio.c:788:18: expected struct kioctx_cpu *cpu
aio.c:788:18: got struct kioctx_cpu [noderef] __percpu *
aio.c:835:24: warning: incorrect type in argument 1 (different address spaces)
aio.c:835:24: expected void [noderef] __percpu *__pdata
aio.c:835:24: got struct kioctx_cpu *cpu
aio.c:940:16: warning: incorrect type in initializer (different address spaces)
aio.c:940:16: expected void const [noderef] __percpu *__vpp_verify
aio.c:940:16: got struct kioctx_cpu *
aio.c:958:16: warning: incorrect type in initializer (different address spaces)
aio.c:958:16: expected void const [noderef] __percpu *__vpp_verify
aio.c:958:16: got struct kioctx_cpu *
Put __percpu annotation at the right place to fix these warnings.
--- fs/aio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/aio.c +1 -1
@@ -100,7 +100,7 @@ struct kioctx {unsigned long user_id; -struct __percpu kioctx_cpu *cpu; +struct kioctx_cpu __percpu *cpu;/* * For percpu reqs_available, number of slots we move to/from global
Signature · 1 line
2.45.2
Quoted 19 lines · Uros Bizjak
__percpuannotation of *cpu pointer in struct kioctx is put at the wrong place, resulting in several sparse warnings:aio.c:623:24: warning: incorrect type in argument 1 (different address spaces)
aio.c:623:24: expected void [noderef]__percpu*__pdata
aio.c:623:24: got structkioctx_cpu*cpu
aio.c:788:18: warning: incorrect type in assignment (different address spaces)
aio.c:788:18: expected structkioctx_cpu*cpu
aio.c:788:18: got structkioctx_cpu[noderef]__percpu*
aio.c:835:24: warning: incorrect type in argument 1 (different address spaces)
aio.c:835:24: expected void [noderef]__percpu*__pdata
aio.c:835:24: got structkioctx_cpu*cpu
aio.c:940:16: warning: incorrect type in initializer (different address spaces)
aio.c:940:16: expected void const [noderef]__percpu*__vpp_verify
aio.c:940:16: got structkioctx_cpu*
aio.c:958:16: warning: incorrect type in initializer (different address spaces)
aio.c:958:16: expected void const [noderef]__percpu*__vpp_verify
aio.c:958:16: got structkioctx_cpu*
Quoted 8 lines
Put
__percpuannotation at the right place to fix these warnings.Signed-off-by Uros Bizjak <[email protected]>Cc Benjamin LaHaise <[email protected]>Cc Alexander Viro <[email protected]>Cc Christian Brauner <[email protected]>Cc Jan Kara <[email protected]>Cc Andrew Morton <[email protected]>
Looks good. Feel free to add:
Honza
Quoted 20 lines
--- fs/aio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/aio.c +1
-1@@ -100,7 +100,7 @@ struct kioctx {unsigned long user_id; -struct __percpu kioctx_cpu *cpu; +struct kioctx_cpu __percpu *cpu;/* * For percpu reqs_available, number of slots we move to/from global Signature · 1 line
2.45.2
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 19 lines · Uros Bizjak
__percpuannotation of *cpu pointer in struct kioctx is put at the wrong place, resulting in several sparse warnings:aio.c:623:24: warning: incorrect type in argument 1 (different address spaces)
aio.c:623:24: expected void [noderef]__percpu*__pdata
aio.c:623:24: got structkioctx_cpu*cpu
aio.c:788:18: warning: incorrect type in assignment (different address spaces)
aio.c:788:18: expected structkioctx_cpu*cpu
aio.c:788:18: got structkioctx_cpu[noderef]__percpu*
aio.c:835:24: warning: incorrect type in argument 1 (different address spaces)
aio.c:835:24: expected void [noderef]__percpu*__pdata
aio.c:835:24: got structkioctx_cpu*cpu
aio.c:940:16: warning: incorrect type in initializer (different address spaces)
aio.c:940:16: expected void const [noderef]__percpu*__vpp_verify
aio.c:940:16: got structkioctx_cpu*
aio.c:958:16: warning: incorrect type in initializer (different address spaces)
aio.c:958:16: expected void const [noderef]__percpu*__vpp_verify
aio.c:958:16: got structkioctx_cpu*
Quoted 1 line
[...]
Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc
[1/1] fs/aio: Fix __percpu annotation of *cpu pointer in struct kioctx
https://git.kernel.org/vfs/vfs/c/b484eca083f7