Skip to contentSkip to conversation

dt-bindings: interconnect: qcom: Do not require reg for sc8180x virt NoCs

PATCH In review [email protected] 2 participants 4 messages Jul 30, 2024 – Aug 24, 2024

Subsystems (3)
Device tree bindings Arm Qualcomm mailing list Interconnect API
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: interconnect: qcom: Do not require reg for sc8180x virt NoCs

From: Georgi Djakov <[email protected]>

The virtual interconnect providers do not have their own IO address space, but this is not documented in the DT schema and the following warnings are reported by dtbs_check:

sc8180x-lenovo-flex-5g.dtb: interconnect-camnoc-virt: 'reg' is a required property sc8180x-lenovo-flex-5g.dtb: interconnect-mc-virt: 'reg' is a required property sc8180x-lenovo-flex-5g.dtb: interconnect-qup-virt: 'reg' is a required property sc8180x-primus.dtb: interconnect-camnoc-virt: 'reg' is a required property sc8180x-primus.dtb: interconnect-mc-virt: 'reg' is a required property sc8180x-primus.dtb: interconnect-qup-virt: 'reg' is a required property

Fix this by adding them to the list of compatibles that do not require the reg property.

Signed-off-by Georgi Djakov <[email protected]>
---
 Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml +3 -0
index 9318b845ec35..70f5b2670085 100644
@@ -113,6 +113,9 @@ allOf:
         properties:
           compatible:
             enum:
+              - qcom,sc8180x-camnoc-virt
+              - qcom,sc8180x-mc-virt
+              - qcom,sc8180x-qup-virt
               - qcom,sdx65-mc-virt
               - qcom,sm8250-qup-virt
     then:
#1 lore raw
Quoted 13 lines · On 30/07/2024 16:10, [email protected] wrote:

From: Georgi Djakov <[email protected]>

The virtual interconnect providers do not have their own IO address space, but this is not documented in the DT schema and the following warnings are reported by dtbs_check:

sc8180x-lenovo-flex-5g.dtb: interconnect-camnoc-virt: 'reg' is a required property sc8180x-lenovo-flex-5g.dtb: interconnect-mc-virt: 'reg' is a required property sc8180x-lenovo-flex-5g.dtb: interconnect-qup-virt: 'reg' is a required property sc8180x-primus.dtb: interconnect-camnoc-virt: 'reg' is a required property sc8180x-primus.dtb: interconnect-mc-virt: 'reg' is a required property sc8180x-primus.dtb: interconnect-qup-virt: 'reg' is a required property

Quoted 2 lines

Fix this by adding them to the list of compatibles that do not require the reg property.

So I guess we are giving up on
https://lore.kernel.org/all/[email protected]/
?

Best regards,
Krzysztof

author maintainer
#2 lore raw
Quoted 14 lines · Krzysztof Kozlowski
Quoted 13 lines · On 30/07/2024 16:10, [email protected] wrote:

From: Georgi Djakov <[email protected]>

The virtual interconnect providers do not have their own IO address space, but this is not documented in the DT schema and the following warnings are reported by dtbs_check:

sc8180x-lenovo-flex-5g.dtb: interconnect-camnoc-virt: 'reg' is a required property sc8180x-lenovo-flex-5g.dtb: interconnect-mc-virt: 'reg' is a required property sc8180x-lenovo-flex-5g.dtb: interconnect-qup-virt: 'reg' is a required property sc8180x-primus.dtb: interconnect-camnoc-virt: 'reg' is a required property sc8180x-primus.dtb: interconnect-mc-virt: 'reg' is a required property sc8180x-primus.dtb: interconnect-qup-virt: 'reg' is a required property

Quoted 6 lines
Quoted 2 lines

Fix this by adding them to the list of compatibles that do not require the reg property.

So I guess we are giving up on
https://lore.kernel.org/all/[email protected]/
?

Thanks for the pointer! That approach is fine too, but i was expecting a re-send and then later completely forgot about it. I have a slight preference towards my patch, because it is more compact, but i can also revive Vinod's patch if you think that it would be a better pattern to follow in the long term.

BR,
Georgi

#3 lore raw
Quoted 22 lines · Georgi Djakov
Quoted 14 lines · Krzysztof Kozlowski
Quoted 13 lines · On 30/07/2024 16:10, [email protected] wrote:

From: Georgi Djakov <[email protected]>

The virtual interconnect providers do not have their own IO address space, but this is not documented in the DT schema and the following warnings are reported by dtbs_check:

sc8180x-lenovo-flex-5g.dtb: interconnect-camnoc-virt: 'reg' is a required property sc8180x-lenovo-flex-5g.dtb: interconnect-mc-virt: 'reg' is a required property sc8180x-lenovo-flex-5g.dtb: interconnect-qup-virt: 'reg' is a required property sc8180x-primus.dtb: interconnect-camnoc-virt: 'reg' is a required property sc8180x-primus.dtb: interconnect-mc-virt: 'reg' is a required property sc8180x-primus.dtb: interconnect-qup-virt: 'reg' is a required property

Quoted 6 lines
Quoted 2 lines

Fix this by adding them to the list of compatibles that do not require the reg property.

So I guess we are giving up on
https://lore.kernel.org/all/[email protected]/
?

Quoted 5 lines

Thanks for the pointer! That approach is fine too, but i was expecting a re-send and then later completely forgot about it. I have a slight preference towards my patch, because it is more compact, but i can also revive Vinod's patch if you think that it would be a better pattern to follow in the long term.

Vinod sent his patch more than a year ago, so I think we are indeed giving up on this :)

Best regards,
Krzysztof