netfs: clean up after renaming FSCACHE_DEBUG config
Subsystems (4)
PATCH 1/1 netfs: clean up after renaming FSCACHE_DEBUG config
From: Lukas Bulwahn <[email protected]>
Commit fcad93360df4 ("netfs: Rename CONFIG_FSCACHE_DEBUG to CONFIG_NETFS_DEBUG") renames the config, but introduces two issues: First, NETFS_DEBUG mistakenly depends on the non-existing config NETFS, whereas the actual intended config is called NETFS_SUPPORT. Second, the config renaming misses to adjust the documentation of the functionality of this config.
Clean up those two points.
--- Documentation/filesystems/caching/fscache.rst | 8 ++++---- fs/netfs/Kconfig | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)
Documentation/filesystems/caching/fscache.rst +4 -4
@@ -318,10 +318,10 @@ where the columns are: Debugging ========= -If CONFIG_FSCACHE_DEBUG is enabled, the FS-Cache facility can have runtime -debugging enabled by adjusting the value in:: +If CONFIG_NETFS_DEBUG is enabled, the FS-Cache facility and NETFS support can +have runtime debugging enabled by adjusting the value in:: - /sys/module/fscache/parameters/debug + /sys/module/netfs/parameters/debug This is a bitmask of debugging streams to enable:
@@ -343,6 +343,6 @@ This is a bitmask of debugging streams to enable: The appropriate set of values should be OR'd together and the result written to the control file. For example:: - echo $((1|8|512)) >/sys/module/fscache/parameters/debug + echo $((1|8|512)) >/sys/module/netfs/parameters/debug will turn on all function entry debugging.
fs/netfs/Kconfig +1 -1
@@ -24,7 +24,7 @@ config NETFS_STATS config NETFS_DEBUG bool "Enable dynamic debugging netfslib and FS-Cache" - depends on NETFS + depends on NETFS_SUPPORT help This permits debugging to be dynamically enabled in the local caching management module. If this is set, the debugging output may be
Signature · 1 line
2.45.2
Quoted 8 lines · Lukas Bulwahn
Commit
fcad93360df4("netfs: RenameCONFIG_FSCACHE_DEBUGtoCONFIG_NETFS_DEBUG") renames the config, but introduces two issues: First,NETFS_DEBUGmistakenly depends on the non-existing config NETFS, whereas the actual intended config is calledNETFS_SUPPORT. Second, the config renaming misses to adjust the documentation of the functionality of this config.[...]
Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes
[1/1] netfs: clean up after renaming FSCACHE_DEBUG config
https://git.kernel.org/vfs/vfs/c/c9bffce5f3f5