Skip to contentSkip to conversation

staging: atomisp: bnr: fix trailing statement

PATCH In review Kartik Kulkarni 2 participants 2 messages Jul 31, 2024 – Sep 2, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: atomisp: bnr: fix trailing statement

Fix checkpatch error trailing statements should be on next line in ia_css_bnr.host.c:48

---
v2: Move Signed-off-by line above the exclusion block

---
 .../atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c +2 -1
index 457a004e1..b75cfd309 100644
@@ -45,7 +45,8 @@ ia_css_bnr_dump(
     const struct sh_css_isp_bnr_params *bnr,
     unsigned int level)
 {
-	if (!bnr) return;
+	if (!bnr)
+		return;
 	ia_css_debug_dtrace(level, "Bayer Noise Reduction:\n");
 	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
 			    "bnr_gain_all", bnr->gain_all);
Signature · 1 line
2.20.1
#1 lore raw

Hi,

Quoted 4 lines · Kartik Kulkarni

Fix checkpatch error trailing statements should be on next line in ia_css_bnr.host.c:48

Thank you for your patch(es).

I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this/these will be included in my next pull-request to Mauro (to media subsystem maintainer)

Regards,

Hans

Quoted 20 lines

---
v2: Move Signed-off-by line above the exclusion block

---
 .../atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c +2 -1
index 457a004e1..b75cfd309 100644
@@ -45,7 +45,8 @@ ia_css_bnr_dump(
     const struct sh_css_isp_bnr_params *bnr,
     unsigned int level)
 {
-	if (!bnr) return;
+	if (!bnr)
+		return;
 	ia_css_debug_dtrace(level, "Bayer Noise Reduction:\n");
 	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
 			    "bnr_gain_all", bnr->gain_all);