Skip to contentSkip to conversation

init/Kconfig: Only block on RANDSTRUCT for RUST

PATCH Applied Neal Gompa 2 participants 4 messages Jul 31, 2024 – Aug 18, 2024 Rust

lore
Share & tools
lore

Neal Gompa

author
#0 lore raw

PATCH v2 1/1 init/Kconfig: Only block on RANDSTRUCT for RUST

When enabling Rust in the kernel, we only need to block on the RANDSTRUCT feature and GCC plugin. The rest of the GCC plugins are reasonably safe to enable.

---
Changes in v2
- Drop changing !RANDSTRUCT to RANDSTRUCT_NONE
(they're equivalent anyway)

---
 init/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
init/Kconfig +1 -1
index a465ea9525bd..0939486938cc 100644
@@ -1900,7 +1900,7 @@ config RUST
 	depends on RUST_IS_AVAILABLE
 	depends on !CFI_CLANG
 	depends on !MODVERSIONS
-	depends on !GCC_PLUGINS
+	depends on !GCC_PLUGIN_RANDSTRUCT
 	depends on !RANDSTRUCT
 	depends on !DEBUG_INFO_BTF || PAHOLE_HAS_LANG_EXCLUDE
 	help
Signature · 1 line
2.45.2
author
#1 lore raw
Quoted 28 lines · Neal Gompa

When enabling Rust in the kernel, we only need to block on the RANDSTRUCT feature and GCC plugin. The rest of the GCC plugins are reasonably safe to enable.

---
Changes in v2
- Drop changing !RANDSTRUCT to RANDSTRUCT_NONE
(they're equivalent anyway)

---
 init/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
init/Kconfig +1 -2
index a465ea9525bd..0939486938cc 100644
@@ -1900,7 +1900,7 @@ config RUST
        depends on RUST_IS_AVAILABLE
        depends on !CFI_CLANG
        depends on !MODVERSIONS
-       depends on !GCC_PLUGINS
+       depends on !GCC_PLUGIN_RANDSTRUCT
        depends on !RANDSTRUCT
        depends on !DEBUG_INFO_BTF || PAHOLE_HAS_LANG_EXCLUDE
        help
--
Quoted 2 lines

2.45.2

Bump for notice... Can we get this looked at to incorporate for 6.11?

Signature · 1 line
真実はいつも一つ!/ Always, there's only one truth!
#2 lore raw
Quoted 2 lines · Neal Gompa

Bump for notice... Can we get this looked at to incorporate for 6.11?

We have not picked up any patch yet. -rc4 will be out later today, where we will start applying things on top.

Thanks!

Cheers,
Miguel

Applied
#3 lore raw
In reply to Neal Gompa
Quoted 6 lines · Neal Gompa

When enabling Rust in the kernel, we only need to block on the RANDSTRUCT feature and GCC plugin. The rest of the GCC plugins are reasonably safe to enable.

Applied to rust-next -- thanks!

[ Originally (years ago) we only had this restriction, but we ended up
restricting also the rest of the GCC plugins 1) to be on the safe side,
2) since compiler plugin support could be going away in the kernel and
3) since mixed builds are best effort so far; so I asked Neal about his experience enabling the other plugins -- Neal says:

When I originally wrote this patch two years ago to get things working, Fedora used all the GCC plugins, so I was trying to get GCC + Rust to work while minimizing the delta on build differences. This was the combination that worked. We've been carrying this patch in the Asahi tree for a year now. And while Fedora does not currently have GCC plugins enabled because it caused issues with some third-party modules (I think it was the NVIDIA driver, but I'm not sure), it was around long enough for me to know with some confidence that it was fine this way.

- Miguel ]

Cheers,
Migul