bsd-user/x86_64/target_arch_thread.h: Align stack
PATCH 1/1 bsd-user/x86_64/target_arch_thread.h: Align stack
bsd-user qemu-x86_64 almost immediately dies with:
qemu: 0x4002201a68: unhandled CPU exception 0xd - aborting
on FreeBSD 14.1-RELEASE. This is an instruction that requires alignment:
(gdb) x/i 0x4002201a68
0x4002201a68: movaps %xmm0,-0x40(%rbp)and the argument is not aligned:
(gdb) p/x env->regs[5]
$1 = 0x822443b58A quick experiment shows that the userspace entry point expects misaligned rsp:
(gdb) starti
(gdb) p/x $rsp
$1 = 0x7fffffffeaa8Emulate this behavior in bsd-user.
--- bsd-user/x86_64/target_arch_thread.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
bsd-user/x86_64/target_arch_thread.h +1 -1
@@ -31,7 +31,7 @@ static inline void target_thread_init(struct target_pt_regs *regs, struct image_info *infop) { regs->rax =0 ; - regs->rsp = infop->start_stack; + regs->rsp = (infop->start_stack & ~0xfUL ) -8 ; regs->rip = infop->entry; regs->rdi = infop->start_stack; }
Signature · 1 line
2.45.2
Quoted 34 lines · Ilya Leoshkevich
bsd-user qemu-x86_64 almost immediately dies with:
qemu: 0x4002201a68: unhandled CPU exception 0xd - abortingon FreeBSD 14.1-RELEASE. This is an instruction that requires alignment:
(gdb) x/i 0x4002201a68 0x4002201a68: movaps %xmm0,-0x40(%rbp)and the argument is not aligned:
(gdb) p/x env->regs[5] $1 = 0x822443b58A quick experiment shows that the userspace entry point expects misaligned rsp:
(gdb) starti (gdb) p/x $rsp $1 = 0x7fffffffeaa8Emulate this behavior in bsd-user.
Signed-off-by Ilya Leoshkevich <[email protected]>--- bsd-user/x86_64/target_arch_thread.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)bsd-user/x86_64/target_arch_thread.h +0
-0
bsd-user/x86_64/target_arch_thread.h static inline void target_thread_init(struct target_pt_regs *regs, · line 34
Quoted 5 lines
bsd-user/x86_64/target_arch_thread.h +1
-1@@ -31,7 +31,7 @@ static inline void target_thread_init(struct target_pt_regs *regs, struct image_info *infop) { regs->rax =0 ; - regs->rsp = infop->start_stack; + regs->rsp = (infop->start_stack & ~0xfUL ) -8 ;
The formula in sys/amd64/amd64/exec_machdep.c, exec_setregs is
((stack - 8) & ~0xful) + 8
With that,
r~
Warner Losh
Reviewed-byHmmm... All platforms likely need this....
Oh, they all have it except x86, both 32 and 64-bit.... but i386 is already properly aligned (at least in the
FreeBSD kernel), so maybe that's not needed.
Quoted 43 lines · Richard Henderson
Quoted 22 lines · Ilya Leoshkevich
bsd-user qemu-x86_64 almost immediately dies with:
qemu: 0x4002201a68: unhandled CPU exception 0xd - abortingon FreeBSD 14.1-RELEASE. This is an instruction that requires alignment:
(gdb) x/i 0x4002201a68 0x4002201a68: movaps %xmm0,-0x40(%rbp)and the argument is not aligned:
(gdb) p/x env->regs[5] $1 = 0x822443b58A quick experiment shows that the userspace entry point expects misaligned rsp:
(gdb) starti (gdb) p/x $rsp $1 = 0x7fffffffeaa8Review
Quoted 8 lines
Emulate this behavior in bsd-user.
Signed-off-by Ilya Leoshkevich <[email protected]>--- bsd-user/x86_64/target_arch_thread.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/bsd-user/x86_64/target_arch_thread.hbsd-user/x86_64/target_arch_thread.h static inline void target_thread_init(struct
Quoted 4 lines
index
52c28906d6d..25233443c14100644bsd-user/x86_64/target_arch_thread.h +0
-0@@ -31,7 +31,7 @@ static inline void target_thread_init(struct
target_pt_regs*regs,bsd-user/x86_64/target_arch_thread.h static inline void target_thread_init(struct target_pt_regs *regs, · line 34
Quoted 5 lines
bsd-user/x86_64/target_arch_thread.h +1
-1struct image_info *infop) { regs->rax =0 ; - regs->rsp = infop->start_stack; + regs->rsp = (infop->start_stack & ~0xfUL ) -8 ;
Quoted 7 lines
The formula in
sys/amd64/amd64/exec_machdep.c,exec_setregsis((stack - 8) & ~0xful) + 8With that,
Reviewed-by Richard Henderson <[email protected]>
Agreed.
There's a *lot* that's missing on for amd64 emulation relative to the other platforms.
Warner
Quoted 60 lines · Warner Losh
Hmmm... All platforms likely need this....
Oh, they all have it except x86, both 32 and 64-bit.... but i386 is already properly aligned (at least in the
FreeBSD kernel), so maybe that's not needed.Quoted 43 lines · Richard Henderson
Quoted 22 lines · Ilya Leoshkevich
bsd-user qemu-x86_64 almost immediately dies with:
qemu: 0x4002201a68: unhandled CPU exception 0xd - abortingon FreeBSD 14.1-RELEASE. This is an instruction that requires alignment:
(gdb) x/i 0x4002201a68 0x4002201a68: movaps %xmm0,-0x40(%rbp)and the argument is not aligned:
(gdb) p/x env->regs[5] $1 = 0x822443b58A quick experiment shows that the userspace entry point expects misaligned rsp:
(gdb) starti (gdb) p/x $rsp $1 = 0x7fffffffeaa8Review
Quoted 8 lines
Emulate this behavior in bsd-user.
Signed-off-by Ilya Leoshkevich <[email protected]>--- bsd-user/x86_64/target_arch_thread.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/bsd-user/x86_64/target_arch_thread.hbsd-user/x86_64/target_arch_thread.h static inline void target_thread_init(struct
Quoted 4 lines
index
52c28906d6d..25233443c14100644bsd-user/x86_64/target_arch_thread.h +0
-0@@ -31,7 +31,7 @@ static inline void target_thread_init(struct
target_pt_regs*regs,bsd-user/x86_64/target_arch_thread.h static inline void target_thread_init(struct target_pt_regs *regs, · line 34
Quoted 5 lines
bsd-user/x86_64/target_arch_thread.h +1
-1struct image_info *infop) { regs->rax =0 ; - regs->rsp = infop->start_stack; + regs->rsp = (infop->start_stack & ~0xfUL ) -8 ;Quoted 7 lines
The formula in
sys/amd64/amd64/exec_machdep.c,exec_setregsis((stack - 8) & ~0xful) + 8With that,
Reviewed-by Richard Henderson <[email protected]>
Quoted 7 lines
Agreed.
Reviewed-by Warner Losh <[email protected]>There's a *lot* that's missing on for amd64 emulation relative to the other platforms.
Forgot to mention that I've queued this change with Richard's suggested modification.
Warner