input: tc3589x: Use of_property_present()
Subsystems (2)
PATCH 1/1 input: tc3589x: Use of_property_present()
Use of_property_present() to test for property presence rather than of_get_property(). This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.
Signed-off-by Rob Herring (Arm) <[email protected]>
--- drivers/input/keyboard/tc3589x-keypad.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/input/keyboard/tc3589x-keypad.c +1 -2
@@ -325,7 +325,6 @@ tc3589x_keypad_of_probe(struct device *dev)struct tc3589x_keypad_platform_data *plat;u32 cols, rows;u32 debounce_ms; -int proplen;if (!np)return ERR_PTR (-ENODEV );
@@ -346,7 +345,7 @@ tc3589x_keypad_of_probe(struct device *dev)return ERR_PTR (-EINVAL ); } -if (!of_get_property (np,"linux,keymap" , &proplen)) { +if (!of_property_present (np,"linux,keymap" )) {dev_err (dev,"property linux,keymap not found\n" );return ERR_PTR (-ENOENT ); }
Signature · 1 line
2.43.0
Quoted 7 lines · Rob Herring (Arm)
Use
of_property_present()to test for property presence rather thanof_get_property(). This is part of a larger effort to remove callers ofof_get_property()and similar functions.of_get_property()leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.Signed-off-by Rob Herring (Arm) <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry