memory: emif: Use of_property_read_bool()
PATCH 1/1 memory: emif: Use of_property_read_bool()
Use of_property_read_bool() to read boolean properties rather than of_find_property(). This is part of a larger effort to remove callers of of_find_property() and similar functions. of_find_property() leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.
--- drivers/memory/emif.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-)
drivers/memory/emif.c +4 -9
@@ -864,7 +864,7 @@ static void of_get_custom_configs(struct device_node *np_emif,be32_to_cpup (poll_intvl); } -if (of_find_property (np_emif,"extended-temp-part" , &len)) +if (of_property_read_bool (np_emif,"extended-temp-part" )) cust_cfgs->mask |=EMIF_CUSTOM_CONFIG_EXTENDED_TEMP_PART ;if (!is_custom_config_valid (cust_cfgs, emif->dev)) {
@@ -880,13 +880,9 @@ static void of_get_ddr_info(struct device_node *np_emif, struct ddr_device_info *dev_info) {u32 density =0 , io_width =0 ; -int len; -if (of_find_property (np_emif,"cs1-used" , &len)) - dev_info->cs1_used = true; - -if (of_find_property (np_emif,"cal-resistor-per-cs" , &len)) - dev_info->cal_resistors_per_cs = true; + dev_info->cs1_used =of_property_read_bool (np_emif,"cs1-used" ); + dev_info->cal_resistors_per_cs =of_property_read_bool (np_emif,"cal-resistor-per-cs" );if (of_device_is_compatible (np_ddr,"jedec,lpddr2-s4" )) dev_info->type =DDR_TYPE_LPDDR2_S4 ;
@@ -916,7 +912,6 @@ static struct emif_data *of_get_memory_device_details(struct ddr_device_info *dev_info =NULL ;struct emif_platform_data *pd =NULL ;struct device_node *np_ddr; -int len; np_ddr =of_parse_phandle (np_emif,"device-handle" ,0 );if (!np_ddr)
@@ -944,7 +939,7 @@ static struct emif_data *of_get_memory_device_details(of_property_read_u32 (np_emif,"phy-type" , &pd->phy_type); -if (of_find_property (np_emif,"hw-caps-ll-interface" , &len)) +if (of_property_read_bool (np_emif,"hw-caps-ll-interface" )) pd->hw_caps |=EMIF_HW_CAPS_LL_INTERFACE ;of_get_ddr_info (np_emif, np_ddr, dev_info);
Signature · 1 line
2.43.0
Krzysztof Kozlowski
AppliedQuoted 8 lines · Rob Herring (Arm)
Use
of_property_read_bool()to read boolean properties rather thanof_find_property(). This is part of a larger effort to remove callers ofof_find_property()and similar functions.of_find_property()leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.[...]
Applied, thanks!
[1/1] memory: emif: Use of_property_read_bool()
https://git.kernel.org/krzk/linux-mem-ctrl/c/23d22b0fe6a12317e9d17bb17720285ac4ba4d54
Best regards,
Signature · 1 line
Krzysztof Kozlowski <[email protected]>