Skip to contentSkip to conversation

Altera SOCFPGA SDRAM

PATCH In review Alessandro Zanni 2 participants 2 messages Jul 31, 2024 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Altera SOCFPGA SDRAM

Added yaml file that substitues the old txt file.

---
 .../arm/altera/socfpga-sdram-edac.txt         | 15 -------
 .../arm/altera/socfpga-sdram-edac.yaml        | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 15 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.txt
 create mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml
Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.txt deleted +0 -15
deleted file mode 100644
index f5ad0ff69fae..000000000000
@@ -1,15 +0,0 @@
-Altera SOCFPGA SDRAM Error Detection & Correction [EDAC]
-The EDAC accesses a range of registers in the SDRAM controller.
-
-Required properties:
-- compatible : should contain "altr,sdram-edac" or "altr,sdram-edac-a10"
-- altr,sdr-syscon : phandle of the sdr module
-- interrupts : Should contain the SDRAM ECC IRQ in the
-	appropriate format for the IRQ controller.
-
-Example:
-	sdramedac {
-		compatible = "altr,sdram-edac";
-		altr,sdr-syscon = <&sdr>;
-		interrupts = <0 39 4>;
-	};
Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml new file +44 -0

44 lines not on this page · raw message

Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 1 line · Alessandro Zanni

Added yaml file that substitues the old txt file.

Write subjects that match the subsystem. Use 'git log --oneline <dir>' to see this. Here, the prefix should be 'dt-bindings: '.

Use get_maintainers.pl to send this to all the correct maintainers and lists.

Quoted 38 lines
---
 .../arm/altera/socfpga-sdram-edac.txt         | 15 -------
 .../arm/altera/socfpga-sdram-edac.yaml        | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 15 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.txt
 create mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml
Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.txt deleted +0 -15
deleted file mode 100644
index f5ad0ff69fae..000000000000
@@ -1,15 +0,0 @@
-Altera SOCFPGA SDRAM Error Detection & Correction [EDAC]
-The EDAC accesses a range of registers in the SDRAM controller.
-
-Required properties:
-- compatible : should contain "altr,sdram-edac" or "altr,sdram-edac-a10"
-- altr,sdr-syscon : phandle of the sdr module
-- interrupts : Should contain the SDRAM ECC IRQ in the
-	appropriate format for the IRQ controller.
-
-Example:
-	sdramedac {
-		compatible = "altr,sdram-edac";
-		altr,sdr-syscon = <&sdr>;
-		interrupts = <0 39 4>;
-	};
Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml new file +2 -0
new file mode 100644
index 000000000000..4e70daebf1c5
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2

Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml line 12

Quoted 10 lines
Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml new file +10 -0
+---
+$id: http://devicetree.org/schemas/arm/altera/socfpga-sdram-edac.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Altera SOCFPGA SDRAM Error Detection & Correction [EDAC]
+
+maintainers:
+  - Dinh Nguyen <[email protected]>
+
+description: >

Don't need '>'

Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml line 21

Quoted 9 lines
Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml new file +9 -0
+  The EDAC accesses a range of registers in the SDRAM controller.
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - const: altr,sdram-edac
+      - items:
+          - const: altr,sdram-edac-a10

enum:
- altr,sdram-edac
- altr,sdram-edac-a10

Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml line 25

Quoted 4 lines
Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml new file +4 -0
+  altr,sdr-syscon:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: 
+      Phandle of the sdr module      

blank line

Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml line 29

Quoted 4 lines
Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml new file +4 -0
+  interrupts:
+    description: >
+      Should contain the SDRAM ECC IRQ in the
+      appropriate format for the IRQ controller.

Drop. Just need:

maxItems: 1

Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml line 32

Quoted 3 lines
Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml new file +3 -0
+
+required:
+  - compatible

All the properties were required before.

Quoted 15 lines
Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml new file +12 -0
+
+additionalProperties: false
+
+examples:
+  - |
+    sdramedac {
+      compatible = "altr,sdram-edac";
+      altr,sdr-syscon = <&sdr>;
+      interrupts = <0 39 4>;
+    };
+
+...
Signature · 1 line
2.43.0