Skip to contentSkip to conversation

Revert "doc: extension of crypto event callback announced"

PATCH New Srujana Challa 3 participants 4 messages Aug 1, 2024 – Oct 9, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "doc: extension of crypto event callback announced"

The previously planned update to the rte_cryptodev_cb_fn function prototype is being reverted. The introduction of the rte_cryptodev_queue_pair_event_error_query API provides a means for applications to retrieve the queue pair ID that encountered an error interrupt. This makes the addition of the qp_id parameter to the rte_cryptodev_cb_fn function unnecessary, and as such, the proposed extension is no longer required.

---
 doc/guides/rel_notes/deprecation.rst | 5 -----
 1 file changed, 5 deletions(-)
doc/guides/rel_notes/deprecation.rst +0 -5
index 6948641ff6..107e6a58ef 100644
@@ -115,11 +115,6 @@ Deprecation Notices
   The legacy actions should be removed
   once ``MODIFY_FIELD`` alternative is implemented in drivers.
 
-* cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
-  to have another parameter ``qp_id`` to return the queue pair ID
-  which got error interrupt to the application,
-  so that application can reset that particular queue pair.
-
 * cryptodev: The Intel IPsec Multi-Buffer version will be bumped
   to a minimum version of v1.4.
   This will effect the KASUMI, SNOW3G, ZUC, AESNI GCM, AESNI MB and CHACHAPOLY
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 Revert "doc: extension of crypto event callback announced"

The previously planned update to the rte_cryptodev_cb_fn function prototype is being reverted. The introduction of the rte_cryptodev_queue_pair_event_error_query API provides a means for applications to retrieve the queue pair ID that encountered an error interrupt. This makes the addition of the qp_id parameter to the rte_cryptodev_cb_fn function unnecessary, and as such, the proposed extension is no longer required.

---
 doc/guides/rel_notes/deprecation.rst | 5 -----
 1 file changed, 5 deletions(-)
doc/guides/rel_notes/deprecation.rst +0 -5
index 211f59fdc9..4dd592c371 100644
@@ -169,11 +169,6 @@ Deprecation Notices
 * fib: A new flag field will be introduced in ``rte_fib_conf`` structure
   in DPDK 24.11. This field will be used to pass extra configuration settings.
 
-* cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
-  to have another parameter ``qp_id`` to return the queue pair ID
-  which got error interrupt to the application,
-  so that application can reset that particular queue pair.
-
 * cryptodev: The structure ``rte_cryptodev_qp_conf`` will be updated
   to have a new parameter to set priority of that particular queue pair.
 
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#2 lore raw
Quoted 9 lines · On Thu, 1 Aug 2024 13:06:07 +0530 Srujana Challa <[email protected]> wrote:

The previously planned update to the rte_cryptodev_cb_fn function prototype is being reverted. The introduction of the rte_cryptodev_queue_pair_event_error_query API provides a means for applications to retrieve the queue pair ID that encountered an error interrupt. This makes the addition of the qp_id parameter to the rte_cryptodev_cb_fn function unnecessary, and as such, the proposed extension is no longer required.

Acked-by Applied
#3 lore raw
Quoted 11 lines
Quoted 8 lines · On Thu, 1 Aug 2024 13:06:07 +0530 Srujana Challa <[email protected]> wrote:

The previously planned update to the rte_cryptodev_cb_fn function prototype is being reverted. The introduction of the rte_cryptodev_queue_pair_event_error_query API provides a means for applications to retrieve the queue pair ID that encountered an error interrupt. This makes the addition of the qp_id parameter to the rte_cryptodev_cb_fn function unnecessary, and as such, the proposed extension is no longer required.

Quoted 3 lines
Quoted 1 line

Applied to dpdk-next-crypto
Thanks.