Skip to contentSkip to conversation

ARM: dts: aspeed: system1: IBM System1

PATCH In review Ninad Palsule 2 participants 4 messages Aug 1, 2024 – Aug 5, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover ARM: dts: aspeed: system1: IBM System1

Hello,

Please review the version 2 of the patch.

This patch only applies to openbmc/linux. The max31785 pmbus driver changes are not available in the upstream yet. I will try to send those changes upstream along with documentation changes.

v2:
--
- Removed the extra whitespace

Ninad Palsule (1):
ARM: dts: aspeed: system1: IBM System1 BMC update

 .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 95 +++++++++++++++++++
 1 file changed, 95 insertions(+)
Signature · 1 line
2.43.0
#1 lore raw

PATCH v2 1/1 ARM: dts: aspeed: system1: IBM System1 BMC update

Updated MAX31785a pmbus based fans in the device tree.

---
 .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 95 +++++++++++++++++++
 1 file changed, 95 insertions(+)
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts +95 -0
index f3efecc7eb8d0..cb3063413d1fa 100644
@@ -770,11 +770,106 @@ &i2c6 {
 	fan-controller@52 {
 		compatible = "maxim,max31785a";
 		reg = <0x52>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		fan0: fan@0 {
+			compatible = "pmbus-fan";
+			reg = <0>;
+			tach-pulses = <2>;
+			maxim,fan-rotor-input = "tach";
+			maxim,fan-pwm-freq = <25000>;
+			maxim,fan-dual-tach;
+			maxim,fan-no-watchdog;
+			maxim,fan-no-fault-ramp;
+			maxim,fan-ramp = <2>;
+			maxim,fan-fault-pin-mon;
+		};
+
+		fan1: fan@1 {
+			compatible = "pmbus-fan";
+			reg = <1>;
+			tach-pulses = <2>;
+			maxim,fan-rotor-input = "tach";
+			maxim,fan-pwm-freq = <25000>;
+			maxim,fan-dual-tach;
+			maxim,fan-no-watchdog;
+			maxim,fan-no-fault-ramp;
+			maxim,fan-ramp = <2>;
+			maxim,fan-fault-pin-mon;
+		};
+
+		fan2: fan@2 {
+			compatible = "pmbus-fan";
+			reg = <2>;
+			tach-pulses = <2>;
+			maxim,fan-rotor-input = "tach";
+			maxim,fan-pwm-freq = <25000>;
+			maxim,fan-dual-tach;
+			maxim,fan-no-watchdog;
+			maxim,fan-no-fault-ramp;
+			maxim,fan-ramp = <2>;
+			maxim,fan-fault-pin-mon;
+		};
+
+		fan3: fan@3 {
+			compatible = "pmbus-fan";
+			reg = <3>;
+			tach-pulses = <2>;
+			maxim,fan-rotor-input = "tach";
+			maxim,fan-pwm-freq = <25000>;
+			maxim,fan-dual-tach;
+			maxim,fan-no-watchdog;
+			maxim,fan-no-fault-ramp;
+			maxim,fan-ramp = <2>;
+			maxim,fan-fault-pin-mon;
+		};
+
+		fan4: fan@4 {
+			compatible = "pmbus-fan";
+			reg = <4>;
+			tach-pulses = <2>;
+			maxim,fan-rotor-input = "tach";
+			maxim,fan-pwm-freq = <25000>;
+			maxim,fan-dual-tach;
+			maxim,fan-no-watchdog;
+			maxim,fan-no-fault-ramp;
+			maxim,fan-ramp = <2>;
+			maxim,fan-fault-pin-mon;
+		};
 	};
 
 	fan-controller@54 {
 		compatible = "maxim,max31785a";
 		reg = <0x54>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		fan5: fan@0 {
+			compatible = "pmbus-fan";
+			reg = <0>;
+			tach-pulses = <2>;
+			maxim,fan-rotor-input = "tach";
+			maxim,fan-pwm-freq = <25000>;
+			maxim,fan-dual-tach;
+			maxim,fan-no-watchdog;
+			maxim,fan-no-fault-ramp;
+			maxim,fan-ramp = <2>;
+			maxim,fan-fault-pin-mon;
+		};
+
+		fan6: fan@1 {
+			compatible = "pmbus-fan";
+			reg = <1>;
+			tach-pulses = <2>;
+			maxim,fan-rotor-input = "tach";
+			maxim,fan-pwm-freq = <25000>;
+			maxim,fan-dual-tach;
+			maxim,fan-no-watchdog;
+			maxim,fan-no-fault-ramp;
+			maxim,fan-ramp = <2>;
+			maxim,fan-fault-pin-mon;
+		};
 	};
 
 	eeprom@55 {
Signature · 1 line
2.43.0
maintainer
#2 lore raw

Re: [PATCH linux dev-6.6 v2 1/1] ARM: dts: aspeed: system1: IBM System1 BMC update

Quoted 6 lines · Ninad Palsule

Updated MAX31785a pmbus based fans in the device tree.

---
 .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 95 +++++++++++++++++++
 1 file changed, 95 insertions(+)

I've applied this, not because I think it's a good idea, but because it's something the OpenBMC tree already supports. If that weren't the case then I would require that you work with upstream on the bindings as usual.

That said, please now do that work with upstream to get a sensible binding together. The less difference we have from upstream the better.

Thanks,

Andrew

PS: In the future, can you please try to be more descriptive in your patch subject than "IBM System1 BMC update"? At the very least I would like it to say something about fan configuration in this instance.

#3 lore raw

Re: [PATCH linux dev-6.6 v2 1/1] ARM: dts: aspeed: system1: IBM System1 BMC update

Hi Andrew,

Quoted 11 lines · Andrew Jeffery
Quoted 6 lines · Ninad Palsule

Updated MAX31785a pmbus based fans in the device tree.

---
  .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 95 +++++++++++++++++++
  1 file changed, 95 insertions(+)

I've applied this, not because I think it's a good idea, but because it's something the OpenBMC tree already supports. If that weren't the case then I would require that you work with upstream on the bindings as usual.

Thanks!

Quoted 3 lines

That said, please now do that work with upstream to get a sensible binding together. The less difference we have from upstream the better.

Yes, I will start working on this.

Quoted 8 lines

Thanks,

Andrew

PS: In the future, can you please try to be more descriptive in your patch subject than "IBM System1 BMC update"? At the very least I would like it to say something about fan configuration in this instance.

will do. Thanks!

Regards,

Ninad Palsule