Skip to contentSkip to conversation

staging: rtl8723bs: Delete unnecessary braces for single statement blocks

PATCH Superseded [email protected] 2 participants 2 messages Aug 1, 2024 – Aug 2, 2024 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: Delete unnecessary braces for single statement blocks

From: Jiwon Kim <[email protected]>

Deleted braces {} for single statement blocks.

Addressed scripts/checkpatch.pl warning.

---
 drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +1 -2
index 1eeabfffd6d2..e0736707a211 100644
@@ -144,9 +144,8 @@ static int rtw_mlcst2unicst(struct adapter *padapter, struct sk_buff *skb)
 		psta = list_entry(plist, struct sta_info, asoc_list);
 
 		stainfo_offset = rtw_stainfo_offset(pstapriv, psta);
-		if (stainfo_offset_valid(stainfo_offset)) {
+		if (stainfo_offset_valid(stainfo_offset))
 			chk_alive_list[chk_alive_num++] = stainfo_offset;
-		}
 	}
 	spin_unlock_bh(&pstapriv->asoc_list_lock);
 
Signature · 1 line
2.43.0
#1 lore raw
Quoted 1 line · On 8/1/24 17:51, [email protected] wrote:

From: Jiwon Kim <[email protected]>

please omit the previous line as it is not required.

Quoted 5 lines

Deleted braces {} for single statement blocks.

Addressed scripts/checkpatch.pl warning.

Please do not add extra empty lines in the description when not required. Consider that we have a lot of commits and it is most wanted that the description is short. It is not required to add the name of the tool who found this, but it can be named. Much more important is a good description why this change makes sense... For example:
... to shorten code.
... to improve readability.
Use present in the description. So Deleted should be Delete.

Quoted 10 lines
---
  drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +0 -0
index 1eeabfffd6d2..e0736707a211 100644

drivers/staging/rtl8723bs/os_dep/xmit_linux.c static int rtw_mlcst2unicst(struct adapter *padapter, struct sk_buff *skb) · line 151

Quoted 10 lines
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +1 -2
@@ -144,9 +144,8 @@ static int rtw_mlcst2unicst(struct adapter *padapter, struct sk_buff *skb)
  		psta = list_entry(plist, struct sta_info, asoc_list);
 
  		stainfo_offset = rtw_stainfo_offset(pstapriv, psta);
-		if (stainfo_offset_valid(stainfo_offset)) {
+		if (stainfo_offset_valid(stainfo_offset))
  			chk_alive_list[chk_alive_num++] = stainfo_offset;
-		}
  	}
  	spin_unlock_bh(&pstapriv->asoc_list_lock);
 

Hi Jiwon,

please consider the above comments.

Please make your "Subject" line more unique. Consider that we may end up with having dozen of commits like yours, all of them referring to different removals and all without the necessary information to tell what they differ in (except the driver/subsystem). So it would help if you add the changed file or function to make it more unique.

If you send in a second version of this patch please use a change history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Thanks for your support.

Bye Philipp