Skip to contentSkip to conversation

tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot

RFC PATCH Applied Philippe Mathieu-Daudé 3 participants 5 messages Aug 1, 2024 – Aug 5, 2024

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot

We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
rationalise unstable gitlab tests under FLAKY_TESTS") for being flaky. However I don't recall the U-Boot test to fail (the problematic line checking the 'version' string is already commented out), and I'm running this test reliably, so re-enable it.

---
 tests/avocado/machine_rx_gdbsim.py | 2 --
 1 file changed, 2 deletions(-)
tests/avocado/machine_rx_gdbsim.py +0 -2
index 412a7a5089..a83873b738 100644
@@ -22,8 +22,6 @@ class RxGdbSimMachine(QemuSystemTest):
     timeout = 30
     KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
 
-    @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab')
-
     def test_uboot(self):
         """
         U-Boot and checks that the console is operational.
Signature · 1 line
2.45.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 29 lines · Philippe Mathieu-Daudé

We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
rationalise unstable gitlab tests under FLAKY_TESTS") for being flaky. However I don't recall the U-Boot test to fail (the problematic line checking the 'version' string is already commented out), and I'm running this test reliably, so re-enable it.

---
 tests/avocado/machine_rx_gdbsim.py | 2 --
 1 file changed, 2 deletions(-)
tests/avocado/machine_rx_gdbsim.py +0 -2
index 412a7a5089..a83873b738 100644
@@ -22,8 +22,6 @@ class RxGdbSimMachine(QemuSystemTest):
     timeout = 30
     KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
 
-    @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab')
-
     def test_uboot(self):
         """
         U-Boot and checks that the console is operational.
Signature · 1 line
2.45.2
Signature · 1 line
Yosinori Sato
#2 lore raw
Quoted 10 lines · Yoshinori Sato
Quoted 8 lines · Philippe Mathieu-Daudé

We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
rationalise unstable gitlab tests under FLAKY_TESTS") for being flaky. However I don't recall the U-Boot test to fail (the problematic line checking the 'version' string is already commented out), and I'm running this test reliably, so re-enable it.

Quoted 6 lines
Quoted 4 lines
---
  tests/avocado/machine_rx_gdbsim.py | 2 --
  1 file changed, 2 deletions(-)

Thanks, I'll queue this patch for 9.2 to avoid messing with the next release.

Regards,

Phil.

#3 lore raw
Quoted 16 lines · Philippe Mathieu-Daudé
Quoted 14 lines · Yoshinori Sato
Quoted 12 lines · Philippe Mathieu-Daudé

We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
rationalise unstable gitlab tests under FLAKY_TESTS") for being flaky. However I don't recall the U-Boot test to fail (the problematic line checking the 'version' string is already commented out), and I'm running this test reliably, so re-enable it.

---
  tests/avocado/machine_rx_gdbsim.py | 2 --
  1 file changed, 2 deletions(-)
Quoted 4 lines
Quoted 1 line

Thanks, I'll queue this patch for 9.2 to avoid messing with the next release.

Testing updates are usually fine, but I can leave it to you to merge if you prefer.

Quoted 4 lines

Regards,

Phil.

Signature · 2 lines
Alex Bennée
Virtualisation Tech Lead @ Linaro
Applied
#4 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 8 lines · Philippe Mathieu-Daudé

We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
rationalise unstable gitlab tests under FLAKY_TESTS") for being flaky. However I don't recall the U-Boot test to fail (the problematic line checking the 'version' string is already commented out), and I'm running this test reliably, so re-enable it.

Queued to for-9.1/misc-fixes, thanks.

Signature · 2 lines
Alex Bennée
Virtualisation Tech Lead @ Linaro