eth: fbnic: select devlink
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 eth: fbnic: select devlink
Build bot reports undefined references to devlink functions in fbnic.ko.
---
CC: [email protected]
--- drivers/net/ethernet/meta/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/meta/Kconfig +1 -0
@@ -23,6 +23,7 @@ config FBNIC depends on !S390 depends on MAX_SKB_FRAGS < 22 depends on PCI_MSI + select NET_DEVLINK select PHYLINK help This driver supports Meta Platforms Host Network Interface.
Signature · 1 line
2.45.2
Quoted 7 lines · Jakub Kicinski
Build bot reports undefined references to devlink functions in fbnic.ko.
Fixes 1a9d48892ea5 ("eth: fbnic: Allocate core device specific structures and devlink interface")Reported-by kernel test robot <[email protected]>Signed-off-by Jakub Kicinski <[email protected]>
Thanks, I agree this is needed.
But while exercising this I noticed that PAGE_POOL is also needed, which I locally resolved by adding:
select PAGE_POOL
I can provide a follow-up patch after this one is merged. Or perhaps you can address this in a v2?
I have no preference either way.
Jakub Kicinski
maintainerQuoted 2 lines · On Fri, 2 Aug 2024 15:50:38 +0100 Simon Horman wrote:
But while exercising this I noticed that
PAGE_POOLis also needed, which I locally resolved by adding:
Oh, good catch. I'm a bit surprised how slow kbuild bot is :(
Quoted 5 lines
select
PAGE_POOLI can provide a follow-up patch after this one is merged. Or perhaps you can address this in a v2?
I have no preference either way.
Please send your version with both selects, I'll mark mine as superseded
Simon Horman
reviewerQuoted 6 lines · Jakub Kicinski
Quoted 2 lines · On Fri, 2 Aug 2024 15:50:38 +0100 Simon Horman wrote:
But while exercising this I noticed that
PAGE_POOLis also needed, which I locally resolved by adding:Oh, good catch. I'm a bit surprised how slow kbuild bot is :(
Quoted 7 lines
Quoted 5 lines
select
PAGE_POOLI can provide a follow-up patch after this one is merged. Or perhaps you can address this in a v2?
I have no preference either way.Please send your version with both selects, I'll mark mine as superseded
Sure. I'll set myself as the author, to save negotiating about that, and as it's only two lines. Do feel free to update as you see fit.