Skip to contentSkip to conversation

net: skbuff: sprinkle more __GFP_NOWARN on ingress allocs

PATCH In review Jakub Kicinski 3 participants 5 messages Aug 2, 2024 – Aug 5, 2024

Subsystems (2)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 net: skbuff: sprinkle more __GFP_NOWARN on ingress allocs

build_skb() and frag allocations done with GFP_ATOMIC will fail in real life, when system is under memory pressure, and there's nothing we can do about that. So no point printing warnings.

---
 net/core/skbuff.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
net/core/skbuff.c +9 -6
index 83f8cd8aa2d1..de2a044cc665 100644
@@ -314,8 +314,8 @@ void *__napi_alloc_frag_align(unsigned int fragsz, unsigned int align_mask)
 	fragsz = SKB_DATA_ALIGN(fragsz);
 
 	local_lock_nested_bh(&napi_alloc_cache.bh_lock);
-	data = __page_frag_alloc_align(&nc->page, fragsz, GFP_ATOMIC,
-				       align_mask);
+	data = __page_frag_alloc_align(&nc->page, fragsz,
+				       GFP_ATOMIC | __GFP_NOWARN, align_mask);
 	local_unlock_nested_bh(&napi_alloc_cache.bh_lock);
 	return data;
 
@@ -330,7 +330,8 @@ void *__netdev_alloc_frag_align(unsigned int fragsz, unsigned int align_mask)
 		struct page_frag_cache *nc = this_cpu_ptr(&netdev_alloc_cache);
 
 		fragsz = SKB_DATA_ALIGN(fragsz);
-		data = __page_frag_alloc_align(nc, fragsz, GFP_ATOMIC,
+		data = __page_frag_alloc_align(nc, fragsz,
+					       GFP_ATOMIC | __GFP_NOWARN,
 					       align_mask);
 	} else {
 		local_bh_disable();
@@ -349,7 +350,7 @@ static struct sk_buff *napi_skb_cache_get(void)
 	local_lock_nested_bh(&napi_alloc_cache.bh_lock);
 	if (unlikely(!nc->skb_count)) {
 		nc->skb_count = kmem_cache_alloc_bulk(net_hotdata.skbuff_cache,
-						      GFP_ATOMIC,
+						      GFP_ATOMIC | __GFP_NOWARN,
 						      NAPI_SKB_CACHE_BULK,
 						      nc->skb_cache);
 		if (unlikely(!nc->skb_count)) {
@@ -418,7 +419,8 @@ struct sk_buff *slab_build_skb(void *data)
 	struct sk_buff *skb;
 	unsigned int size;
 
-	skb = kmem_cache_alloc(net_hotdata.skbuff_cache, GFP_ATOMIC);
+	skb = kmem_cache_alloc(net_hotdata.skbuff_cache,
+			       GFP_ATOMIC | __GFP_NOWARN);
 	if (unlikely(!skb))
 		return NULL;
 
@@ -469,7 +471,8 @@ struct sk_buff *__build_skb(void *data, unsigned int frag_size)
 {
 	struct sk_buff *skb;
 
-	skb = kmem_cache_alloc(net_hotdata.skbuff_cache, GFP_ATOMIC);
+	skb = kmem_cache_alloc(net_hotdata.skbuff_cache,
+			       GFP_ATOMIC | __GFP_NOWARN);
 	if (unlikely(!skb))
 		return NULL;
 
Signature · 1 line
2.45.2
#1 lore raw

Hello Jakub,

Quoted 3 lines · Jakub Kicinski

build_skb() and frag allocations done with GFP_ATOMIC will fail in real life, when system is under memory pressure,

It's true. It can frequently happen under huge pressure.

Quoted 2 lines

and there's nothing we can do about that. So no point printing warnings.

As you said, we cannot handle it because of that flag, but I wonder if we at least let users/admins know about this failure, like: adding MIB counter or trace_alloc_skb() tracepoint, which can also avoid printing too many useless/necessary warnings. Or else, people won't know what exactly happens in the kernel.

Thanks,
Jason

Quoted 64 lines
---
 net/core/skbuff.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
net/core/skbuff.c +9 -7
index 83f8cd8aa2d1..de2a044cc665 100644
@@ -314,8 +314,8 @@ void *__napi_alloc_frag_align(unsigned int fragsz, unsigned int align_mask)
        fragsz = SKB_DATA_ALIGN(fragsz);
 
        local_lock_nested_bh(&napi_alloc_cache.bh_lock);
-       data = __page_frag_alloc_align(&nc->page, fragsz, GFP_ATOMIC,
-                                      align_mask);
+       data = __page_frag_alloc_align(&nc->page, fragsz,
+                                      GFP_ATOMIC | __GFP_NOWARN, align_mask);
        local_unlock_nested_bh(&napi_alloc_cache.bh_lock);
        return data;
 
@@ -330,7 +330,8 @@ void *__netdev_alloc_frag_align(unsigned int fragsz, unsigned int align_mask)
                struct page_frag_cache *nc = this_cpu_ptr(&netdev_alloc_cache);
 
                fragsz = SKB_DATA_ALIGN(fragsz);
-               data = __page_frag_alloc_align(nc, fragsz, GFP_ATOMIC,
+               data = __page_frag_alloc_align(nc, fragsz,
+                                              GFP_ATOMIC | __GFP_NOWARN,
                                               align_mask);
        } else {
                local_bh_disable();
@@ -349,7 +350,7 @@ static struct sk_buff *napi_skb_cache_get(void)
        local_lock_nested_bh(&napi_alloc_cache.bh_lock);
        if (unlikely(!nc->skb_count)) {
                nc->skb_count = kmem_cache_alloc_bulk(net_hotdata.skbuff_cache,
-                                                     GFP_ATOMIC,
+                                                     GFP_ATOMIC | __GFP_NOWARN,
                                                      NAPI_SKB_CACHE_BULK,
                                                      nc->skb_cache);
                if (unlikely(!nc->skb_count)) {
@@ -418,7 +419,8 @@ struct sk_buff *slab_build_skb(void *data)
        struct sk_buff *skb;
        unsigned int size;
 
-       skb = kmem_cache_alloc(net_hotdata.skbuff_cache, GFP_ATOMIC);
+       skb = kmem_cache_alloc(net_hotdata.skbuff_cache,
+                              GFP_ATOMIC | __GFP_NOWARN);
        if (unlikely(!skb))
                return NULL;
 
@@ -469,7 +471,8 @@ struct sk_buff *__build_skb(void *data, unsigned int frag_size)
 {
        struct sk_buff *skb;
 
-       skb = kmem_cache_alloc(net_hotdata.skbuff_cache, GFP_ATOMIC);
+       skb = kmem_cache_alloc(net_hotdata.skbuff_cache,
+                              GFP_ATOMIC | __GFP_NOWARN);
        if (unlikely(!skb))
                return NULL;
 
--

2.45.2

author maintainer
#2 lore raw
Quoted 8 lines · On Fri, 2 Aug 2024 12:52:06 +0800 Jason Xing wrote:
Quoted 2 lines

and there's nothing we can do about that. So no point printing warnings.

As you said, we cannot handle it because of that flag, but I wonder if we at least let users/admins know about this failure, like: adding MIB counter or trace_alloc_skb() tracepoint, which can also avoid printing too many useless/necessary warnings. Or else, people won't know what exactly happens in the kernel.

Hm, maybe... I prefer not to add counters and trace points upstream until they have sat for a few months in production and proven their usefulness.

We also have a driver-level, per device counter already:
https://docs.kernel.org/next/networking/netlink_spec/netdev.html#rx-alloc-fail-uint
and I'm pretty sure system level OOM tracking will indicate severe OOM conditions as well.

#3 lore raw
Quoted 11 lines · Jakub Kicinski
Quoted 8 lines · On Fri, 2 Aug 2024 12:52:06 +0800 Jason Xing wrote:
Quoted 2 lines

and there's nothing we can do about that. So no point printing warnings.

As you said, we cannot handle it because of that flag, but I wonder if we at least let users/admins know about this failure, like: adding MIB counter or trace_alloc_skb() tracepoint, which can also avoid printing too many useless/necessary warnings. Or else, people won't know what exactly happens in the kernel.

Quoted 8 lines

Hm, maybe... I prefer not to add counters and trace points upstream until they have sat for a few months in production and proven their usefulness.

We also have a driver-level, per device counter already:
https://docs.kernel.org/next/networking/netlink_spec/netdev.html#rx-alloc-fail-uint
and I'm pretty sure system level OOM tracking will indicate severe OOM conditions as well.

Thanks for your explanation. I see.