Skip to contentSkip to conversation

firmware: ti_sci: add CPU latency constraint management

PATCH In review Kevin Hilman 2 participants 3 messages Aug 2, 2024 – Aug 6, 2024 Texas instruments' system control interface (TISCI) protocol driver

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 firmware: ti_sci: add CPU latency constraint management

During system-wide suspend, check if any of the CPUs have PM QoS resume latency constraints set. If so, set TI SCI constraint.

TI SCI has a single system-wide latency constraint, so use the max of any of the CPU latencies as the system-wide value.

Note: DM firmware clears all constraints at resume time, so constraints need to be checked/updated/sent at each system suspend.

---
Depends on the TI SCI series where support for the constraints APIs are added:
https://lore.kernel.org/r/[email protected]

v2->v3: actually fixed silly compile error

v1->v2: fixed silly compile error

 drivers/firmware/ti_sci.c | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)
drivers/firmware/ti_sci.c +21 -1
index c6544cc12417..097417526ff8 100644
@@ -9,6 +9,7 @@
 #define pr_fmt(fmt) "%s: " fmt, __func__
 
 #include <linux/bitmap.h>
+#include <linux/cpu.h>
 #include <linux/debugfs.h>
 #include <linux/export.h>
 #include <linux/io.h>
@@ -19,6 +20,7 @@
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>
+#include <linux/pm_qos.h>
 #include <linux/property.h>
 #include <linux/semaphore.h>
 #include <linux/slab.h>
@@ -3640,7 +3642,25 @@ static int ti_sci_prepare_system_suspend(struct ti_sci_info *info)
 static int ti_sci_suspend(struct device *dev)
 {
 	struct ti_sci_info *info = dev_get_drvdata(dev);
-	int ret;
+	struct device *cpu_dev;
+	s32 val, cpu_lat = 0;
+	int i, ret;
+
+	if (info->fw_caps & MSG_FLAG_CAPS_LPM_DM_MANAGED) {
+		for_each_possible_cpu(i) {
+			cpu_dev = get_cpu_device(i);
+			val = dev_pm_qos_read_value(cpu_dev, DEV_PM_QOS_RESUME_LATENCY);
+			if (val != PM_QOS_RESUME_LATENCY_NO_CONSTRAINT)
+				cpu_lat = max(cpu_lat, val);
+		}
+		if (cpu_lat && (cpu_lat != PM_QOS_RESUME_LATENCY_NO_CONSTRAINT)) {
+			dev_dbg(cpu_dev, "%s: sending max CPU latency=%u\n", __func__, cpu_lat);
+			ret = ti_sci_cmd_set_latency_constraint(&info->handle,
+								cpu_lat, TISCI_MSG_CONSTRAINT_SET);
+			if (ret)
+				return ret;
+		}
+	}
 
 	ret = ti_sci_prepare_system_suspend(info);
 	if (ret)
Signature · 1 line
2.46.0
maintainer
#1 lore raw
Quoted 14 lines · Kevin Hilman

During system-wide suspend, check if any of the CPUs have PM QoS resume latency constraints set. If so, set TI SCI constraint.

TI SCI has a single system-wide latency constraint, so use the max of any of the CPU latencies as the system-wide value.

Note: DM firmware clears all constraints at resume time, so constraints need to be checked/updated/sent at each system suspend.

Quoted 5 lines

---
Depends on the TI SCI series where support for the constraints APIs are added:
https://lore.kernel.org/r/[email protected]

Unless there is a reason to maintain this patch separately, Could we add this to the mentioned series -> it is much easier to review and merge them in one go.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#2 lore raw
Quoted 21 lines · Nishanth Menon
Quoted 14 lines · Kevin Hilman

During system-wide suspend, check if any of the CPUs have PM QoS resume latency constraints set. If so, set TI SCI constraint.

TI SCI has a single system-wide latency constraint, so use the max of any of the CPU latencies as the system-wide value.

Note: DM firmware clears all constraints at resume time, so constraints need to be checked/updated/sent at each system suspend.

Quoted 5 lines

---
Depends on the TI SCI series where support for the constraints APIs are added:
https://lore.kernel.org/r/[email protected]

Quoted 3 lines

Unless there is a reason to maintain this patch separately, Could we add this to the mentioned series -> it is much easier to review and merge them in one go.

Sure, they can be combined for the next version.

Kevin