Skip to contentSkip to conversation

Makefile: add $(srctree) to dependency of compile_commands.json target

PATCH In review Alexandre Courbot 3 participants 5 messages Aug 4, 2024 – Aug 6, 2024 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Makefile: add $(srctree) to dependency of compile_commands.json target

When trying to build the compile_commands.json target from an external module's directory, the following error is displayed:

make[1]: *** No rule to make target 'scripts/clang-tools/gen_compile_commands.py', needed by 'compile_commands.json'. Stop.

This is because gen_compile_commands.py was previously looked up using a relative path to $(srctree), but commit b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory") stopped defining VPATH for external module builds.

Prefixing gen_compile_commands.py with $(srctree) fixes the problem.

Fixes b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory")
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 8ad55d6e7b60..52d7dfe4212a 100644
@@ -1980,7 +1980,7 @@ nsdeps: modules
 quiet_cmd_gen_compile_commands = GEN     $@
       cmd_gen_compile_commands = $(PYTHON3) $< -a $(AR) -o $@ $(filter-out $<, $(real-prereqs))
 
-$(extmod_prefix)compile_commands.json: scripts/clang-tools/gen_compile_commands.py \
+$(extmod_prefix)compile_commands.json: $(srctree)/scripts/clang-tools/gen_compile_commands.py \
 	$(if $(KBUILD_EXTMOD),, vmlinux.a $(KBUILD_VMLINUX_LIBS)) \
 	$(if $(CONFIG_MODULES), $(MODORDER)) FORCE
 	$(call if_changed,gen_compile_commands)
Signature · 1 line
2.46.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 35 lines · On Sun, Aug 04, 2024 at 02:50:57PM +0900 Alexandre Courbot wrote:

When trying to build the compile_commands.json target from an external module's directory, the following error is displayed:

make[1]: *** No rule to make target 'scripts/clang-tools/gen_compile_commands.py', needed by 'compile_commands.json'. Stop.

This is because gen_compile_commands.py was previously looked up using a relative path to $(srctree), but commit b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory") stopped defining VPATH for external module builds.

Prefixing gen_compile_commands.py with $(srctree) fixes the problem.

Fixes b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory")
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 8ad55d6e7b60..52d7dfe4212a 100644
@@ -1980,7 +1980,7 @@ nsdeps: modules
 quiet_cmd_gen_compile_commands = GEN     $@
       cmd_gen_compile_commands = $(PYTHON3) $< -a $(AR) -o $@ $(filter-out $<, $(real-prereqs))
 
-$(extmod_prefix)compile_commands.json: scripts/clang-tools/gen_compile_commands.py \
+$(extmod_prefix)compile_commands.json: $(srctree)/scripts/clang-tools/gen_compile_commands.py \
 	$(if $(KBUILD_EXTMOD),, vmlinux.a $(KBUILD_VMLINUX_LIBS)) \
 	$(if $(CONFIG_MODULES), $(MODORDER)) FORCE
 	$(call if_changed,gen_compile_commands)
Signature · 1 line
2.46.0

thanks, looks good to me.

#2 lore raw
In reply to Alexandre Courbot
Quoted 3 lines · Alexandre Courbot

When trying to build the compile_commands.json target from an external module's directory, the following error is displayed:

As I mentioned in v1, this issue only happens when using the kernel directory built in a separate output directory (O=).

Unless you have a opposition, I will reword this sentence as follows:

When trying to build compile_commands.json for an external module against the kernel built in a separate output directory, the following error is displayed:

Quoted 34 lines

make[1]: *** No rule to make target 'scripts/clang-tools/gen_compile_commands.py', needed by 'compile_commands.json'. Stop.

This is because gen_compile_commands.py was previously looked up using a relative path to $(srctree), but commit b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory") stopped defining VPATH for external module builds.

Prefixing gen_compile_commands.py with $(srctree) fixes the problem.

Fixes b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory")
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -2
index 8ad55d6e7b60..52d7dfe4212a 100644
@@ -1980,7 +1980,7 @@ nsdeps: modules
 quiet_cmd_gen_compile_commands = GEN     $@
       cmd_gen_compile_commands = $(PYTHON3) $< -a $(AR) -o $@ $(filter-out $<, $(real-prereqs))
 
-$(extmod_prefix)compile_commands.json: scripts/clang-tools/gen_compile_commands.py \
+$(extmod_prefix)compile_commands.json: $(srctree)/scripts/clang-tools/gen_compile_commands.py \
        $(if $(KBUILD_EXTMOD),, vmlinux.a $(KBUILD_VMLINUX_LIBS)) \
        $(if $(CONFIG_MODULES), $(MODORDER)) FORCE
        $(call if_changed,gen_compile_commands)
--

2.46.0

Signature · 2 lines
Best Regards
Masahiro Yamada
#3 lore raw
Quoted 7 lines · Masahiro Yamada
Quoted 3 lines · Alexandre Courbot

When trying to build the compile_commands.json target from an external module's directory, the following error is displayed:

Quoted 8 lines

As I mentioned in v1, this issue only happens when using the kernel directory built in a separate output directory (O=).

Unless you have a opposition, I will reword this sentence as follows:

When trying to build compile_commands.json for an external module against the kernel built in a separate output directory, the following error is displayed:

Sounds perfect! Thank you.
Alex.

Quoted 45 lines
Quoted 37 lines

make[1]: *** No rule to make target 'scripts/clang-tools/gen_compile_commands.py', needed by 'compile_commands.json'. Stop.

This is because gen_compile_commands.py was previously looked up using a relative path to $(srctree), but commit b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory") stopped defining VPATH for external module builds.

Prefixing gen_compile_commands.py with $(srctree) fixes the problem.

Fixes b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory")
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -2
index 8ad55d6e7b60..52d7dfe4212a 100644
@@ -1980,7 +1980,7 @@ nsdeps: modules
 quiet_cmd_gen_compile_commands = GEN     $@
       cmd_gen_compile_commands = $(PYTHON3) $< -a $(AR) -o $@ $(filter-out $<, $(real-prereqs))
 
-$(extmod_prefix)compile_commands.json: scripts/clang-tools/gen_compile_commands.py \
+$(extmod_prefix)compile_commands.json: $(srctree)/scripts/clang-tools/gen_compile_commands.py \
        $(if $(KBUILD_EXTMOD),, vmlinux.a $(KBUILD_VMLINUX_LIBS)) \
        $(if $(CONFIG_MODULES), $(MODORDER)) FORCE
        $(call if_changed,gen_compile_commands)
--
Quoted 3 lines

2.46.0

--
Best Regards
Masahiro Yamada

#4 lore raw
Quoted 12 lines · Alexandre Courbot
Quoted 10 lines · Masahiro Yamada
Quoted 3 lines · Alexandre Courbot

When trying to build the compile_commands.json target from an external module's directory, the following error is displayed:

As I mentioned in v1, this issue only happens when using the kernel directory built in a separate output directory (O=).

Quoted 9 lines
Quoted 5 lines

Unless you have a opposition, I will reword this sentence as follows:

When trying to build compile_commands.json for an external module against the kernel built in a separate output directory, the following error is displayed:

Sounds perfect! Thank you.
Alex.

Applied to linux-kbuild/fixes.
Thanks.

Signature · 2 lines
Best Regards
Masahiro Yamada