getrusage03: Forcing context switches to update resource usage
PATCH 1/1 getrusage03: Forcing context switches to update resource usage
Our CI sporadically complains that this test grandchild's MAXRSS did not reach the expected 300MB size.
12 getrusage03.c:86: TFAIL: child.children = 258048, expected 307200
As the ru_maxrss value is generally updated at certain intervals or under specific conditions, such as page faults or context switches. There may be delay between the completion of memset() and the update of ru_maxrss.
To address this issue, we create a function to force context switches by calling sched_yield() multiple times. This approach helps to ensure that the system has the opportunity to update the ru_maxrss value more promptly.
--- testcases/kernel/syscalls/getrusage/getrusage03.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
testcases/kernel/syscalls/getrusage/getrusage03.h +11 -0
@@ -6,10 +6,19 @@#ifndef LTP_GETRUSAGE03_H #define LTP_GETRUSAGE03_H +#include <sched.h> #include "tst_test.h" #define DELTA_MAX 20480 +static void force_context_switches (int iterations) +{ +tst_res (TINFO ,"Forcing context switch %d times" , iterations); + +for (int i =0 ; i < iterations; i++) +sched_yield (); +} +static void consume_mb (int consume_nr) {void *ptr;
@@ -22,6 +31,8 @@ static void consume_mb(int consume_nr) ptr =SAFE_MALLOC (size);memset (ptr,0 , size); +force_context_switches (10 ); +SAFE_FILE_LINES_SCANF ("/proc/self/status" ,"VmSwap: %lu" , &vmswap_size);if (vmswap_size >0 )tst_brk (TBROK ,"VmSwap is not zero" );
Signature · 5 lines
2.45.2 -- Mailing list info: https://lists.linux.it/listinfo/ltp
I proposed a patch in upstream ML:
https://lists.linux.it/pipermail/ltp/2024-August/039693.html
Quoted 63 lines · Li Wang
Our CI sporadically complains that this test grandchild's MAXRSS did not reach
the expected 300MB size.12 getrusage03.c:86: TFAIL: child.children = 258048, expected 307200As the
ru_maxrssvalue is generally updated at certain intervals or under specific conditions, such as page faults or context switches. There may be delay between the completion ofmemset()and the update ofru_maxrss.To address this issue, we create a function to force context switches by calling
sched_yield()multiple times. This approach helps to ensure that the system has the opportunity to update theru_maxrssvalue more promptly.Reproted-by Scott Weaver <[email protected]>Signed-off-by Li Wang <[email protected]>--- testcases/kernel/syscalls/getrusage/getrusage03.h | 11 +++++++++++ 1 file changed, 11 insertions(+)testcases/kernel/syscalls/getrusage/getrusage03.h +11
-0@@ -6,10 +6,19 @@#ifndef LTP_GETRUSAGE03_H #define LTP_GETRUSAGE03_H +#include <sched.h> #include "tst_test.h" #define DELTA_MAX 20480 +static void force_context_switches (int iterations) +{ +tst_res (TINFO ,"Forcing context switch %d times" , iterations); + +for (int i =0 ; i < iterations; i++) +sched_yield (); +} +static void consume_mb (int consume_nr) {void *ptr;@@ -22,6 +31,8 @@ static void consume_mb(int consume_nr) ptr =SAFE_MALLOC (size);memset (ptr,0 , size); +force_context_switches (10 ); +SAFE_FILE_LINES_SCANF ("/proc/self/status" ,"VmSwap: %lu" , &vmswap_size);if (vmswap_size >0 )tst_brk(TBROK, "VmSwap is not zero");--
2.45.2--
Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 9 lines
Our CI sporadically complains that this test grandchild's MAXRSS did not reach the expected 300MB size.
12 getrusage03.c:86: TFAIL: child.children = 258048, expected 307200As the
ru_maxrssvalue is generally updated at certain intervals or under specific conditions, such as page faults or context switches. There may be delay between the completion ofmemset()and the update ofru_maxrss.
Quoted 6 lines
To address this issue, we create a function to force context switches by calling
sched_yield()multiple times. This approach helps to ensure that the system has the opportunity to update theru_maxrssvalue more promptly.Reproted-by Scott Weaver <[email protected]>Signed-off-by Li Wang <[email protected]>
This looks forgotten but should probably go in before the release...
Anyways:
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 17 lines · Cyril Hrubis
Hi!
Quoted 1 line
Our CI sporadically complains that this test grandchild's MAXRSS did not
reach
Quoted 6 lines
the expected 300MB size.
12 getrusage03.c:86: TFAIL: child.children = 258048, expected 307200As the
ru_maxrssvalue is generally updated at certain intervals or under specific conditions, such as page faults or context switches. There maybe
Quoted 5 lines
delay between the completion of
memset()and the update ofru_maxrss.To address this issue, we create a function to force context switches by calling
sched_yield()multiple times. This approach helps to ensure that the system has the opportunity to update theru_maxrssvalue morepromptly.
Quoted 1 line
Quoted 9 lines
Quoted 2 lines
Reproted-by Scott Weaver <[email protected]>Signed-off-by Li Wang <[email protected]>This looks forgotten but should probably go in before the release...
Anyways:
Reviewed-by Cyril Hrubis <[email protected]>
Thank you, patch pushed.
The worth to say that I created the separated function force_context_switches
to accept an argument for setting context switch times, because I think maybe
other tests also need that, so in the future if we catch something failure likeru_maxrss updating issue, we could move this function to LTP library.
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp