usb: xhci: fix duplicate stall handling in handle_tx_event()
Subsystems (2)
PATCH 1/1 usb: xhci: fix duplicate stall handling in handle_tx_event()
Stall handling is managed in the 'process_*' functions, which are called right before the 'goto' stall handling code snippet. Thus, there should be a return after the 'process_*' functions. Otherwise, the stall code may run twice.
Fixes 1b349f214ac7 ("usb: xhci: add 'goto' for halted endpoint check in handle_tx_event()")
Reported-by Michal Pecio <[email protected]>
Signed-off-by Niklas Neronin <[email protected]>
--- drivers/usb/host/xhci-ring.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/host/xhci-ring.c +1 -0
@@ -2910,6 +2910,7 @@ static int handle_tx_event(struct xhci_hcd *xhci,process_isoc_td (xhci, ep, ep_ring, td, ep_trb, event); elseprocess_bulk_intr_td (xhci ,ep ,ep_ring ,td ,ep_trb ,event ); +return 0 ; check_endpoint_halted:if (xhci_halted_host_endpoint (ep_ctx, trb_comp_code))
Signature · 1 line
2.43.0