Skip to contentSkip to conversation

drm/rockchip: inno-hdmi: Fix infoframe upload

PATCH Applied Alex Bee 3 participants 3 messages Aug 5, 2024 – Aug 15, 2024

Subsystems (4)
lore
Share & tools
lore

Alex Bee

author
#0 lore raw

PATCH 1/1 drm/rockchip: inno-hdmi: Fix infoframe upload

HDMI analyser shows that the AVI infoframe is no being longer send.

The switch to the HDMI connector api should have used the frame content which is now given in the buffer parameter, but instead still uses the (now) empty and superfluous packed_frame variable.

Fix it.

Fixes 65548c8ff0ab ("drm/rockchip: inno_hdmi: Switch to HDMI connector")
---
 drivers/gpu/drm/rockchip/inno_hdmi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/rockchip/inno_hdmi.c +1 -3
index 2241e53a2946..dec6913cec5b 100644
@@ -279,7 +279,6 @@ static int inno_hdmi_upload_frame(struct drm_connector *connector,
 				  const u8 *buffer, size_t len)
 {
 	struct inno_hdmi *hdmi = connector_to_inno_hdmi(connector);
-	u8 packed_frame[HDMI_MAXIMUM_INFO_FRAME_SIZE];
 	ssize_t i;
 
 	if (type != HDMI_INFOFRAME_TYPE_AVI) {
@@ -291,8 +290,7 @@ static int inno_hdmi_upload_frame(struct drm_connector *connector,
 	inno_hdmi_disable_frame(connector, type);
 
 	for (i = 0; i < len; i++)
-		hdmi_writeb(hdmi, HDMI_CONTROL_PACKET_ADDR + i,
-			    packed_frame[i]);
+		hdmi_writeb(hdmi, HDMI_CONTROL_PACKET_ADDR + i, buffer[i]);
 
 	return 0;
 }
Signature · 1 line
2.45.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Alex Bee

HDMI analyser shows that the AVI infoframe is no being longer send.

The switch to the HDMI connector api should have used the frame content which is now given in the buffer parameter, but instead still uses the (now) empty and superfluous packed_frame variable.

[ ... ]

Thanks!
Maxime

maintainer Applied
#2 lore raw
In reply to Alex Bee
Quoted 9 lines · Alex Bee

HDMI analyser shows that the AVI infoframe is no being longer send.

The switch to the HDMI connector api should have used the frame content which is now given in the buffer parameter, but instead still uses the (now) empty and superfluous packed_frame variable.

Fix it.

[...]

Applied, thanks!

[1/1] drm/rockchip: inno-hdmi: Fix infoframe upload

      commit: fd45cc614b8acca5bb435ba37fe9b3f9a17fab84

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>