Input: MT - limit max slots
Subsystems (2)
Sasha Levin
maintainerPATCH 1/1 Input: MT - limit max slots
From: Tetsuo Handa <[email protected]>
[ Upstream commit 99d3bf5f7377d42f8be60a6b9cb60fb0be34dceb ]
syzbot is reporting too large allocation at input_mt_init_slots(), for num_slots is supplied from userspace using ioctl(UI_DEV_CREATE).
Since nobody knows possible max slots, this patch chose 1024.
Reported-by syzbot <[email protected]>
Suggested-by Dmitry Torokhov <[email protected]>
Signed-off-by Tetsuo Handa <[email protected]>
Signed-off-by Linus Torvalds <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
--- drivers/input/input-mt.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/input/input-mt.c +3 -0
@@ -48,6 +48,9 @@ int input_mt_init_slots(struct input_dev *dev, unsigned int num_slots,return 0 ;if (mt)return mt->num_slots != num_slots ? -EINVAL :0 ; +/* Arbitrary limit for avoiding too large memory allocation. */ +if (num_slots >1024 ) +return -EINVAL ; mt =kzalloc (struct_size (mt, slots, num_slots),GFP_KERNEL );if (!mt)
Signature · 1 line
2.43.0