mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool
Subsystems (2)
v5 cover mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool
From: Alex Shi <[email protected]>
According to Metthew's plan, the page descriptor will be replace by a 8 bytes mem_desc on destination purpose.
https://lore.kernel.org/lkml/[email protected]/
Here is a implement on zsmalloc to replace page descriptor by 'zpdesc', which is still overlay on struct page now. but it's a step move forward above destination.
To name the struct zpdesc instead of zsdesc, since there are still 3 zpools under zswap: zbud, z3fold, zsmalloc for now(z3fold maybe removed soon), and we could easyly extend it to other zswap.zpool in needs.
For all zswap.zpools, they are all using single page since often used under memory pressure. So the conversion via folio series helper is better than page's for compound_head check saving.
For now, all zpools are using some page struct members, like page.flags for PG_private/PG_locked. and list_head lru, page.mapping for page migration.
This patachset does not increase the descriptor size nor introduce any functional changes, and could save about 122Kbytes zsmalloc.o size.
Thanks a lot for comments and suggestion from Yosry, Yoo, Sergey, Willy and Vishal!
Thanks
Alex
---v4->v5:
- rebase on akpm/mm-unstable on Aug 4.
- add a helper and update code comments accroding to Sergey's comments
- fold patch 20/21, remove 3 helpers functions according to Vishal's comments
v3->v4:
- rebase on akpm/mm-unstable Jul 21
- fixed a build warning reported by LKP
- Add a comment update for struct page to zpdesc change
v2->v3:
- Fix LKP reported build issue
- Update the Usage of struct zpdesc fields.
- Rebase onto latest mm-unstable commit 2073cda629a4
v1->v2:
- Take Yosry and Yoo's suggestion to add more members in zpdesc,
- Rebase on latest mm-unstable commit 31334cf98dbd
---
Alex Shi (10):
mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool mm/zsmalloc: use zpdesc in trylock_zspage()/lock_zspage() mm/zsmalloc: convert create_page_chain() and its users to use zpdesc mm/zsmalloc: rename reset_page to reset_zpdesc and use zpdesc in it mm/zsmalloc: convert SetZsPageMovable and remove unused funcs mm/zsmalloc: convert get/set_first_obj_offset() to take zpdesc mm/zsmalloc: introduce __zpdesc_clear_movable mm/zsmalloc: introduce __zpdesc_clear/set_zsmalloc() mm/zsmalloc: introduce zpdesc_clear_first() helper mm/zsmalloc: update comments for page->zpdesc changes
Hyeonggon Yoo (11):
mm/zsmalloc: convert __zs_map_object/__zs_unmap_object to use zpdesc mm/zsmalloc: add and use pfn/zpdesc seeking funcs mm/zsmalloc: convert obj_malloc() to use zpdesc mm/zsmalloc: convert obj_allocated() and related helpers to use zpdesc mm/zsmalloc: convert init_zspage() to use zpdesc mm/zsmalloc: convert obj_to_page() and zs_free() to use zpdesc mm/zsmalloc: add zpdesc_is_isolated()/zpdesc_zone() helper for
zs_page_migrate()
mm/zsmalloc: convert __free_zspage() to use zdsesc mm/zsmalloc: convert location_to_obj() to take zpdesc mm/zsmalloc: convert migrate_zspage() to use zpdesc mm/zsmalloc: convert get_zspage() to take zpdesc
mm/zpdesc.h | 146 +++++++++++++++ mm/zsmalloc.c | 482 +++++++++++++++++++++++++++----------------------- 2 files changed, 403 insertions(+), 225 deletions(-) create mode 100644 mm/zpdesc.h
Signature · 1 line
2.43.0
v5 cover mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool
From: Alex Shi <[email protected]>
According to Metthew's plan, the page descriptor will be replace by a 8 bytes mem_desc on destination purpose.
https://lore.kernel.org/lkml/[email protected]/
Here is a implement on zsmalloc to replace page descriptor by 'zpdesc', which is still overlay on struct page now. but it's a step move forward above destination.
To name the struct zpdesc instead of zsdesc, since there are still 3 zpools under zswap: zbud, z3fold, zsmalloc for now(z3fold maybe removed soon), and we could easyly extend it to other zswap.zpool in needs.
For all zswap.zpools, they are all using single page since often used under memory pressure. So the conversion via folio series helper is better than page's for compound_head check saving.
For now, all zpools are using some page struct members, like page.flags for PG_private/PG_locked. and list_head lru, page.mapping for page migration.
This patachset does not increase the descriptor size nor introduce any functional changes, and could save about 122Kbytes zsmalloc.o size.
Thanks a lot for comments and suggestion from Yosry, Yoo, Sergey, Willy and Vishal!
Thanks
Alex
---v4->v5:
- rebase on akpm/mm-unstable on Aug 4.
- add a helper and update code comments accroding to Sergey's comments
- fold patch 20/21, remove 3 helpers functions according to Vishal's comments
v3->v4:
- rebase on akpm/mm-unstable Jul 21
- fixed a build warning reported by LKP
- Add a comment update for struct page to zpdesc change
v2->v3:
- Fix LKP reported build issue
- Update the Usage of struct zpdesc fields.
- Rebase onto latest mm-unstable commit 2073cda629a4
v1->v2:
- Take Yosry and Yoo's suggestion to add more members in zpdesc,
- Rebase on latest mm-unstable commit 31334cf98dbd
---
Alex Shi (10):
mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool mm/zsmalloc: use zpdesc in trylock_zspage()/lock_zspage() mm/zsmalloc: convert create_page_chain() and its users to use zpdesc mm/zsmalloc: rename reset_page to reset_zpdesc and use zpdesc in it mm/zsmalloc: convert SetZsPageMovable and remove unused funcs mm/zsmalloc: convert get/set_first_obj_offset() to take zpdesc mm/zsmalloc: introduce __zpdesc_clear_movable mm/zsmalloc: introduce __zpdesc_clear/set_zsmalloc() mm/zsmalloc: introduce zpdesc_clear_first() helper mm/zsmalloc: update comments for page->zpdesc changes
Hyeonggon Yoo (11):
mm/zsmalloc: convert __zs_map_object/__zs_unmap_object to use zpdesc mm/zsmalloc: add and use pfn/zpdesc seeking funcs mm/zsmalloc: convert obj_malloc() to use zpdesc mm/zsmalloc: convert obj_allocated() and related helpers to use zpdesc mm/zsmalloc: convert init_zspage() to use zpdesc mm/zsmalloc: convert obj_to_page() and zs_free() to use zpdesc mm/zsmalloc: add zpdesc_is_isolated()/zpdesc_zone() helper for
zs_page_migrate()
mm/zsmalloc: convert __free_zspage() to use zdsesc mm/zsmalloc: convert location_to_obj() to take zpdesc mm/zsmalloc: convert migrate_zspage() to use zpdesc mm/zsmalloc: convert get_zspage() to take zpdesc
mm/zpdesc.h | 146 +++++++++++++++ mm/zsmalloc.c | 482 +++++++++++++++++++++++++++----------------------- 2 files changed, 403 insertions(+), 225 deletions(-) create mode 100644 mm/zpdesc.h
Signature · 1 line
2.43.0
PATCH v5 1/21 mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool
From: Alex Shi <[email protected]>
The 1st patch introduces new memory decriptor zpdesc and rename zspage.first_page to zspage.first_zpdesc, no functional change.
We removed PG_owner_priv_1 since it was moved to zspage after commit a41ec880aa7b ("zsmalloc: move huge compressed obj from page to zspage").
And keep the memcg_data member, since as Yosry pointed out:
"When the pages are freed, put_page() -> folio_put() -> __folio_put() will call mem_cgroup_uncharge(). The latter will call folio_memcg() (which reads folio->memcg_data) to figure out if uncharging needs to be done.
There are also other similar code paths that will check folio->memcg_data. It is currently expected to be present for all folios. So until we have custom code paths per-folio type for allocation/freeing/etc, we need to keep folio->memcg_data present and properly initialized."
--- mm/zpdesc.h | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++ mm/zsmalloc.c | 25 +++++++++--------- 2 files changed, 83 insertions(+), 13 deletions(-) create mode 100644 mm/zpdesc.h
mm/zpdesc.h new file +71 -0
@@ -0,0 +1,71 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* zpdesc.h: zswap.zpool memory descriptor +* +* Written by Alex Shi <[email protected]> +* Hyeonggon Yoo <[email protected]> +*/ +#ifndef __MM_ZPDESC_H__ +#define __MM_ZPDESC_H__ + +/* +* struct zpdesc - Memory descriptor for zpool memory, now is for zsmalloc +* @flags: Page flags, PG_private: identifies the first component page +* @lru: Indirectly used by page migration +* @mops: Used by page migration +* @next: Next zpdesc in a zspage in zsmalloc zpool +* @handle: For huge zspage in zsmalloc zpool +* @zspage: Points to the zspage this zpdesc is a part of +* @first_obj_offset: First object offset in zsmalloc zpool +* @_refcount: Indirectly use by page migration +* @memcg_data: Memory Control Group data. +* +* This struct overlays struct page for now. Do not modify without a good +* understanding of the issues. +*/ +struct zpdesc { +unsigned long flags; +struct list_head lru; +struct movable_operations *mops; +union { +/* Next zpdescs in a zspage in zsmalloc zpool */ +struct zpdesc *next; +/* For huge zspage in zsmalloc zpool */ +unsigned long handle; + }; +struct zspage *zspage; +unsigned int first_obj_offset; +atomic_t _refcount; +#ifdef CONFIG_MEMCG +unsigned long memcg_data; +#endif +}; +#define ZPDESC_MATCH (pg, zp) \ + static_assert(offsetof(struct page, pg) == offsetof(struct zpdesc, zp)) + +ZPDESC_MATCH (flags, flags); +ZPDESC_MATCH (lru, lru); +ZPDESC_MATCH (mapping, mops); +ZPDESC_MATCH (index, next); +ZPDESC_MATCH (index, handle); +ZPDESC_MATCH (private, zspage); +ZPDESC_MATCH (page_type, first_obj_offset); +ZPDESC_MATCH (_refcount, _refcount); +#ifdef CONFIG_MEMCG +ZPDESC_MATCH (memcg_data, memcg_data); +#endif +#undef ZPDESC_MATCH +static_assert (sizeof (struct zpdesc ) <=sizeof (struct page )); + +#define zpdesc_page (zp) (_Generic((zp), \ + const struct zpdesc *: (const struct page *)(zp), \ + struct zpdesc *: (struct page *)(zp))) + +#define zpdesc_folio (zp) (_Generic((zp), \ + const struct zpdesc *: (const struct folio *)(zp), \ + struct zpdesc *: (struct folio *)(zp))) + +#define page_zpdesc (p) (_Generic((p), \ + const struct page *: (const struct zpdesc *)(p), \ + struct page *: (struct zpdesc *)(p))) + +#endif
mm/zsmalloc.c +12 -13
@@ -13,20 +13,18 @@/* * Following is how we use various fields and flags of underlying -* struct page(s) to form a zspage. +* struct zpdesc(page) to form a zspage. * -* Usage of struct page fields: -* page->private: points to zspage -* page->index: links together all component pages of a zspage +* Usage of struct zpdesc fields: +* zpdesc->zspage: points to zspage +* zpdesc->next: links together all component pages of a zspage * For the huge page, this is always 0, so we use this field * to store handle. -* page->page_type: PG_zsmalloc, lower 16 bit locate the first object -* offset in a subpage of a zspage +* zpdesc->first_obj_offset: PG_zsmalloc, lower 16 bit locate the first +* object offset in a subpage of a zspage * -* Usage of struct page flags: +* Usage of struct zpdesc(page) flags: * PG_private: identifies the first component page -* PG_owner_priv_1: identifies the huge component page -* */ #define pr_fmt (fmt) KBUILD_MODNAME ": " fmt
@@ -64,6 +62,7 @@#include <linux/pagemap.h> #include <linux/fs.h> #include <linux/local_lock.h> +#include "zpdesc.h" #define ZSPAGE_MAGIC 0x58
@@ -253,7 +252,7 @@ struct zspage { };unsigned int inuse;unsigned int freeobj; -struct page *first_page; +struct zpdesc *first_zpdesc;struct list_head list;/* fullness list */ struct zs_pool *pool;rwlock_t lock;
@@ -448,7 +447,7 @@ static inline void mod_zspage_inuse(struct zspage *zspage, int val)static inline struct page *get_first_page (struct zspage *zspage) { -struct page *first_page = zspage->first_page; +struct page *first_page =zpdesc_page (zspage->first_zpdesc);VM_BUG_ON_PAGE (!is_first_page (first_page), first_page);return first_page;
@@ -948,7 +947,7 @@ static void create_page_chain(struct size_class *class, struct zspage *zspage,set_page_private (page, (unsigned long )zspage); page->index =0 ;if (i ==0 ) { - zspage->first_page = page; + zspage->first_zpdesc =page_zpdesc (page);SetPagePrivate (page);if (unlikely (class->objs_per_zspage ==1 && class->pages_per_zspage ==1 ))
@@ -1324,7 +1323,7 @@ static unsigned long obj_malloc(struct zs_pool *pool, link->handle = handle |OBJ_ALLOCATED_TAG ; else/* record handle to page->index */ - zspage->first_page->index = handle | OBJ_ALLOCATED_TAG; + zspage->first_zpdesc->handle = handle | OBJ_ALLOCATED_TAG;kunmap_atomic (vaddr);mod_zspage_inuse (zspage,1 );
Signature · 1 line
2.43.0
PATCH v5 2/21 mm/zsmalloc: use zpdesc in trylock_zspage()/lock_zspage()
In reply to [email protected]From: Alex Shi <[email protected]>
To use zpdesc in trylock_zspage()/lock_zspage() funcs, we add couple of helpers:
zpdesc_lock()/zpdesc_unlock()/zpdesc_trylock()/zpdesc_wait_locked() and zpdesc_get()/zpdesc_put() for this purpose.
Here we use the folio series func in guts for 2 reasons, one zswap.zpool only get single page, and use folio could save some compound_head checking; two, folio_put could bypass devmap checking that we don't need.
BTW, thanks Intel LKP found a build warning on the patch.
--- mm/zpdesc.h | 30 ++++++++++++++++++++++++ mm/zsmalloc.c | 64 ++++++++++++++++++++++++++++++++++----------------- 2 files changed, 73 insertions(+), 21 deletions(-)
mm/zpdesc.h +30 -0
@@ -68,4 +68,34 @@ static_assert(sizeof(struct zpdesc) <= sizeof(struct page)); const struct page *: (const struct zpdesc *)(p), \ struct page *: (struct zpdesc *)(p))) +static inline void zpdesc_lock(struct zpdesc *zpdesc) +{ +folio_lock (zpdesc_folio (zpdesc )); +} + +static inline bool zpdesc_trylock (struct zpdesc *zpdesc) +{ +return folio_trylock (zpdesc_folio (zpdesc)); +} + +static inline void zpdesc_unlock (struct zpdesc *zpdesc) +{ +folio_unlock (zpdesc_folio (zpdesc)); +} + +static inline void zpdesc_wait_locked (struct zpdesc *zpdesc) +{ +folio_wait_locked (zpdesc_folio (zpdesc)); +} + +static inline void zpdesc_get (struct zpdesc *zpdesc) +{ +folio_get (zpdesc_folio (zpdesc)); +} + +static inline void zpdesc_put (struct zpdesc *zpdesc) +{ +folio_put (zpdesc_folio (zpdesc)); +} +#endif
mm/zsmalloc.c +43 -21
119 lines not on this page · raw message
Signature · 1 line
2.43.0
PATCH v5 3/21 mm/zsmalloc: convert __zs_map_object/__zs_unmap_object to use zpdesc
In reply to [email protected]From: Hyeonggon Yoo <[email protected]>
These two functions take pointer to an array of struct page. Introduce zpdesc_kmap_atomic() and make __zs_{map,unmap}_object() take pointer to an array of zpdesc instead of page.
Add silly type casting when calling them. Casting will be removed late.
--- mm/zsmalloc.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-)
mm/zsmalloc.c +13 -8
@@ -243,6 +243,11 @@ struct zs_pool {atomic_t compaction_in_progress; }; +static inline void *zpdesc_kmap_atomic (struct zpdesc *zpdesc) +{ +return kmap_atomic (zpdesc_page (zpdesc)); +} + struct zspage { struct { unsigned int huge:HUGE_BITS;
@@ -1061,7 +1066,7 @@ static inline void __zs_cpu_down(struct mapping_area *area) }static void *__zs_map_object (struct mapping_area *area, -struct page *pages[2 ],int off,int size) +struct zpdesc *zpdescs[2 ],int off,int size) {int sizes[2 ];void *addr;
@@ -1078,10 +1083,10 @@ static void *__zs_map_object(struct mapping_area *area, sizes[1 ] = size - sizes[0 ];/* copy object to per-cpu buffer */ - addr =kmap_atomic (pages[0 ]); + addr =zpdesc_kmap_atomic (zpdescs[0 ]);memcpy (buf, addr + off, sizes[0 ]);kunmap_atomic (addr); - addr =kmap_atomic (pages[1 ]); + addr =zpdesc_kmap_atomic (zpdescs[1 ]);memcpy (buf + sizes[0 ], addr, sizes[1 ]);kunmap_atomic (addr); out:
@@ -1089,7 +1094,7 @@ static void *__zs_map_object(struct mapping_area *area, }static void __zs_unmap_object (struct mapping_area *area, -struct page *pages[2 ],int off,int size) +struct zpdesc *zpdescs[2 ],int off,int size) {int sizes[2 ];void *addr;
@@ -1108,10 +1113,10 @@ static void __zs_unmap_object(struct mapping_area *area, sizes[1 ] = size - sizes[0 ];/* copy per-cpu buffer to object */ - addr =kmap_atomic (pages[0 ]); + addr =zpdesc_kmap_atomic (zpdescs[0 ]);memcpy (addr + off, buf, sizes[0 ]);kunmap_atomic (addr); - addr =kmap_atomic (pages[1 ]); + addr =zpdesc_kmap_atomic (zpdescs[1 ]);memcpy (addr, buf + sizes[0 ], sizes[1 ]);kunmap_atomic (addr);
@@ -1252,7 +1257,7 @@ void *zs_map_object(struct zs_pool *pool, unsigned long handle, pages[1 ] =get_next_page (page);BUG_ON (!pages[1 ]); - ret =__zs_map_object (area, pages, off, class->size); + ret =__zs_map_object (area, (struct zpdesc **)pages, off, class->size); out:if (likely (!ZsHugePage (zspage))) ret +=ZS_HANDLE_SIZE ;
@@ -1287,7 +1292,7 @@ void zs_unmap_object(struct zs_pool *pool, unsigned long handle) pages[1 ] =get_next_page (page);BUG_ON (!pages[1 ]); -__zs_unmap_object (area, pages, off, class->size); +__zs_unmap_object (area, (struct zpdesc **)pages, off, class->size); }local_unlock (&zs_map_area.lock);
Signature · 1 line
2.43.0
PATCH v5 4/21 mm/zsmalloc: add and use pfn/zpdesc seeking funcs
In reply to [email protected]From: Hyeonggon Yoo <[email protected]>
Add pfn_zpdesc conversion, convert obj_to_location() to take zpdesc and also convert its users to use zpdesc.
--- mm/zpdesc.h | 9 +++++++ mm/zsmalloc.c | 75 ++++++++++++++++++++++++++------------------------- 2 files changed, 47 insertions(+), 37 deletions(-)
mm/zpdesc.h +9 -0
@@ -98,4 +98,13 @@ static inline void zpdesc_put(struct zpdesc *zpdesc) folio_put(zpdesc_folio(zpdesc)); } +static inline unsigned long zpdesc_pfn (struct zpdesc *zpdesc) +{ +return page_to_pfn (zpdesc_page (zpdesc)); +} + +static inline struct zpdesc *pfn_zpdesc (unsigned long pfn) +{ +return page_zpdesc (pfn_to_page (pfn)); +}#endif
mm/zsmalloc.c +38 -37
189 lines not on this page · raw message
Signature · 1 line
2.43.0
PATCH v5 5/21 mm/zsmalloc: convert obj_malloc() to use zpdesc
In reply to [email protected]From: Hyeonggon Yoo <[email protected]>
Use get_first_zpdesc/get_next_zpdesc to replace get_first_page/get_next_page. no functional change.
--- mm/zsmalloc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
mm/zsmalloc.c +8 -8
@@ -1322,12 +1322,12 @@ EXPORT_SYMBOL_GPL(zs_huge_class_size);static unsigned long obj_malloc (struct zs_pool *pool,struct zspage *zspage,unsigned long handle) { -int i, nr_page, offset; +int i, nr_zpdesc, offset;unsigned long obj;struct link_free *link;struct size_class *class; -struct page *m_page; +struct zpdesc *m_zpdesc;unsigned long m_offset;void *vaddr;
@@ -1335,14 +1335,14 @@ static unsigned long obj_malloc(struct zs_pool *pool, obj =get_freeobj (zspage); offset = obj * class->size; - nr_page = offset >>PAGE_SHIFT ; + nr_zpdesc = offset >>PAGE_SHIFT ; m_offset =offset_in_page (offset); - m_page =get_first_page (zspage); + m_zpdesc =get_first_zpdesc (zspage); -for (i =0 ; i < nr_page; i++) - m_page =get_next_page (m_page); +for (i =0 ; i < nr_zpdesc; i++) + m_zpdesc =get_next_zpdesc (m_zpdesc); - vaddr =kmap_atomic (m_page); + vaddr =zpdesc_kmap_atomic (m_zpdesc); link = (struct link_free *)vaddr + m_offset /sizeof (*link);set_freeobj (zspage, link->next >>OBJ_TAG_BITS );if (likely (!ZsHugePage (zspage)))
@@ -1355,7 +1355,7 @@ static unsigned long obj_malloc(struct zs_pool *pool,kunmap_atomic (vaddr);mod_zspage_inuse (zspage,1 ); - obj =location_to_obj (m_page, obj); + obj =location_to_obj (zpdesc_page (m_zpdesc), obj);record_obj (handle, obj);return obj;
Signature · 1 line
2.43.0
PATCH v5 6/21 mm/zsmalloc: convert create_page_chain() and its users to use zpdesc
In reply to [email protected]From: Alex Shi <[email protected]>
Introduce a few helper functions for conversion to convert create_page_chain() to use zpdesc, then use zpdesc in replace_sub_page() too.
--- mm/zpdesc.h | 6 ++++ mm/zsmalloc.c | 95 ++++++++++++++++++++++++++++++--------------------- 2 files changed, 62 insertions(+), 39 deletions(-)
mm/zpdesc.h +6 -0
@@ -107,4 +107,10 @@ static inline struct zpdesc *pfn_zpdesc(unsigned long pfn) {return page_zpdesc (pfn_to_page (pfn)); } + +static inline void __zpdesc_set_movable (struct zpdesc *zpdesc, +const struct movable_operations *mops) +{ +__SetPageMovable (zpdesc_page (zpdesc), mops); +}#endif
mm/zsmalloc.c +56 -39
162 lines not on this page · raw message
Signature · 1 line
2.43.0
PATCH v5 7/21 mm/zsmalloc: convert obj_allocated() and related helpers to use zpdesc
In reply to [email protected]From: Hyeonggon Yoo <[email protected]>
Convert obj_allocated(), and related helpers to take zpdesc. Also make its callers to cast (struct page *) to (struct zpdesc *) when calling them. The users will be converted gradually as there are many.
--- mm/zsmalloc.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
mm/zsmalloc.c +10 -10
@@ -825,15 +825,15 @@ static unsigned long handle_to_obj(unsigned long handle)return *(unsigned long *)handle; } -static inline bool obj_allocated (struct page *page,void *obj, +static inline bool obj_allocated (struct zpdesc *zpdesc,void *obj,unsigned long *phandle) {unsigned long handle; -struct zspage *zspage =get_zspage (page); +struct zspage *zspage =get_zspage (zpdesc_page (zpdesc));if (unlikely (ZsHugePage (zspage))) { -VM_BUG_ON_PAGE (!is_first_page (page), page); - handle = page->index; +VM_BUG_ON_PAGE (!is_first_zpdesc (zpdesc),zpdesc_page (zpdesc)); + handle = zpdesc->handle; }else handle = *(unsigned long *)obj;
@@ -1583,18 +1583,18 @@ static void zs_object_copy(struct size_class *class, unsigned long dst,* return handle. */ static unsigned long find_alloced_obj (struct size_class *class, -struct page *page,int *obj_idx) +struct zpdesc *zpdesc,int *obj_idx) {unsigned int offset;int index = *obj_idx;unsigned long handle =0 ; -void *addr =kmap_atomic (page); +void *addr =zpdesc_kmap_atomic (zpdesc); - offset =get_first_obj_offset (page); + offset =get_first_obj_offset (zpdesc_page (zpdesc)); offset += class->size * index;while (offset <PAGE_SIZE ) { -if (obj_allocated (page, addr + offset, &handle)) +if (obj_allocated (zpdesc, addr + offset, &handle))break ; offset += class->size;
@@ -1618,7 +1618,7 @@ static void migrate_zspage(struct zs_pool *pool, struct zspage *src_zspage,struct size_class *class = pool->size_class[src_zspage->class];while (1 ) { - handle =find_alloced_obj (class, s_page, &obj_idx); + handle =find_alloced_obj (class,page_zpdesc (s_page), &obj_idx);if (!handle) { s_page =get_next_page (s_page);if (!s_page)
@@ -1851,7 +1851,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page,for (addr = s_addr + offset; addr < s_addr +PAGE_SIZE ; addr += class->size) { -if (obj_allocated (page, addr, &handle)) { +if (obj_allocated (page_zpdesc (page), addr, &handle)) { old_obj =handle_to_obj (handle);obj_to_location (old_obj, &dummy, &obj_idx);
Signature · 1 line
2.43.0
PATCH v5 8/21 mm/zsmalloc: convert init_zspage() to use zpdesc
In reply to [email protected]From: Hyeonggon Yoo <[email protected]>
Replace get_first/next_page func series and kmap_atomic to new helper, no functional change.
--- mm/zsmalloc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
mm/zsmalloc.c +8 -8
@@ -928,16 +928,16 @@ static void init_zspage(struct size_class *class, struct zspage *zspage) {unsigned int freeobj =1 ;unsigned long off =0 ; -struct page *page =get_first_page (zspage); +struct zpdesc *zpdesc =get_first_zpdesc (zspage); -while (page) { -struct page *next_page; +while (zpdesc) { +struct zpdesc *next_zpdesc;struct link_free *link;void *vaddr; -set_first_obj_offset (page, off); +set_first_obj_offset (zpdesc_page (zpdesc), off); - vaddr =kmap_atomic (page); + vaddr =zpdesc_kmap_atomic (zpdesc); link = (struct link_free *)vaddr + off /sizeof (*link);while ((off += class->size) <PAGE_SIZE ) {
@@ -950,8 +950,8 @@ static void init_zspage(struct size_class *class, struct zspage *zspage)* page, which must point to the first object on the next * page (if present) */ - next_page =get_next_page (page); -if (next_page) { + next_zpdesc =get_next_zpdesc (zpdesc); +if (next_zpdesc) { link->next = freeobj++ <<OBJ_TAG_BITS ; }else {/*
@@ -961,7 +961,7 @@ static void init_zspage(struct size_class *class, struct zspage *zspage) link->next =-1UL <<OBJ_TAG_BITS ; }kunmap_atomic (vaddr); - page = next_page; + zpdesc = next_zpdesc; off %=PAGE_SIZE ; }
Signature · 1 line
2.43.0
PATCH v5 9/21 mm/zsmalloc: convert obj_to_page() and zs_free() to use zpdesc
In reply to [email protected]From: Hyeonggon Yoo <[email protected]>
Rename obj_to_page() to obj_to_zpdesc() and also convert it and its user zs_free() to use zpdesc.
--- mm/zsmalloc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
mm/zsmalloc.c +5 -5
@@ -800,9 +800,9 @@ static void obj_to_location(unsigned long obj, struct zpdesc **zpdesc, *obj_idx = (obj &OBJ_INDEX_MASK ); } -static void obj_to_page (unsigned long obj,struct page **page) +static void obj_to_zpdesc (unsigned long obj,struct zpdesc **zpdesc) { - *page =pfn_to_page (obj >>OBJ_INDEX_BITS ); + *zpdesc =pfn_zpdesc (obj >>OBJ_INDEX_BITS ); }/**
@@ -1476,7 +1476,7 @@ static void obj_free(int class_size, unsigned long obj)void zs_free (struct zs_pool *pool,unsigned long handle) {struct zspage *zspage; -struct page *f_page; +struct zpdesc *f_zpdesc;unsigned long obj;struct size_class *class;int fullness;
@@ -1490,8 +1490,8 @@ void zs_free(struct zs_pool *pool, unsigned long handle)*/ read_lock (&pool->migrate_lock); obj =handle_to_obj (handle); -obj_to_page (obj, &f_page); - zspage =get_zspage (f_page); +obj_to_zpdesc (obj, &f_zpdesc); + zspage =get_zspage (zpdesc_page (f_zpdesc)); class =zspage_class (pool, zspage);spin_lock (&class->lock);read_unlock (&pool->migrate_lock);
Signature · 1 line
2.43.0
PATCH v5 10/21 mm/zsmalloc: add zpdesc_is_isolated()/zpdesc_zone() helper for zs_page_migrate()
In reply to [email protected]From: Hyeonggon Yoo <[email protected]>
To convert page to zpdesc in zs_page_migrate(), we added zpdesc_is_isolated()/zpdesc_zone() helpers. No functional change.
--- mm/zpdesc.h | 11 +++++++++++ mm/zsmalloc.c | 30 ++++++++++++++++-------------- 2 files changed, 27 insertions(+), 14 deletions(-)
mm/zpdesc.h +11 -0
@@ -113,4 +113,15 @@ static inline void __zpdesc_set_movable(struct zpdesc *zpdesc, {__SetPageMovable (zpdesc_page (zpdesc), mops); } + +static inline bool zpdesc_is_isolated (struct zpdesc *zpdesc) +{ +return PageIsolated (zpdesc_page (zpdesc)); +} + +static inline struct zone *zpdesc_zone (struct zpdesc *zpdesc) +{ +return page_zone (zpdesc_page (zpdesc)); +} +#endif
mm/zsmalloc.c +16 -14
@@ -1810,19 +1810,21 @@ static int zs_page_migrate(struct page *newpage, struct page *page,struct size_class *class;struct zspage *zspage;struct zpdesc *dummy; +struct zpdesc *newzpdesc =page_zpdesc (newpage); +struct zpdesc *zpdesc =page_zpdesc (page);void *s_addr, *d_addr, *addr;unsigned int offset;unsigned long handle;unsigned long old_obj, new_obj;unsigned int obj_idx; -VM_BUG_ON_PAGE (!PageIsolated (page), page); +VM_BUG_ON_PAGE (!zpdesc_is_isolated (zpdesc),zpdesc_page (zpdesc));/* We're committed, tell the world that this is a Zsmalloc page. */ -__SetPageZsmalloc (newpage); +__SetPageZsmalloc (zpdesc_page (newzpdesc));/* The page is locked, so this pointer must remain valid */ - zspage =get_zspage (page); + zspage =get_zspage (zpdesc_page (zpdesc)); pool = zspage->pool;/*
@@ -1839,30 +1841,30 @@ static int zs_page_migrate(struct page *newpage, struct page *page,/* the migrate_write_lock protects zpage access via zs_map_object */ migrate_write_lock (zspage); - offset =get_first_obj_offset (page); - s_addr =kmap_atomic (page); + offset =get_first_obj_offset (zpdesc_page (zpdesc)); + s_addr =zpdesc_kmap_atomic (zpdesc);/* * Here, any user cannot access all objects in the zspage so let's move. */ - d_addr =kmap_atomic (newpage); + d_addr =zpdesc_kmap_atomic (newzpdesc);copy_page (d_addr, s_addr);kunmap_atomic (d_addr);for (addr = s_addr + offset; addr < s_addr +PAGE_SIZE ; addr += class->size) { -if (obj_allocated (page_zpdesc (page), addr, &handle)) { +if (obj_allocated (zpdesc, addr, &handle)) { old_obj =handle_to_obj (handle);obj_to_location (old_obj, &dummy, &obj_idx); - new_obj = (unsigned long )location_to_obj (newpage, + new_obj = (unsigned long )location_to_obj (zpdesc_page (newzpdesc), obj_idx);record_obj (handle, new_obj); } }kunmap_atomic (s_addr); -replace_sub_page (class, zspage,page_zpdesc (newpage),page_zpdesc (page)); +replace_sub_page (class, zspage, newzpdesc, zpdesc);/* * Since we complete the data copy and set up new zspage structure, * it's okay to release migration_lock.
@@ -1871,14 +1873,14 @@ static int zs_page_migrate(struct page *newpage, struct page *page,spin_unlock (&class->lock);migrate_write_unlock (zspage); -get_page (newpage); -if (page_zone (newpage) !=page_zone (page)) { -dec_zone_page_state (page,NR_ZSPAGES ); -inc_zone_page_state (newpage,NR_ZSPAGES ); +zpdesc_get (newzpdesc); +if (zpdesc_zone (newzpdesc) !=zpdesc_zone (zpdesc)) { +zpdesc_dec_zone_page_state (zpdesc); +zpdesc_inc_zone_page_state (newzpdesc); }reset_page (page); -put_page (page); +zpdesc_put (zpdesc);return MIGRATEPAGE_SUCCESS ; }
Signature · 1 line
2.43.0
PATCH v5 11/21 mm/zsmalloc: rename reset_page to reset_zpdesc and use zpdesc in it
In reply to [email protected]From: Alex Shi <[email protected]>
zpdesc.zspage matches with page.private, zpdesc.next matches with page.index. They will be reset in reset_page() wich is called prior to free base pages of a zspage.
Use zpdesc to replace page struct and rename it to reset_zpdesc(), few page helper still left since they are used too widely.
--- mm/zsmalloc.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
mm/zsmalloc.c +7 -5
@@ -845,12 +845,14 @@ static inline bool obj_allocated(struct zpdesc *zpdesc, void *obj,return true; } -static void reset_page (struct page *page) +static void reset_zpdesc (struct zpdesc *zpdesc) { +struct page *page =zpdesc_page (zpdesc); +__ClearPageMovable (page);ClearPagePrivate (page); -set_page_private (page,0 ); - page->index =0 ; + zpdesc->zspage =NULL ; + zpdesc->next =NULL ;reset_first_obj_offset (page);__ClearPageZsmalloc (page); }
@@ -890,7 +892,7 @@ static void __free_zspage(struct zs_pool *pool, struct size_class *class, do { VM_BUG_ON_PAGE(!PageLocked(page), page); next = get_next_page(page); - reset_page(page); + reset_zpdesc(page_zpdesc(page)); unlock_page(page); dec_zone_page_state(page, NR_ZSPAGES); put_page(page);
@@ -1879,7 +1881,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page,zpdesc_inc_zone_page_state (newzpdesc); } -reset_page (page); +reset_zpdesc (zpdesc);zpdesc_put (zpdesc);return MIGRATEPAGE_SUCCESS ;
Signature · 1 line
2.43.0
PATCH v5 12/21 mm/zsmalloc: convert __free_zspage() to use zdsesc
In reply to [email protected]From: Hyeonggon Yoo <[email protected]>
Introduce zpdesc_is_locked() and convert __free_zspage() to use zpdesc.
--- mm/zpdesc.h | 4 ++++ mm/zsmalloc.c | 20 ++++++++++---------- 2 files changed, 14 insertions(+), 10 deletions(-)
mm/zpdesc.h +4 -0
@@ -124,4 +124,8 @@ static inline struct zone *zpdesc_zone(struct zpdesc *zpdesc) return page_zone(zpdesc_page(zpdesc)); } +static inline bool zpdesc_is_locked (struct zpdesc *zpdesc) +{ +return PageLocked (zpdesc_page (zpdesc)); +}#endif
mm/zsmalloc.c +10 -10
@@ -881,23 +881,23 @@ static int trylock_zspage(struct zspage *zspage)static void __free_zspage (struct zs_pool *pool,struct size_class *class,struct zspage *zspage) { -struct page *page, *next; +struct zpdesc *zpdesc, *next;assert_spin_locked (&class->lock);VM_BUG_ON (get_zspage_inuse (zspage));VM_BUG_ON (zspage->fullness !=ZS_INUSE_RATIO_0 ); - next = page =get_first_page (zspage); + next = zpdesc =get_first_zpdesc (zspage);do { -VM_BUG_ON_PAGE (!PageLocked (page), page); - next =get_next_page (page); -reset_zpdesc (page_zpdesc (page)); -unlock_page (page); -dec_zone_page_state (page,NR_ZSPAGES ); -put_page (page); - page = next; - }while (page !=NULL ); +VM_BUG_ON_PAGE (!zpdesc_is_locked (zpdesc),zpdesc_page (zpdesc)); + next =get_next_zpdesc (zpdesc); +reset_zpdesc (zpdesc); +zpdesc_unlock (zpdesc); +zpdesc_dec_zone_page_state (zpdesc); +zpdesc_put (zpdesc); + zpdesc = next; + }while (zpdesc !=NULL );cache_free_zspage (pool, zspage);
Signature · 1 line
2.43.0
PATCH v5 13/21 mm/zsmalloc: convert location_to_obj() to take zpdesc
In reply to [email protected]From: Hyeonggon Yoo <[email protected]>
As all users of location_to_obj() now use zpdesc, convert location_to_obj() to take zpdesc.
--- mm/zsmalloc.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
mm/zsmalloc.c +6 -7
@@ -806,15 +806,15 @@ static void obj_to_zpdesc(unsigned long obj, struct zpdesc **zpdesc) }/** -* location_to_obj - get obj value encoded from (<page>, <obj_idx>) -* @page: page object resides in zspage +* location_to_obj - get obj value encoded from (<zpdesc>, <obj_idx>) +* @zpdesc: zpdesc object resides in zspage * @obj_idx: object index */ -static unsigned long location_to_obj (struct page *page,unsigned int obj_idx) +static unsigned long location_to_obj (struct zpdesc *zpdesc,unsigned int obj_idx) {unsigned long obj; - obj =page_to_pfn (page) <<OBJ_INDEX_BITS ; + obj =zpdesc_pfn (zpdesc) <<OBJ_INDEX_BITS ; obj |= obj_idx &OBJ_INDEX_MASK ;return obj;
@@ -1372,7 +1372,7 @@ static unsigned long obj_malloc(struct zs_pool *pool,kunmap_atomic (vaddr);mod_zspage_inuse (zspage,1 ); - obj =location_to_obj (zpdesc_page (m_zpdesc), obj); + obj =location_to_obj (m_zpdesc, obj);record_obj (handle, obj);return obj;
@@ -1859,8 +1859,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page, old_obj =handle_to_obj (handle);obj_to_location (old_obj, &dummy, &obj_idx); - new_obj = (unsigned long )location_to_obj (zpdesc_page (newzpdesc), - obj_idx); + new_obj = (unsigned long )location_to_obj (newzpdesc, obj_idx);record_obj (handle, new_obj); } }
Signature · 1 line
2.43.0
PATCH v5 14/21 mm/zsmalloc: convert migrate_zspage() to use zpdesc
In reply to [email protected]From: Hyeonggon Yoo <[email protected]>
Use get_first_zpdesc/get_next_zpdesc to replace get_first/next_page. No functional change.
--- mm/zsmalloc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
mm/zsmalloc.c +4 -4
@@ -1616,14 +1616,14 @@ static void migrate_zspage(struct zs_pool *pool, struct zspage *src_zspage,unsigned long used_obj, free_obj;unsigned long handle;int obj_idx =0 ; -struct page *s_page =get_first_page (src_zspage); +struct zpdesc *s_zpdesc =get_first_zpdesc (src_zspage);struct size_class *class = pool->size_class[src_zspage->class];while (1 ) { - handle =find_alloced_obj (class,page_zpdesc (s_page), &obj_idx); + handle =find_alloced_obj (class, s_zpdesc, &obj_idx);if (!handle) { - s_page =get_next_page (s_page); -if (!s_page) + s_zpdesc =get_next_zpdesc (s_zpdesc); +if (!s_zpdesc)break ; obj_idx =0 ;continue ;
Signature · 1 line
2.43.0
PATCH v5 15/21 mm/zsmalloc: convert get_zspage() to take zpdesc
In reply to [email protected]From: Hyeonggon Yoo <[email protected]>
Now that all users except get_next_page() (which will be removed in later patch) use zpdesc, convert get_zspage() to take zpdesc instead of page.
--- mm/zsmalloc.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
mm/zsmalloc.c +10 -10
@@ -759,9 +759,9 @@ static int fix_fullness_group(struct size_class *class, struct zspage *zspage)return newfg; } -static struct zspage *get_zspage (struct page *page) +static struct zspage *get_zspage (struct zpdesc *zpdesc) { -struct zspage *zspage = (struct zspage *)page_private (page); +struct zspage *zspage = zpdesc->zspage;BUG_ON (zspage->magic !=ZSPAGE_MAGIC );return zspage;
@@ -769,7 +769,7 @@ static struct zspage *get_zspage(struct page *page)static struct page *get_next_page (struct page *page) { -struct zspage *zspage =get_zspage (page); +struct zspage *zspage =get_zspage (page_zpdesc (page));if (unlikely (ZsHugePage (zspage)))return NULL ;
@@ -779,7 +779,7 @@ static struct page *get_next_page(struct page *page)static struct zpdesc *get_next_zpdesc (struct zpdesc *zpdesc) { -struct zspage *zspage =get_zspage (zpdesc_page (zpdesc)); +struct zspage *zspage =get_zspage (zpdesc);if (unlikely (ZsHugePage (zspage)))return NULL ;
@@ -829,7 +829,7 @@ static inline bool obj_allocated(struct zpdesc *zpdesc, void *obj, unsigned long *phandle) {unsigned long handle; -struct zspage *zspage =get_zspage (zpdesc_page (zpdesc)); +struct zspage *zspage =get_zspage (zpdesc);if (unlikely (ZsHugePage (zspage))) {VM_BUG_ON_PAGE (!is_first_zpdesc (zpdesc),zpdesc_page (zpdesc));
@@ -1245,7 +1245,7 @@ void *zs_map_object(struct zs_pool *pool, unsigned long handle,read_lock (&pool->migrate_lock); obj =handle_to_obj (handle);obj_to_location (obj, &zpdesc, &obj_idx); - zspage =get_zspage (zpdesc_page (zpdesc)); + zspage =get_zspage (zpdesc);/* * migration cannot move any zpages in this zspage. Here, class->lock
@@ -1295,7 +1295,7 @@ void zs_unmap_object(struct zs_pool *pool, unsigned long handle) obj =handle_to_obj (handle);obj_to_location (obj, &zpdesc, &obj_idx); - zspage =get_zspage (zpdesc_page (zpdesc)); + zspage =get_zspage (zpdesc); class =zspage_class (pool, zspage); off =offset_in_page (class->size * obj_idx);
@@ -1459,7 +1459,7 @@ static void obj_free(int class_size, unsigned long obj)obj_to_location (obj, &f_zpdesc, &f_objidx); f_offset =offset_in_page (class_size * f_objidx); - zspage =get_zspage (zpdesc_page (f_zpdesc)); + zspage =get_zspage (f_zpdesc); vaddr =zpdesc_kmap_atomic (f_zpdesc); link = (struct link_free *)(vaddr + f_offset);
@@ -1493,7 +1493,7 @@ void zs_free(struct zs_pool *pool, unsigned long handle)read_lock (&pool->migrate_lock); obj =handle_to_obj (handle);obj_to_zpdesc (obj, &f_zpdesc); - zspage =get_zspage (zpdesc_page (f_zpdesc)); + zspage =get_zspage (f_zpdesc); class =zspage_class (pool, zspage);spin_lock (&class->lock);read_unlock (&pool->migrate_lock);
@@ -1826,7 +1826,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page,__SetPageZsmalloc (zpdesc_page (newzpdesc));/* The page is locked, so this pointer must remain valid */ - zspage =get_zspage (zpdesc_page (zpdesc)); + zspage =get_zspage (zpdesc); pool = zspage->pool;/*
Signature · 1 line
2.43.0
PATCH v5 16/21 mm/zsmalloc: convert SetZsPageMovable and remove unused funcs
In reply to [email protected]From: Alex Shi <[email protected]>
Convert SetZsPageMovable() to use zpdesc, and then remove unused
funcs: get_next_page()/get_first_page()/is_first_page().
--- mm/zsmalloc.c | 33 +++++---------------------------- 1 file changed, 5 insertions(+), 28 deletions(-)
mm/zsmalloc.c +5 -28
@@ -448,11 +448,6 @@ static DEFINE_PER_CPU(struct mapping_area, zs_map_area) = { .lock = INIT_LOCAL_LOCK(lock), }; -static __maybe_unused int is_first_page (struct page *page) -{ -return PagePrivate (page); -} -static inline bool is_first_zpdesc (struct zpdesc *zpdesc) {return PagePrivate (zpdesc_page (zpdesc));
@@ -469,14 +464,6 @@ static inline void mod_zspage_inuse(struct zspage *zspage, int val) zspage->inuse += val; } -static inline struct page *get_first_page (struct zspage *zspage) -{ -struct page *first_page =zpdesc_page (zspage->first_zpdesc); - -VM_BUG_ON_PAGE (!is_first_page (first_page), first_page); -return first_page; -} -static struct zpdesc *get_first_zpdesc (struct zspage *zspage) {struct zpdesc *first_zpdesc = zspage->first_zpdesc;
@@ -767,16 +754,6 @@ static struct zspage *get_zspage(struct zpdesc *zpdesc)return zspage; } -static struct page *get_next_page (struct page *page) -{ -struct zspage *zspage =get_zspage (page_zpdesc (page)); - -if (unlikely (ZsHugePage (zspage))) -return NULL ; - -return (struct page *)page->index; -} -static struct zpdesc *get_next_zpdesc (struct zpdesc *zpdesc) {struct zspage *zspage =get_zspage (zpdesc);
@@ -1950,13 +1927,13 @@ static void init_deferred_free(struct zs_pool *pool)static void SetZsPageMovable (struct zs_pool *pool,struct zspage *zspage) { -struct page *page =get_first_page (zspage); +struct zpdesc *zpdesc =get_first_zpdesc (zspage);do { -WARN_ON (!trylock_page (page)); -__SetPageMovable (page, &zsmalloc_mops); -unlock_page (page); - }while ((page =get_next_page (page)) !=NULL ); +WARN_ON (!zpdesc_trylock (zpdesc)); +__zpdesc_set_movable (zpdesc, &zsmalloc_mops); +zpdesc_unlock (zpdesc); + }while ((zpdesc =get_next_zpdesc (zpdesc)) !=NULL ); }#else static inline void zs_flush_migration (struct zs_pool *pool) { }
Signature · 1 line
2.43.0
PATCH v5 17/21 mm/zsmalloc: convert get/set_first_obj_offset() to take zpdesc
In reply to [email protected]From: Alex Shi <[email protected]>
Now that all users of get/set_first_obj_offset() are converted to use zpdesc, convert them to take zpdesc.
--- mm/zsmalloc.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-)
mm/zsmalloc.c +16 -16
@@ -474,26 +474,26 @@ static struct zpdesc *get_first_zpdesc(struct zspage *zspage)#define FIRST_OBJ_PAGE_TYPE_MASK 0xffff -static inline void reset_first_obj_offset (struct page *page) +static inline void reset_first_obj_offset (struct zpdesc *zpdesc) { -VM_WARN_ON_ONCE (!PageZsmalloc (page)); - page->page_type |=FIRST_OBJ_PAGE_TYPE_MASK ; +VM_WARN_ON_ONCE (!PageZsmalloc (zpdesc_page (zpdesc))); + zpdesc->first_obj_offset |=FIRST_OBJ_PAGE_TYPE_MASK ; } -static inline unsigned int get_first_obj_offset (struct page *page) +static inline unsigned int get_first_obj_offset (struct zpdesc *zpdesc) { -VM_WARN_ON_ONCE (!PageZsmalloc (page)); -return page->page_type &FIRST_OBJ_PAGE_TYPE_MASK ; +VM_WARN_ON_ONCE (!PageZsmalloc (zpdesc_page (zpdesc))); +return zpdesc->first_obj_offset &FIRST_OBJ_PAGE_TYPE_MASK ; } -static inline void set_first_obj_offset (struct page *page,unsigned int offset) +static inline void set_first_obj_offset (struct zpdesc *zpdesc,unsigned int offset) {/* With 16 bit available, we can support offsets into 64 KiB pages. */ BUILD_BUG_ON (PAGE_SIZE >SZ_64K ); -VM_WARN_ON_ONCE (!PageZsmalloc (page)); +VM_WARN_ON_ONCE (!PageZsmalloc (zpdesc_page (zpdesc)));VM_WARN_ON_ONCE (offset & ~FIRST_OBJ_PAGE_TYPE_MASK ); - page->page_type &= ~FIRST_OBJ_PAGE_TYPE_MASK ; - page->page_type |= offset &FIRST_OBJ_PAGE_TYPE_MASK ; + zpdesc->first_obj_offset &= ~FIRST_OBJ_PAGE_TYPE_MASK ; + zpdesc->first_obj_offset |= offset &FIRST_OBJ_PAGE_TYPE_MASK ; }static inline unsigned int get_freeobj (struct zspage *zspage)
@@ -830,7 +830,7 @@ static void reset_zpdesc(struct zpdesc *zpdesc)ClearPagePrivate (page); zpdesc->zspage =NULL ; zpdesc->next =NULL ; -reset_first_obj_offset (page); +reset_first_obj_offset (zpdesc);__ClearPageZsmalloc (page); }
@@ -914,7 +914,7 @@ static void init_zspage(struct size_class *class, struct zspage *zspage)struct link_free *link;void *vaddr; -set_first_obj_offset (zpdesc_page (zpdesc), off); +set_first_obj_offset (zpdesc, off); vaddr =zpdesc_kmap_atomic (zpdesc); link = (struct link_free *)vaddr + off /sizeof (*link);
@@ -1569,7 +1569,7 @@ static unsigned long find_alloced_obj(struct size_class *class,unsigned long handle =0 ;void *addr =zpdesc_kmap_atomic (zpdesc); - offset =get_first_obj_offset (zpdesc_page (zpdesc)); + offset =get_first_obj_offset (zpdesc); offset += class->size * index;while (offset <PAGE_SIZE ) {
@@ -1764,8 +1764,8 @@ static void replace_sub_page(struct size_class *class, struct zspage *zspage, }while ((zpdesc =get_next_zpdesc (zpdesc)) !=NULL );create_page_chain (class, zspage, zpdescs); - first_obj_offset =get_first_obj_offset (zpdesc_page (oldzpdesc)); -set_first_obj_offset (zpdesc_page (newzpdesc), first_obj_offset); + first_obj_offset =get_first_obj_offset (oldzpdesc); +set_first_obj_offset (newzpdesc, first_obj_offset);if (unlikely (ZsHugePage (zspage))) newzpdesc->handle = oldzpdesc->handle;__zpdesc_set_movable (newzpdesc, &zsmalloc_mops);
@@ -1820,7 +1820,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page,/* the migrate_write_lock protects zpage access via zs_map_object */ migrate_write_lock (zspage); - offset =get_first_obj_offset (zpdesc_page (zpdesc)); + offset =get_first_obj_offset (zpdesc); s_addr =zpdesc_kmap_atomic (zpdesc);/*
Signature · 1 line
2.43.0
PATCH v5 18/21 mm/zsmalloc: introduce __zpdesc_clear_movable
In reply to [email protected]From: Alex Shi <[email protected]>
Add a helper __zpdesc_clear_movable() for __ClearPageMovable(), and use it in callers to make code clear.
--- mm/zpdesc.h | 5 +++++ mm/zsmalloc.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)
mm/zpdesc.h +5 -0
@@ -114,6 +114,11 @@ static inline void __zpdesc_set_movable(struct zpdesc *zpdesc,__SetPageMovable (zpdesc_page (zpdesc), mops); } +static inline void __zpdesc_clear_movable (struct zpdesc *zpdesc) +{ +__ClearPageMovable (zpdesc_page (zpdesc)); +} +static inline bool zpdesc_is_isolated (struct zpdesc *zpdesc) {return PageIsolated (zpdesc_page (zpdesc));
mm/zsmalloc.c +1 -1
@@ -826,7 +826,7 @@ static void reset_zpdesc(struct zpdesc *zpdesc) {struct page *page =zpdesc_page (zpdesc); -__ClearPageMovable (page); +__zpdesc_clear_movable (zpdesc);ClearPagePrivate (page); zpdesc->zspage =NULL ; zpdesc->next =NULL ;
Signature · 1 line
2.43.0
PATCH v5 19/21 mm/zsmalloc: introduce __zpdesc_clear/set_zsmalloc()
In reply to [email protected]From: Alex Shi <[email protected]>
Add helper __zpdesc_clear_zsmalloc() for __ClearPageZsmalloc(), __zpdesc_set_zsmalloc() for __SetPageZsmalloc(), and use them in callers.
--- mm/zpdesc.h | 10 ++++++++++ mm/zsmalloc.c | 8 ++++---- 2 files changed, 14 insertions(+), 4 deletions(-)
mm/zpdesc.h +10 -0
@@ -119,6 +119,16 @@ static inline void __zpdesc_clear_movable(struct zpdesc *zpdesc)__ClearPageMovable (zpdesc_page (zpdesc)); } +static inline void __zpdesc_set_zsmalloc (struct zpdesc *zpdesc) +{ +__SetPageZsmalloc (zpdesc_page (zpdesc)); +} + +static inline void __zpdesc_clear_zsmalloc (struct zpdesc *zpdesc) +{ +__ClearPageZsmalloc (zpdesc_page (zpdesc)); +} +static inline bool zpdesc_is_isolated (struct zpdesc *zpdesc) {return PageIsolated (zpdesc_page (zpdesc));
mm/zsmalloc.c +4 -4
@@ -831,7 +831,7 @@ static void reset_zpdesc(struct zpdesc *zpdesc) zpdesc->zspage =NULL ; zpdesc->next =NULL ;reset_first_obj_offset (zpdesc); -__ClearPageZsmalloc (page); +__zpdesc_clear_zsmalloc (zpdesc); }static int trylock_zspage (struct zspage *zspage)
@@ -1004,13 +1004,13 @@ static struct zspage *alloc_zspage(struct zs_pool *pool,if (!zpdesc) {while (--i >=0 ) {zpdesc_dec_zone_page_state (zpdescs[i]); -__ClearPageZsmalloc (zpdesc_page (zpdescs[i])); +__zpdesc_clear_zsmalloc (zpdescs[i]);__free_page (zpdesc_page (zpdescs[i])); }cache_free_zspage (pool, zspage);return NULL ; } -__SetPageZsmalloc (zpdesc_page (zpdesc)); +__zpdesc_set_zsmalloc (zpdesc);zpdesc_inc_zone_page_state (zpdesc); zpdescs[i] = zpdesc;
@@ -1800,7 +1800,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page,VM_BUG_ON_PAGE (!zpdesc_is_isolated (zpdesc),zpdesc_page (zpdesc));/* We're committed, tell the world that this is a Zsmalloc page. */ -__SetPageZsmalloc (zpdesc_page (newzpdesc)); +__zpdesc_set_zsmalloc (newzpdesc);/* The page is locked, so this pointer must remain valid */ zspage =get_zspage (zpdesc);
Signature · 1 line
2.43.0
PATCH v5 20/21 mm/zsmalloc: introduce zpdesc_clear_first() helper
In reply to [email protected]From: Alex Shi <[email protected]>
Like the zpdesc_set_first(), introduce zpdesc_clear_first() helper for ClearPagePrivate(), then clean up a 'struct page' usage in reset_zpdesc().
--- mm/zsmalloc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
mm/zsmalloc.c +6 -3
@@ -253,6 +253,11 @@ static inline void zpdesc_set_first(struct zpdesc *zpdesc)SetPagePrivate (zpdesc_page (zpdesc)); } +static inline void zpdesc_clear_first (struct zpdesc *zpdesc) +{ +ClearPagePrivate (zpdesc_page (zpdesc)); +} +static inline void zpdesc_inc_zone_page_state (struct zpdesc *zpdesc) {inc_zone_page_state (zpdesc_page (zpdesc),NR_ZSPAGES );
@@ -824,10 +829,8 @@ static inline bool obj_allocated(struct zpdesc *zpdesc, void *obj,static void reset_zpdesc (struct zpdesc *zpdesc) { -struct page *page =zpdesc_page (zpdesc); -__zpdesc_clear_movable (zpdesc); -ClearPagePrivate (page); +zpdesc_clear_first (zpdesc); zpdesc->zspage =NULL ; zpdesc->next =NULL ;reset_first_obj_offset (zpdesc);
Signature · 1 line
2.43.0
PATCH v5 21/21 mm/zsmalloc: update comments for page->zpdesc changes
In reply to [email protected]From: Alex Shi <[email protected]>
After the page to zpdesc conversion, there still left few comments or function named with page not zpdesc, let's update the comments and rename function create_page_chain() as create_zpdesc_chain().
--- mm/zsmalloc.c | 47 ++++++++++++++++++++++++++--------------------- 1 file changed, 26 insertions(+), 21 deletions(-)
mm/zsmalloc.c +26 -21
@@ -17,14 +17,16 @@* * Usage of struct zpdesc fields: * zpdesc->zspage: points to zspage -* zpdesc->next: links together all component pages of a zspage +* zpdesc->next: links together all component zpdescs of a zspage * For the huge page, this is always 0, so we use this field * to store handle. * zpdesc->first_obj_offset: PG_zsmalloc, lower 16 bit locate the first * object offset in a subpage of a zspage * * Usage of struct zpdesc(page) flags: -* PG_private: identifies the first component page +* PG_private: identifies the first component zpdesc +* PG_lock: lock all component zpdescs for a zspage free, serialize with +* migration */ #define pr_fmt (fmt) KBUILD_MODNAME ": " fmt
@@ -191,7 +193,10 @@ struct size_class {*/ int size;int objs_per_zspage; -/* Number of PAGE_SIZE sized pages to combine to form a 'zspage' */ +/* +* Number of PAGE_SIZE sized zpdescs/pages to combine to +* form a 'zspage' +*/ int pages_per_zspage;unsigned int index;
@@ -893,7 +898,7 @@ static void free_zspage(struct zs_pool *pool, struct size_class *class,/* * Since zs_free couldn't be sleepable, this function cannot call -* lock_page. The page locks trylock_zspage got will be released +* lock_page. The zpdesc locks trylock_zspage got will be released * by __free_zspage. */ if (!trylock_zspage (zspage)) {
@@ -950,7 +955,7 @@ static void init_zspage(struct size_class *class, struct zspage *zspage)set_freeobj (zspage,0 ); } -static void create_page_chain (struct size_class *class,struct zspage *zspage, +static void create_zpdesc_chain (struct size_class *class,struct zspage *zspage,struct zpdesc *zpdescs[]) {int i;
@@ -959,9 +964,9 @@ static void create_page_chain(struct size_class *class, struct zspage *zspage,int nr_zpdescs = class->pages_per_zspage;/* -* Allocate individual pages and link them together as: -* 1. all pages are linked together using zpdesc->next -* 2. each sub-page point to zspage using zpdesc->zspage +* Allocate individual zpdescs and link them together as: +* 1. all zpdescs are linked together using zpdesc->next +* 2. each sub-zpdesc point to zspage using zpdesc->zspage * * we set PG_private to identify the first zpdesc (i.e. no other zpdesc * has this flag set).
@@ -1019,7 +1024,7 @@ static struct zspage *alloc_zspage(struct zs_pool *pool, zpdescs[i] = zpdesc; } -create_page_chain (class, zspage, zpdescs); +create_zpdesc_chain (class, zspage, zpdescs);init_zspage (class, zspage); zspage->pool = pool; zspage->class = class->index;
@@ -1346,7 +1351,7 @@ static unsigned long obj_malloc(struct zs_pool *pool,/* record handle in the header of allocated chunk */ link->handle = handle |OBJ_ALLOCATED_TAG ; else -/* record handle to page->index */ +/* record handle to zpdesc->handle */ zspage->first_zpdesc->handle = handle | OBJ_ALLOCATED_TAG;kunmap_atomic (vaddr);
@@ -1679,19 +1684,19 @@ static int putback_zspage(struct size_class *class, struct zspage *zspage)#ifdef CONFIG_COMPACTION /* * To prevent zspage destroy during migration, zspage freeing should -* hold locks of all pages in the zspage. +* hold locks of all component zpdesc in the zspage. */ static void lock_zspage (struct zspage *zspage) {struct zpdesc *curr_zpdesc, *zpdesc;/* -* Pages we haven't locked yet can be migrated off the list while we're +* Zpdesc we haven't locked yet can be migrated off the list while we're * trying to lock them, so we need to be careful and only attempt to -* lock each page under migrate_read_lock(). Otherwise, the page we lock -* may no longer belong to the zspage. This means that we may wait for -* the wrong page to unlock, so we must take a reference to the page -* prior to waiting for it to unlock outside migrate_read_lock(). +* lock each zpdesc under migrate_read_lock(). Otherwise, the zpdesc we +* lock may no longer belong to the zspage. This means that we may wait +* for the wrong zpdesc to unlock, so we must take a reference to the +* zpdesc prior to waiting for it to unlock outside migrate_read_lock(). */ while (1 ) {migrate_read_lock (zspage);
@@ -1766,7 +1771,7 @@ static void replace_sub_page(struct size_class *class, struct zspage *zspage, idx++; }while ((zpdesc =get_next_zpdesc (zpdesc)) !=NULL ); -create_page_chain (class, zspage, zpdescs); +create_zpdesc_chain (class, zspage, zpdescs); first_obj_offset =get_first_obj_offset (oldzpdesc);set_first_obj_offset (newzpdesc, first_obj_offset);if (unlikely (ZsHugePage (zspage)))
@@ -1777,8 +1782,8 @@ static void replace_sub_page(struct size_class *class, struct zspage *zspage,static bool zs_page_isolate (struct page *page,isolate_mode_t mode) {/* -* Page is locked so zspage couldn't be destroyed. For detail, look at -* lock_zspage in free_zspage. +* Page/zpdesc is locked so zspage couldn't be destroyed. For detail, +* look at lock_zspage in free_zspage. */ VM_BUG_ON_PAGE (PageIsolated (page), page);
@@ -1805,7 +1810,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page,/* We're committed, tell the world that this is a Zsmalloc page. */ __zpdesc_set_zsmalloc (newzpdesc); -/* The page is locked, so this pointer must remain valid */ +/* The zpdesc/page is locked, so this pointer must remain valid */ zspage =get_zspage (zpdesc); pool = zspage->pool;
@@ -1878,7 +1883,7 @@ static const struct movable_operations zsmalloc_mops = { };/* -* Caller should hold page_lock of all pages in the zspage +* Caller should hold zpdesc locks of all in the zspage * In here, we cannot use zspage meta data. */ static void async_free_zspage (struct work_struct *work)
Signature · 1 line
2.43.0
Andrew Morton
maintainerQuoted 7 lines · On Tue, 6 Aug 2024 10:22:47 +0800 [email protected] wrote:
According to Metthew's plan, the page descriptor will be replace by a 8 bytes
mem_descon destination purpose.
https://lore.kernel.org/lkml/[email protected]/Here is a implement on zsmalloc to replace page descriptor by 'zpdesc', which is still overlay on struct page now. but it's a step move forward above destination.
So the sole reason for this work is as a part of the mem_desc conversion. I'd like to hear from others who are to be involved in that conversion, please - it this patchset something we should be merging?
Quoted 7 lines · Andrew Morton
Quoted 4 lines · On Tue, 6 Aug 2024 10:22:47 +0800 [email protected] wrote:
According to Metthew's plan, the page descriptor will be replace by a 8 bytes
mem_descon destination purpose.
https://lore.kernel.org/lkml/[email protected]/
Quoted 9 lines
Quoted 3 lines
Here is a implement on zsmalloc to replace page descriptor by 'zpdesc', which is still overlay on struct page now. but it's a step move forward above destination.
So the sole reason for this work is as a part of the
mem_descconversion. I'd like to hear from others who are to be involved in that conversion, please - it this patchset something we should be merging?
Matthew asked an important question here that needs to be answered by zsmalloc experts:
https://lore.kernel.org/lkml/[email protected]/
Quoted 3 lines · Yosry Ahmed
Matthew asked an important question here that needs to be answered by zsmalloc experts:
https://lore.kernel.org/lkml/[email protected]/
Yes, and I said it needed to be answered before we had a v5. So I'm very disappointed that not 24 hours later we're seeing a v5.
Quoted 7 lines · Matthew Wilcox
Quoted 3 lines · Yosry Ahmed
Matthew asked an important question here that needs to be answered by zsmalloc experts:
https://lore.kernel.org/lkml/[email protected]/Yes, and I said it needed to be answered before we had a v5. So I'm very disappointed that not 24 hours later we're seeing a v5.
Hi Willy,
Sorry, I don't know the reply time meaning a lot here. I tried to reply you:
https://lore.kernel.org/lkml/[email protected]/
And hope for more discussion on v5.
Sorry, I will hold my horse, and slow down for version updates.
Thanks a lot!
Alex
Quoted 8 lines · Alex Shi
Quoted 5 lines · Matthew Wilcox
Quoted 3 lines · Yosry Ahmed
Matthew asked an important question here that needs to be answered by zsmalloc experts:
https://lore.kernel.org/lkml/[email protected]/
Quoted 6 lines
Quoted 2 lines
Yes, and I said it needed to be answered before we had a v5. So I'm very disappointed that not 24 hours later we're seeing a v5.
Hi Willy,
Sorry, I don't know the reply time meaning a lot here.
How could I have been more clear?
Quoted 3 lines
I tried to reply you:
https://lore.kernel.org/lkml/[email protected]/
And hope for more discussion on v5.
Quoted 2 lines · You
I believe you has much more idea of the ways to memdesc.
Is there some references or detailed info which I could learn from you?
I've pointed you at everything I've written. If you ask a specific question about something that's not clear, I can answer that question. This vague "please teach me" isn't going to lead anywhere fruitful.
Sergey Senozhatsky
maintainerOn (24/08/06 12:34), Yosry Ahmed wrote:
[..]
Quoted 9 lines
Quoted 5 lines
So the sole reason for this work is as a part of the
mem_descconversion. I'd like to hear from others who are to be involved in that conversion, please - it this patchset something we should be merging?Matthew asked an important question here that needs to be answered by zsmalloc experts:
https://lore.kernel.org/lkml/[email protected]/
Iff "zsmalloc experts" include me: I was under impression that there was a zsmalloc conversion plan otherwise this zpdesc effort is a little confusing, and, frankly, it hasn't appeared to me that this is "my problem" now.
Quoted 2 lines
Do you allocate a per-page struct zpdesc, and have each one pointing to a zspage?
I'm not very knowledgeable when it comes to memdesc, excuse my ignorance, and please feel free to educate me.
So I guess if we have something
struct zspage {
..
struct zpdesc *first_desc;
..
}and we "chain" zpdesc-s to form a zspage, and make each of them point to a corresponding struct page (memdesc -> *page), then it'll resemble current zsmalloc and should work for everyone? I also assume for zspdesc-s zsmalloc will need to maintain a dedicated kmem_cache?
Quoted 31 lines · Sergey Senozhatsky
On (24/08/06 12:34), Yosry Ahmed wrote:
[..]Quoted 9 lines
Quoted 5 lines
So the sole reason for this work is as a part of the
mem_descconversion. I'd like to hear from others who are to be involved in that conversion, please - it this patchset something we should be merging?Matthew asked an important question here that needs to be answered by zsmalloc experts:
https://lore.kernel.org/lkml/[email protected]/Iff "zsmalloc experts" include me: I was under impression that there was a zsmalloc conversion plan otherwise this zpdesc effort is a little confusing, and, frankly, it hasn't appeared to me that this is "my problem" now.
Quoted 2 lines
Do you allocate a per-page struct zpdesc, and have each one pointing to a zspage?
I'm not very knowledgeable when it comes to memdesc, excuse my ignorance, and please feel free to educate me.
So I guess if we have something
struct zspage { .. struct zpdesc *first_desc; .. }
Quoted 4 lines
and we "chain" zpdesc-s to form a zspage, and make each of them point to a corresponding struct page (memdesc -> *page), then it'll resemble current zsmalloc and should work for everyone? I also assume for zspdesc-s zsmalloc will need to maintain a dedicated
kmem_cache?
Yes, it would be a better way moving to memdesc, and using kmem_cache for zpdesc-s seems workable.
Thanks
Alex
Quoted 8 lines · Sergey Senozhatsky
On (24/08/06 12:34), Yosry Ahmed wrote:
[..]Quoted 6 lines
Quoted 5 lines
So the sole reason for this work is as a part of the
mem_descconversion. I'd like to hear from others who are to be involved in that conversion, please - it this patchset something we should be merging?
Quoted 8 lines
Quoted 3 lines
Matthew asked an important question here that needs to be answered by zsmalloc experts:
https://lore.kernel.org/lkml/[email protected]/Iff "zsmalloc experts" include me: I was under impression that there was a zsmalloc conversion plan otherwise this zpdesc effort is a little confusing, and, frankly, it hasn't appeared to me that this is "my problem" now.
I don't know if it's _your_ problem. It's _our_ problem. The arguments for (at least attempting) to shrink struct page seem quite compelling. We have a plan for most of the users of struct page, in greater or lesser detail. I don't think we have a plan for zsmalloc. Or at least if there is a plan, I don't know what it is.
Quoted 5 lines
Quoted 2 lines
Do you allocate a per-page struct zpdesc, and have each one pointing to a zspage?
I'm not very knowledgeable when it comes to memdesc, excuse my ignorance, and please feel free to educate me.
I've written about it here:
https://kernelnewbies.org/MatthewWilcox/Memdescs
https://kernelnewbies.org/MatthewWilcox/FolioAlloc
https://kernelnewbies.org/MatthewWilcox/Memdescs/Path
Quoted 8 lines
So I guess if we have something
struct zspage { .. struct zpdesc *first_desc; .. }
Quoted 4 lines
and we "chain" zpdesc-s to form a zspage, and make each of them point to a corresponding struct page (memdesc -> *page), then it'll resemble current zsmalloc and should work for everyone? I also assume for zspdesc-s zsmalloc will need to maintain a dedicated
kmem_cache?
Right, we could do that. Each memdesc has to be a multiple of 16 bytes, sp we'd be doing something like allocating 32 bytes for each page. Is there really 32 bytes of information that we want to store for each page? Or could we store all of the information in (a somewhat larger) zspage? Assuming we allocate 3 pages per zspage, if we allocate an extra 64 bytes in the zspage, we've saved 32 bytes per zspage.
Quoted 4 lines · Matthew Wilcox
I've written about it here:
https://kernelnewbies.org/MatthewWilcox/Memdescs
https://kernelnewbies.org/MatthewWilcox/FolioAlloc
https://kernelnewbies.org/MatthewWilcox/Memdescs/Path
Thanks for sharing!
Quoted 13 lines
Quoted 9 lines
So I guess if we have something
struct zspage { .. struct zpdesc *first_desc; .. }Quoted 4 lines
and we "chain" zpdesc-s to form a zspage, and make each of them point to a corresponding struct page (memdesc -> *page), then it'll resemble current zsmalloc and should work for everyone? I also assume for zspdesc-s zsmalloc will need to maintain a dedicated
kmem_cache?
Quoted 6 lines
Right, we could do that. Each memdesc has to be a multiple of 16 bytes, sp we'd be doing something like allocating 32 bytes for each page. Is there really 32 bytes of information that we want to store for each page? Or could we store all of the information in (a somewhat larger) zspage? Assuming we allocate 3 pages per zspage, if we allocate an extra 64 bytes in the zspage, we've saved 32 bytes per zspage.
Thanks for the suggestions! Yes, it's a good direction we could try after this patchset.
Thanks for you all!
Sergey Senozhatsky
maintainerOn (24/08/09 10:32), Alex Shi wrote:
[..]
Quoted 11 lines
Quoted 10 lines
Quoted 4 lines
and we "chain" zpdesc-s to form a zspage, and make each of them point to a corresponding struct page (memdesc -> *page), then it'll resemble current zsmalloc and should work for everyone? I also assume for zspdesc-s zsmalloc will need to maintain a dedicated
kmem_cache?Right, we could do that. Each memdesc has to be a multiple of 16 bytes, sp we'd be doing something like allocating 32 bytes for each page. Is there really 32 bytes of information that we want to store for each page? Or could we store all of the information in (a somewhat larger) zspage? Assuming we allocate 3 pages per zspage, if we allocate an extra 64 bytes in the zspage, we've saved 32 bytes per zspage.
Quoted 2 lines
Thanks for the suggestions! Yes, it's a good direction we could try after this patchset.
Alex, may I ask what exactly you will "try"?
Quoted 13 lines · Sergey Senozhatsky
On (24/08/09 10:32), Alex Shi wrote:
[..]Quoted 11 lines
Quoted 10 lines
Quoted 4 lines
and we "chain" zpdesc-s to form a zspage, and make each of them point to a corresponding struct page (memdesc -> *page), then it'll resemble current zsmalloc and should work for everyone? I also assume for zspdesc-s zsmalloc will need to maintain a dedicated
kmem_cache?Right, we could do that. Each memdesc has to be a multiple of 16 bytes, sp we'd be doing something like allocating 32 bytes for each page. Is there really 32 bytes of information that we want to store for each page? Or could we store all of the information in (a somewhat larger) zspage? Assuming we allocate 3 pages per zspage, if we allocate an extra 64 bytes in the zspage, we've saved 32 bytes per zspage.
Quoted 4 lines
Quoted 2 lines
Thanks for the suggestions! Yes, it's a good direction we could try after this patchset.
Alex, may I ask what exactly you will "try"?
Hi Sergey,
Thanks for question. As a quick amateur thought, the final result may like following, please correct me if I am wrong.
1, there is a memdesc for each of memory page.
2, we kmem_alloc some zpdesc struct for specifically our needs, like zpdesc.next
zpdesc.zspage/first_obj_offset, these current we used in zsmalloc.
3, there is a gap between memdesc and zpdesc, like .flags, _refcount, .mops etc.
this part is still unclear that how to handle them well.
During the 2nd, 3rd steps, we may have chance to move some members from zpdesc, to zspage? but it's also unclear.
Thanks
Alex
Sergey Senozhatsky
maintainerOn (24/08/08 04:37), Matthew Wilcox wrote:
[..]
Quoted 6 lines
I don't know if it's _your_ problem. It's _our_ problem. The arguments for (at least attempting) to shrink struct page seem quite compelling. We have a plan for most of the users of struct page, in greater or lesser detail. I don't think we have a plan for zsmalloc. Or at least if there is a plan, I don't know what it is.
Got you, thanks. And sorry for a very delayed reply.
Quoted 10 lines
Quoted 5 lines
Quoted 2 lines
Do you allocate a per-page struct zpdesc, and have each one pointing to a zspage?
I'm not very knowledgeable when it comes to memdesc, excuse my ignorance, and please feel free to educate me.
I've written about it here:
https://kernelnewbies.org/MatthewWilcox/Memdescs
https://kernelnewbies.org/MatthewWilcox/FolioAlloc
https://kernelnewbies.org/MatthewWilcox/Memdescs/Path
Thanks a lot!
Quoted 13 lines
Quoted 8 lines
So I guess if we have something
struct zspage { .. struct zpdesc *first_desc; .. }Quoted 4 lines
and we "chain" zpdesc-s to form a zspage, and make each of them point to a corresponding struct page (memdesc -> *page), then it'll resemble current zsmalloc and should work for everyone? I also assume for zspdesc-s zsmalloc will need to maintain a dedicated
kmem_cache?
Quoted 6 lines
Right, we could do that. Each memdesc has to be a multiple of 16 bytes, sp we'd be doing something like allocating 32 bytes for each page. Is there really 32 bytes of information that we want to store for each page? Or could we store all of the information in (a somewhat larger) zspage? Assuming we allocate 3 pages per zspage, if we allocate an extra 64 bytes in the zspage, we've saved 32 bytes per zspage.
I certainly like (and appreciate) the approach that saves us some bytes here and there. zsmalloc page can consist of 1 to up to CONFIG_ZSMALLOC_CHAIN_SIZE (max 16) physical pages. I'm trying to understand (in pseudo-C code) what does a "somewhat larger zspage" mean. A fixed size array (given that we know the max number of physical pages) per-zspage?
Quoted 22 lines · Sergey Senozhatsky
On (24/08/08 04:37), Matthew Wilcox wrote:
[..]Quoted 13 lines
Quoted 8 lines
So I guess if we have something
struct zspage { .. struct zpdesc *first_desc; .. }Quoted 4 lines
and we "chain" zpdesc-s to form a zspage, and make each of them point to a corresponding struct page (memdesc -> *page), then it'll resemble current zsmalloc and should work for everyone? I also assume for zspdesc-s zsmalloc will need to maintain a dedicated
kmem_cache?Quoted 6 lines
Right, we could do that. Each memdesc has to be a multiple of 16 bytes, sp we'd be doing something like allocating 32 bytes for each page. Is there really 32 bytes of information that we want to store for each page? Or could we store all of the information in (a somewhat larger) zspage? Assuming we allocate 3 pages per zspage, if we allocate an extra 64 bytes in the zspage, we've saved 32 bytes per zspage.
Quoted 6 lines
I certainly like (and appreciate) the approach that saves us some bytes here and there. zsmalloc page can consist of 1 to up to
CONFIG_ZSMALLOC_CHAIN_SIZE(max 16) physical pages. I'm trying to understand (in pseudo-C code) what does a "somewhat larger zspage" mean. A fixed size array (given that we know the max number of physical pages) per-zspage?
I haven't had the opportunity to respond until now as I was on vacation.
With the current approach in a memdesc world, we would do the following:
1) kmem_cache_alloc() every single Zpdesc
2) Allocate a memdesc/page that points to its own Zpdesc
3) Access/Track Zpdescs directly
4) Use those Zpdescs to build a Zspage
An alternative approach would move more metadata storage from a Zpdesc into a Zspage instead. That extreme would leave us with:
1) kmem_cache_alloc() once for a Zspage
2) Allocate a memdesc/page that points to the Zspage
3) Use the Zspage to access/track its own subpages (through some magic we would have to figure out)
4) Zpdescs are just Zspages (since all the information would be in a Zspage)
IMO, we should introduce zpdescs first, then start to shift metadata from "struct zpdesc" into "struct zspage" until we no longer need "struct zpdesc". My big concern is whether or not this patchset works towards those goals. Will it make consolidating the metadata easier? And are these goals feasible (while maintaining the wins of zsmalloc)? Or should we aim to leave zsmalloc as it is currently implemented?
Quoted 48 lines · Vishal Moola
Quoted 22 lines · Sergey Senozhatsky
On (24/08/08 04:37), Matthew Wilcox wrote:
[..]Quoted 13 lines
Quoted 8 lines
So I guess if we have something
struct zspage { .. struct zpdesc *first_desc; .. }Quoted 4 lines
and we "chain" zpdesc-s to form a zspage, and make each of them point to a corresponding struct page (memdesc -> *page), then it'll resemble current zsmalloc and should work for everyone? I also assume for zspdesc-s zsmalloc will need to maintain a dedicated
kmem_cache?Quoted 6 lines
Right, we could do that. Each memdesc has to be a multiple of 16 bytes, sp we'd be doing something like allocating 32 bytes for each page. Is there really 32 bytes of information that we want to store for each page? Or could we store all of the information in (a somewhat larger) zspage? Assuming we allocate 3 pages per zspage, if we allocate an extra 64 bytes in the zspage, we've saved 32 bytes per zspage.
Quoted 6 lines
I certainly like (and appreciate) the approach that saves us some bytes here and there. zsmalloc page can consist of 1 to up to
CONFIG_ZSMALLOC_CHAIN_SIZE(max 16) physical pages. I'm trying to understand (in pseudo-C code) what does a "somewhat larger zspage" mean. A fixed size array (given that we know the max number of physical pages) per-zspage?I haven't had the opportunity to respond until now as I was on vacation.
With the current approach in a memdesc world, we would do the following:
1)
kmem_cache_alloc()every single Zpdesc
2) Allocate a memdesc/page that points to its own Zpdesc
3) Access/Track Zpdescs directly
4) Use those Zpdescs to build a ZspageAn alternative approach would move more metadata storage from a Zpdesc into a Zspage instead. That extreme would leave us with:
1)
kmem_cache_alloc()once for a Zspage
2) Allocate a memdesc/page that points to the Zspage
3) Use the Zspage to access/track its own subpages (through some magic we would have to figure out)
4) Zpdescs are just Zspages (since all the information would be in a Zspage)
Quoted 6 lines
IMO, we should introduce zpdescs first, then start to shift metadata from "struct zpdesc" into "struct zspage" until we no longer need "struct zpdesc". My big concern is whether or not this patchset works towards those goals. Will it make consolidating the metadata easier? And are these goals feasible (while maintaining the wins of zsmalloc)? Or should we aim to leave zsmalloc as it is currently implemented?
Uh, correct me if I am wrong.
IMHO, regarding what this patchset does, it abstracts the memory descriptor usage for zswap/zram. The descriptor still overlays the struct page; nothing has changed in that regard. What this patchset accomplishes is the use of folios in the guts to save some code size, and the introduction of a new concept, zpdesc. This patchset is just an initial step; it does not bias the potential changes to kmem_alloc or larger zspage modifications. In fact, both approaches require this fundamental abstract concept: zpdesc.
So I believe this patchset is needed.
Thanks
Alex
Quoted 58 lines · Alex Shi
Quoted 48 lines · Vishal Moola
Quoted 22 lines · Sergey Senozhatsky
On (24/08/08 04:37), Matthew Wilcox wrote:
[..]Quoted 13 lines
Quoted 8 lines
So I guess if we have something
struct zspage { .. struct zpdesc *first_desc; .. }Quoted 4 lines
and we "chain" zpdesc-s to form a zspage, and make each of them point to a corresponding struct page (memdesc -> *page), then it'll resemble current zsmalloc and should work for everyone? I also assume for zspdesc-s zsmalloc will need to maintain a dedicated
kmem_cache?Quoted 6 lines
Right, we could do that. Each memdesc has to be a multiple of 16 bytes, sp we'd be doing something like allocating 32 bytes for each page. Is there really 32 bytes of information that we want to store for each page? Or could we store all of the information in (a somewhat larger) zspage? Assuming we allocate 3 pages per zspage, if we allocate an extra 64 bytes in the zspage, we've saved 32 bytes per zspage.
Quoted 6 lines
I certainly like (and appreciate) the approach that saves us some bytes here and there. zsmalloc page can consist of 1 to up to
CONFIG_ZSMALLOC_CHAIN_SIZE(max 16) physical pages. I'm trying to understand (in pseudo-C code) what does a "somewhat larger zspage" mean. A fixed size array (given that we know the max number of physical pages) per-zspage?I haven't had the opportunity to respond until now as I was on vacation.
With the current approach in a memdesc world, we would do the following:
1)
kmem_cache_alloc()every single Zpdesc
2) Allocate a memdesc/page that points to its own Zpdesc
3) Access/Track Zpdescs directly
4) Use those Zpdescs to build a ZspageAn alternative approach would move more metadata storage from a Zpdesc into a Zspage instead. That extreme would leave us with:
1)
kmem_cache_alloc()once for a Zspage
2) Allocate a memdesc/page that points to the Zspage
3) Use the Zspage to access/track its own subpages (through some magic we would have to figure out)
4) Zpdescs are just Zspages (since all the information would be in a Zspage)Quoted 6 lines
IMO, we should introduce zpdescs first, then start to shift metadata from "struct zpdesc" into "struct zspage" until we no longer need "struct zpdesc". My big concern is whether or not this patchset works towards those goals. Will it make consolidating the metadata easier? And are these goals feasible (while maintaining the wins of zsmalloc)? Or should we aim to leave zsmalloc as it is currently implemented?
Quoted 4 lines
Uh, correct me if I am wrong.
IMHO, regarding what this patchset does, it abstracts the memory descriptor usage for zswap/zram.
Sorry, I misunderstood the patchset. I thought it was creating a descriptor specifically for zsmalloc, when it seems like this is supposed to be a generic descriptor for all zpool allocators. The code comments and commit subjects are misleading and should be changed to reflect that.
I'm onboard for using zpdesc for zbud and z3fold as well (or we'd have to come up with some other plan for them as well). Once we have a plan all the maintainers agree on we can all be on our merry way :)
The questions for all the zpool allocator maintainers are:
1) Does your allocator need the space its using in struct page (aka would it need a descriptor in a memdesc world)?
2) Is it feasible to store the information elsewhere (outside of struct page)? And how much effort would that code conversion be?
Thoughts? Seth/Dan, Vitaly/Miahoe, and Sergey?
Quoted 6 lines
The descriptor still overlays the struct page; nothing has changed in that regard. What this patchset accomplishes is the use of folios in the guts to save some code size, and the introduction of a new concept, zpdesc. This patchset is just an initial step; it does not bias the potential changes to
kmem_allocor larger zspage modifications. In fact, both approaches require this fundamental abstract concept: zpdesc.
Quoted 74 lines · Vishal Moola
Quoted 58 lines · Alex Shi
Quoted 48 lines · Vishal Moola
Quoted 22 lines · Sergey Senozhatsky
On (24/08/08 04:37), Matthew Wilcox wrote:
[..]Quoted 13 lines
Quoted 8 lines
So I guess if we have something
struct zspage {
..
struct zpdesc*first_desc;
..
}Quoted 4 lines
and we "chain" zpdesc-s to form a zspage, and make each of them point to a corresponding struct page (memdesc -> *page), then it'll resemble current zsmalloc and should work for everyone? I also assume for zspdesc-s zsmalloc will need to maintain a dedicated
kmem_cache?Quoted 6 lines
Right, we could do that. Each memdesc has to be a multiple of 16 bytes, sp we'd be doing something like allocating 32 bytes for each page. Is there really 32 bytes of information that we want to store for each page? Or could we store all of the information in (a somewhat larger) zspage? Assuming we allocate 3 pages per zspage, if we allocate an extra 64 bytes in the zspage, we've saved 32 bytes per zspage.
Quoted 6 lines
I certainly like (and appreciate) the approach that saves us some bytes here and there. zsmalloc page can consist of 1 to up to
CONFIG_ZSMALLOC_CHAIN_SIZE(max 16) physical pages. I'm trying to understand (in pseudo-C code) what does a "somewhat larger zspage" mean. A fixed size array (given that we know the max number of physical pages) per-zspage?I haven't had the opportunity to respond until now as I was on vacation.
With the current approach in a memdesc world, we would do the following:
1)
kmem_cache_alloc()every single Zpdesc
2) Allocate a memdesc/page that points to its own Zpdesc
3) Access/Track Zpdescs directly
4) Use those Zpdescs to build a ZspageAn alternative approach would move more metadata storage from a Zpdesc into a Zspage instead. That extreme would leave us with:
1)
kmem_cache_alloc()once for a Zspage
2) Allocate a memdesc/page that points to the Zspage
3) Use the Zspage to access/track its own subpages (through some magic we would have to figure out)
4) Zpdescs are just Zspages (since all the information would be in a Zspage)Quoted 6 lines
IMO, we should introduce zpdescs first, then start to shift metadata from "struct zpdesc" into "struct zspage" until we no longer need "struct zpdesc". My big concern is whether or not this patchset works towards those goals. Will it make consolidating the metadata easier? And are these goals feasible (while maintaining the wins of zsmalloc)? Or should we aim to leave zsmalloc as it is currently implemented?
Quoted 4 lines
Uh, correct me if I am wrong.
IMHO, regarding what this patchset does, it abstracts the memory descriptor usage for zswap/zram.
Sorry, I misunderstood the patchset. I thought it was creating a descriptor specifically for zsmalloc, when it seems like this is supposed to be a generic descriptor for all zpool allocators. The code comments and commit subjects are misleading and should be changed to reflect that.
I'm onboard for using zpdesc for zbud and z3fold as well (or we'd have to come up with some other plan for them as well). Once we have a plan all the maintainers agree on we can all be on our merry way :)
Quoted 8 lines
The questions for all the zpool allocator maintainers are:
1) Does your allocator need the space its using in struct page (aka would it need a descriptor in a memdesc world)?2) Is it feasible to store the information elsewhere (outside of struct page)? And how much effort would that code conversion be?
Thoughts? Seth/Dan, Vitaly/Miahoe, and Sergey?
I would advise against spending effort on z3fold and zbud tbh, we want to deprecate them.
Sergey Senozhatsky
maintainerQuoted 3 lines · Vishal Moola
Or should we aim to leave zsmalloc as it is currently implemented?
Is this really an option?
Quoted 7 lines · Sergey Senozhatsky
Quoted 3 lines · Vishal Moola
Or should we aim to leave zsmalloc as it is currently implemented?
Is this really an option?
Yup. That would be similar to your initial suggestion: zpdescs would be a wrapper around struct page and we "chain zpdesc-s together to form a zspage".
Although, we may as well aim for an improved implementation of zsmalloc (if at all possible) since implementing the zpdesc wrapper requires us to modify a good chunk of code anyways. That way zsmalloc gets direct wins for its users on top of shrinking struct page as Matthew described before.
I believe you would be a better judge of whether or not any improvements are feasible (and worth the effort).