Skip to contentSkip to conversation

Fix recently introduced build failures

PATCH In review Bart Van Assche 2 participants 5 messages Aug 5, 2024 – Aug 6, 2024

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover Fix recently introduced build failures

Hi Martin,

During the merge window a patch was merged that changed the type of an argument of bus_type.match. That patch converts most but not all SCSI code. Hence this patch series that converts the remaining SCSI drivers. Please consider this patch series for the v6.11 kernel.

Thanks,

Bart.

Bart Van Assche (2):
ARM: riscpc: ecard: Fix the build
mips: sgi-ip22: Fix the build

 arch/arm/mach-rpc/ecard.c     | 2 +-
 arch/mips/sgi-ip22/ip22-gio.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
#1 lore raw

PATCH 1/2 ARM: riscpc: ecard: Fix the build

Fix a recently introduced build failure.

Cc Greg Kroah-Hartman <[email protected]>
Cc Russell King <[email protected]>
Fixes d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")
---
 arch/arm/mach-rpc/ecard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-rpc/ecard.c +1 -1
index c30df1097c52..9f7454b8efa7 100644
@@ -1109,7 +1109,7 @@ void ecard_remove_driver(struct ecard_driver *drv)
 	driver_unregister(&drv->drv);
 }
 
-static int ecard_match(struct device *_dev, struct device_driver *_drv)
+static int ecard_match(struct device *_dev, const struct device_driver *_drv)
 {
 	struct expansion_card *ec = ECARD_DEV(_dev);
 	struct ecard_driver *drv = ECARD_DRV(_drv);
#2 lore raw

PATCH 2/2 mips: sgi-ip22: Fix the build

In reply to Bart Van Assche

Fix a recently introduced build failure.

Cc Greg Kroah-Hartman <[email protected]>
Fixes d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")
---
 arch/mips/sgi-ip22/ip22-gio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/sgi-ip22/ip22-gio.c +1 -1
index 2738325e98dd..d20eec742bfa 100644
@@ -111,7 +111,7 @@ void gio_device_unregister(struct gio_device *giodev)
 }
 EXPORT_SYMBOL_GPL(gio_device_unregister);
 
-static int gio_bus_match(struct device *dev, struct device_driver *drv)
+static int gio_bus_match(struct device *dev, const struct device_driver *drv)
 {
 	struct gio_device *gio_dev = to_gio_device(dev);
 	struct gio_driver *gio_drv = to_gio_driver(drv);
#3 lore raw

Re: [PATCH 2/2] mips: sgi-ip22: Fix the build

Quoted 9 lines · Bart Van Assche

Fix a recently introduced build failure.

Cc Greg Kroah-Hartman <[email protected]>
Fixes d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")
---
 arch/mips/sgi-ip22/ip22-gio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for this, and the other, fix, I'll queue them up to my local trees soon. Odd that these two targets do not seem to get any testing in that I never was able to see them in the 0-day or other testing bots out there. How did you find them?

thanks,

greg k-h

#4 lore raw

Re: [PATCH 2/2] mips: sgi-ip22: Fix the build

Quoted 11 lines · Greg Kroah-Hartman
Quoted 9 lines · Bart Van Assche

Fix a recently introduced build failure.

Cc Greg Kroah-Hartman <[email protected]>
Fixes d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")
---
  arch/mips/sgi-ip22/ip22-gio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 4 lines

Thanks for this, and the other, fix, I'll queue them up to my local trees soon. Odd that these two targets do not seem to get any testing in that I never was able to see them in the 0-day or other testing bots out there. How did you find them?

Some time ago, while making changes in the SCSI core, I noticed that it is very hard to build all SCSI drivers manually. That is why I wrote a shell script to cross-compile all SCSI drivers. That script is available
here: https://github.com/bvanassche/build-scsi-drivers/blob/main/build-scsi-drivers

Thanks,

Bart.