Skip to contentSkip to conversation

arm64: dts: qcom: x1e80100-yoga: Update panel bindings

PATCH Applied Rob Clark 3 participants 3 messages Aug 6, 2024 – Aug 15, 2024

Subsystems (3)
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH v4 1/1 arm64: dts: qcom: x1e80100-yoga: Update panel bindings

From: Rob Clark <[email protected]>

Use the correct panel compatible, and wire up enable-gpio. It is wired up in the same way as the x1e80100-crd.

---
Corresponding schema update is in drm-misc-fixes

[1/2] dt-bindings: display: panel: samsung,atna45dc02: Document ATNA45DC02

      commit: 1c4a057d01f4432704c4dc8842b6e888a91d95df
 .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts    | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +15 -2
index 70977e9fa266..3c13331a9ef4 100644
@@ -190,7 +190,6 @@ vreg_edp_3p3: regulator-edp-3p3 {
 		pinctrl-0 = <&edp_reg_en>;
 		pinctrl-names = "default";
 
-		regulator-always-on;
 		regulator-boot-on;
 	};
 
@@ -592,9 +591,13 @@ &mdss_dp3 {
 
 	aux-bus {
 		panel {
-			compatible = "edp-panel";
+			compatible = "samsung,atna45dc02", "samsung,atna33xc20";
+			enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
 			power-supply = <&vreg_edp_3p3>;
 
+			pinctrl-0 = <&edp_bl_en>;
+			pinctrl-names = "default";
+
 			port {
 				edp_panel_in: endpoint {
 					remote-endpoint = <&mdss_dp3_out>;
@@ -669,6 +672,16 @@ &pcie6a_phy {
 	status = "okay";
 };
 
+&pmc8380_3_gpios {
+	edp_bl_en: edp-bl-en-state {
+		pins = "gpio4";
+		function = "normal";
+		power-source = <0>;
+		input-disable;
+		output-enable;
+	};
+};
+
 &qupv3_0 {
 	status = "okay";
 };
Signature · 1 line
2.45.2
Reviewed-by on v4 1/1
#1 lore raw
Quoted 7 lines · Rob Clark

From: Rob Clark <[email protected]>

Use the correct panel compatible, and wire up enable-gpio. It is wired up in the same way as the x1e80100-crd.

Thanks for the update!

Quoted 56 lines

---
Corresponding schema update is in drm-misc-fixes

[1/2] dt-bindings: display: panel: samsung,atna45dc02: Document ATNA45DC02

      commit: 1c4a057d01f4432704c4dc8842b6e888a91d95df
 .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts    | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +15 -2
index 70977e9fa266..3c13331a9ef4 100644
@@ -190,7 +190,6 @@ vreg_edp_3p3: regulator-edp-3p3 {
 		pinctrl-0 = <&edp_reg_en>;
 		pinctrl-names = "default";
 
-		regulator-always-on;
 		regulator-boot-on;
 	};
 
@@ -592,9 +591,13 @@ &mdss_dp3 {
 
 	aux-bus {
 		panel {
-			compatible = "edp-panel";
+			compatible = "samsung,atna45dc02", "samsung,atna33xc20";
+			enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
 			power-supply = <&vreg_edp_3p3>;
 
+			pinctrl-0 = <&edp_bl_en>;
+			pinctrl-names = "default";
+
 			port {
 				edp_panel_in: endpoint {
 					remote-endpoint = <&mdss_dp3_out>;
@@ -669,6 +672,16 @@ &pcie6a_phy {
 	status = "okay";
 };
 
+&pmc8380_3_gpios {
+	edp_bl_en: edp-bl-en-state {
+		pins = "gpio4";
+		function = "normal";
+		power-source = <0>;
+		input-disable;
+		output-enable;
+	};
+};
+
 &qupv3_0 {
 	status = "okay";
 };
Signature · 1 line
2.45.2
maintainer Applied
#2 lore raw
In reply to Rob Clark
Quoted 4 lines · Rob Clark

Use the correct panel compatible, and wire up enable-gpio. It is wired up in the same way as the x1e80100-crd.

Applied, thanks!

[1/1] arm64: dts: qcom: x1e80100-yoga: Update panel bindings

      commit: c46eef29907bc1644e0ded4b99bbd0be5ccde9a7

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>