Skip to contentSkip to conversation

b4: message-id from deps added to cc list?

DISCUSSION Kevin Hilman 3 participants 5 messages Aug 5, 2024 – Sep 6, 2024

lore
Share & tools
lore
#0 lore raw

Hello,

I've been happily using b4 for awhile to collect and apply patches locally, but finally starting using it to manage & send patches.

First, thank you for all the work on b4. It's a major improvment to my workflow!

I'm using b4 from the stable-0.14.y branch, and I noticed one pecuilar thing on the series I just sent[1], and that is the message-id I put in the deps (using b4 prep --edit-deps) correctly showed up as prerequisite-message-id, but for some reason, it also ended up in the Cc list, leading to bounces for all mails in the thread.

I double-checked managed cover letter (using b4 prep --edit-cover) and it is definitely *not* listed as a Cc.

Looking back, I do see it in the Cc list when I b4 send --dry-run but I didn't notice it before sending. :(

How is that getting into the cc list? Is it grabbing this part of the cover letter:

Quoted 2 lines

This series depends on the support for the new TI SCI APIs here:
https://lore.kernel.org/r/[email protected]

and assuming that's an email address and automatically adding it to the cc list?

Thanks,

Kevin

[1] https://lore.kernel.org/linux-pm/20240805-lpm-v6-10-constraints-pmdomain-v1-0-d186b68ded4c@baylibre.com

#1 lore raw
Quoted 5 lines · Kevin Hilman

I'm using b4 from the stable-0.14.y branch, and I noticed one pecuilar thing on the series I just sent[1], and that is the message-id I put in the deps (using b4 prep --edit-deps) correctly showed up as prerequisite-message-id, but for some reason, it also ended up in the Cc list, leading to bounces for all mails in the thread.

bugbot assign to me

#3 lore raw
In reply to Kevin Hilman
Quoted 20 lines · Kevin Hilman

Hello,

I've been happily using b4 for awhile to collect and apply patches locally, but finally starting using it to manage & send patches.

First, thank you for all the work on b4. It's a major improvment to my workflow!

I'm using b4 from the stable-0.14.y branch, and I noticed one pecuilar thing on the series I just sent[1], and that is the message-id I put in the deps (using b4 prep --edit-deps) correctly showed up as prerequisite-message-id, but for some reason, it also ended up in the Cc list, leading to bounces for all mails in the thread.

I double-checked managed cover letter (using b4 prep --edit-cover) and it is definitely *not* listed as a Cc.

Looking back, I do see it in the Cc list when I b4 send --dry-run but I didn't notice it before sending. :(

Quoted 8 lines

How is that getting into the cc list? Is it grabbing this part of the cover letter:

Quoted 2 lines

This series depends on the support for the new TI SCI APIs here:
https://lore.kernel.org/r/[email protected]

and assuming that's an email address and automatically adding it to the cc list?

Nope, it's not getting it from the cover letter.

For it to disappear, I had to remove the message-id from the dependencies (via b4 prep --edit-deps). After that, it no longer ends up in the cc list.

So it's some how taking this from the deps and converting it into an email for the cc list.

Kevin

Reviewed-by Manos Pitsidianakis Tested-by Manos Pitsidianakis
#4 lore raw
In reply to Kevin Hilman

Louis Chauvet writes in commit 77eaedc7de548fdaa289c51f62278633bd815d01:

Remove message-id from cc list

As the algorithm to detect mails to add in CC is very simple, it also include the prerequisite-message-id to CC as they look like mails. In order to avoid this kind of issue, filter out prerequisite-message-id lines.

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=77eaedc7de54)

Signature · 2 lines
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)