Skip to contentSkip to conversation

serial: 8250_platform: Fix unused acpi_platform_serial_table warning

PATCH New Sunil V L 1 participant 1 message Aug 7, 2024 TTY layer and serial drivers

lore
Share & tools
lore

Sunil V L

author
#0 lore raw

PATCH 1/1 serial: 8250_platform: Fix unused acpi_platform_serial_table warning

The LKP reports below warning.

Quoted 1 line
Quoted 1 line

drivers/tty/serial/8250/8250_platform.c:271:36: warning: 'acpi_platform_serial_table' defined but not used [-Wunused-const-variable=]

     271 | static const struct acpi_device_id acpi_platform_serial_table[] = {
         |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~

This is because some architectures don't define either ACPI or MODULE/MODULE_DEVICE_TABLE. So, keep acpi_platform_serial_table under CONFIG_ACPI to fix the warning on such architectures.

Fixes d9e5a0ce2f16 ("serial: 8250_platform: Enable generic 16550A platform devices")
---
 drivers/tty/serial/8250/8250_platform.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/tty/serial/8250/8250_platform.c +2 -0
index bdfb16bed4f2..168e635002aa 100644
@@ -268,11 +268,13 @@ static int serial8250_resume(struct platform_device *dev)
 	return 0;
 }
 
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id acpi_platform_serial_table[] = {
 	{ "RSCV0003", 0 }, // RISC-V Generic 16550A UART
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, acpi_platform_serial_table);
+#endif
 
 static struct platform_driver serial8250_isa_driver = {
 	.probe		= serial8250_probe,
Signature · 1 line
2.43.0