spi: mxs: Switch to RUNTIME/SYSTEM_SLEEP_PM_OPS()
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 spi: mxs: Switch to RUNTIME/SYSTEM_SLEEP_PM_OPS()
From: Fabio Estevam <[email protected]>
Replace SET_RUNTIME_PM_OPS()/SET SYSTEM_SLEEP_PM_OPS() with their modern RUNTIME_PM_OPS() and SYSTEM_SLEEP_PM_OPS() alternatives.
The combined usage of pm_ptr() and RUNTIME_PM_OPS/SYSTEM_SLEEP_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code.
This allows removing the __maybe_unused notation from the runtime suspend/resume() functions.
Signed-off-by Fabio Estevam <[email protected]>
--- drivers/spi/spi-mxs.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/spi/spi-mxs.c +5 -6
@@ -477,7 +477,7 @@ static int mxs_spi_runtime_resume(struct device *dev)return ret; } -static int __maybe_unused mxs_spi_suspend (struct device *dev) +static int mxs_spi_suspend (struct device *dev) {struct spi_controller *host =dev_get_drvdata (dev);int ret;
@@ -492,7 +492,7 @@ static int __maybe_unused mxs_spi_suspend(struct device *dev)return 0 ; } -static int __maybe_unused mxs_spi_resume (struct device *dev) +static int mxs_spi_resume (struct device *dev) {struct spi_controller *host =dev_get_drvdata (dev);int ret;
@@ -512,9 +512,8 @@ static int __maybe_unused mxs_spi_resume(struct device *dev) }static const struct dev_pm_ops mxs_spi_pm = { - SET_RUNTIME_PM_OPS(mxs_spi_runtime_suspend, - mxs_spi_runtime_resume, NULL) -SET_SYSTEM_SLEEP_PM_OPS (mxs_spi_suspend, mxs_spi_resume) + RUNTIME_PM_OPS(mxs_spi_runtime_suspend, mxs_spi_runtime_resume, NULL) +SYSTEM_SLEEP_PM_OPS (mxs_spi_suspend, mxs_spi_resume) };static const struct of_device_id mxs_spi_dt_ids[] = {
@@ -662,7 +661,7 @@ static struct platform_driver mxs_spi_driver = { .driver = { .name = DRIVER_NAME, .of_match_table = mxs_spi_dt_ids, - .pm = &mxs_spi_pm, + .pm = pm_ptr(&mxs_spi_pm), }, };
Signature · 1 line
2.34.1