Skip to contentSkip to conversation

dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema

PATCH Applied Rob Herring (Arm) 3 participants 3 messages Aug 7, 2024 – Aug 8, 2024

Subsystems (3)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema

The "fsl,weim-cs-timing" property is an array, but the constraints in the if/then schema are for a matrix. That worked fine when all properties were decoded into a matrix, but now dtschema decodes properties into scalars and arrays based on their type.

---
 .../memory-controllers/fsl/fsl,imx-weim.yaml  | 25 ++++++++-----------
 1 file changed, 11 insertions(+), 14 deletions(-)
Documentation/devicetree/bindings/memory-controllers/fsl/fsl,imx-weim.yaml +11 -14
index 3f40ca5b13f6..ce4ec94a561c 100644
@@ -134,9 +134,8 @@ allOf:
           properties:
             fsl,weim-cs-timing:
               items:
-                items:
-                  - description: CSxU
-                  - description: CSxL
+                - description: CSxU
+                - description: CSxL
   - if:
       properties:
         compatible:
@@ -151,10 +150,9 @@ allOf:
           properties:
             fsl,weim-cs-timing:
               items:
-                items:
-                  - description: CSCRxU
-                  - description: CSCRxL
-                  - description: CSCRxA
+                - description: CSCRxU
+                - description: CSCRxL
+                - description: CSCRxA
   - if:
       properties:
         compatible:
@@ -171,13 +169,12 @@ allOf:
           properties:
             fsl,weim-cs-timing:
               items:
-                items:
-                  - description: CSxGCR1
-                  - description: CSxGCR2
-                  - description: CSxRCR1
-                  - description: CSxRCR2
-                  - description: CSxWCR1
-                  - description: CSxWCR2
+                - description: CSxGCR1
+                - description: CSxGCR2
+                - description: CSxRCR1
+                - description: CSxRCR2
+                - description: CSxWCR1
+                - description: CSxWCR2
 
 additionalProperties: false
 
Signature · 1 line
2.43.0
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines

Subject: [PATCH] dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema

The "fsl,weim-cs-timing" property is an array, but the constraints in the if/then schema are for a matrix. That worked fine when all properties were decoded into a matrix, but now dtschema decodes properties into scalars and arrays based on their type.

#2 lore raw
In reply to Rob Herring (Arm)
Quoted 6 lines · Rob Herring (Arm)

The "fsl,weim-cs-timing" property is an array, but the constraints in the if/then schema are for a matrix. That worked fine when all properties were decoded into a matrix, but now dtschema decodes properties into scalars and arrays based on their type.

Applied, thanks!

[1/1] dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema

      https://git.kernel.org/krzk/linux-mem-ctrl/c/e3e4e77140b4a240865309cc543141a593be4a21

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>