Skip to contentSkip to conversation

net: pse-pd: tps23881: include missing bitfield.h header

PATCH Applied Arnd Bergmann 4 participants 4 messages Aug 7, 2024 – Aug 8, 2024

Subsystems (3)
Networking Network drivers PSE network driver
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 net: pse-pd: tps23881: include missing bitfield.h header

From: Arnd Bergmann <[email protected]>

Using FIELD_GET() fails in configurations that don't already include the header file indirectly:

drivers/net/pse-pd/tps23881.c: In function 'tps23881_i2c_probe':
drivers/net/pse-pd/tps23881.c:755:13: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]

  755 |         if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
      |             ^~~~~~~~~
Fixes 89108cb5c285 ("net: pse-pd: tps23881: Fix the device ID check")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/net/pse-pd/tps23881.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/pse-pd/tps23881.c +1 -0
index f90db758554b..2ea75686a319 100644
@@ -5,6 +5,7 @@
  * Copyright (c) 2023 Bootlin, Kory Maincent <[email protected]>
  */
 
+#include <linux/bitfield.h>
 #include <linux/delay.h>
 #include <linux/firmware.h>
 #include <linux/i2c.h>
Signature · 1 line
2.39.2
maintainer
#1 lore raw

Hi Arnd,

Thank you for your patch.

I acked already other one:
https://lore.kernel.org/all/[email protected]/

Quoted 5 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Using FIELD_GET() fails in configurations that don't already include the header file indirectly:

Quoted 7 lines

drivers/net/pse-pd/tps23881.c: In function 'tps23881_i2c_probe':
drivers/net/pse-pd/tps23881.c:755:13: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]

  755 |         if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
      |             ^~~~~~~~~
Fixes 89108cb5c285 ("net: pse-pd: tps23881: Fix the device ID check")
Signed-off-by Arnd Bergmann <[email protected]>

Regards,
Oleksij

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
maintainer
#2 lore raw
Quoted 2 lines · On Wed, 7 Aug 2024 11:13:48 +0200 Oleksij Rempel wrote:

I acked already other one:
https://lore.kernel.org/all/[email protected]/

Thanks for the note, I totally missed the other patch scanning for just fixes before the downstream PR.

I prefer Arnd's fix TBH, apart from not having the wrong tree in the subject - the fixes tag is correctly formatted and includes are kept alphabetical.

I'll "move" your ack here, hope that's fine.

CI Applied
#3 lore raw
In reply to Arnd Bergmann
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 11 lines · On Wed, 7 Aug 2024 09:54:22 +0200 you wrote:

From: Arnd Bergmann <[email protected]>

Using FIELD_GET() fails in configurations that don't already include the header file indirectly:

drivers/net/pse-pd/tps23881.c: In function 'tps23881_i2c_probe':
drivers/net/pse-pd/tps23881.c:755:13: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]

  755 |         if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
      |             ^~~~~~~~~

[...]

Here is the summary with links:
- net: pse-pd: tps23881: include missing bitfield.h header

    https://git.kernel.org/netdev/net/c/a70b637db15b

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html