Skip to contentSkip to conversation

6.1.104-rc2 review

PATCH In review Greg Kroah-Hartman 13 participants 19 messages Aug 8, 2024 – Aug 13, 2024

Subsystems (3)
lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

cover 6.1.104-rc2 review

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>

    Linux 6.1.104-rc2

Alexander Maltsev <[email protected]>
netfilter: ipset: Add list flush to cancel_gc

Liu Jing <[email protected]>
selftests: mptcp: always close input's FD if opened

Paolo Abeni <[email protected]>
mptcp: fix duplicate data handling

Matthieu Baerts (NGI0) <[email protected]>
mptcp: pm: only set request_bkup flag when sending MP_PRIO

Paolo Abeni <[email protected]>
mptcp: fix bad RCVPRUNED mib accounting

Paolo Abeni <[email protected]>
mptcp: fix NL PM announced address accounting

Matthieu Baerts (NGI0) <[email protected]>
mptcp: distinguish rcv vs sent backup flag in requests

Paolo Abeni <[email protected]>
mptcp: fix user-space PM announced address accounting

Heiner Kallweit <[email protected]>
r8169: don't increment tx_dropped in case of NETDEV_TX_BUSY

Ma Ke <[email protected]>
net: usb: sr9700: fix uninitialized variable use in sr_mdio_read

Nikita Zhandarovich <[email protected]>
drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()

Zack Rusin <[email protected]>
drm/vmwgfx: Fix a deadlock in dma buf fence polling

Edmund Raile <[email protected]>
Revert "ALSA: firewire-lib: operate for period elapse event in process context"

Edmund Raile <[email protected]>
Revert "ALSA: firewire-lib: obsolete workqueue for period update"

Mavroudis Chatzilazaridis <[email protected]>
ALSA: hda/realtek: Add quirk for Acer Aspire E5-574G

Takashi Iwai <[email protected]>
ALSA: usb-audio: Correct surround channels in UAC1 channel map

Matthieu Baerts (NGI0) <[email protected]>
mptcp: sched: check both directions for backup

Al Viro <[email protected]>

    protect the fetch of ->fd[fd] in do_dup2() from mispredictions

Naohiro Aota <[email protected]>
btrfs: zoned: fix zone_unusable accounting on making block group read-write again

Tatsunosuke Tobita <[email protected]>
HID: wacom: Modify pen IDs

Patryk Duda <[email protected]>
platform/chrome: cros_ec_proto: Lock device when updating MKBP version

Alice Ryhl <[email protected]>
rust: SHADOW_CALL_STACK is incompatible with Rust

Will Deacon <[email protected]>
arm64: jump_label: Ensure patched jump_labels are visible to all CPUs

Zhe Qiao <[email protected]>
riscv/mm: Add handling for VM_FAULT_SIGSEGV in mm_fault_error()

Maciej Żenczykowski <[email protected]>
ipv6: fix ndisc_is_useropt() handling for PIO

Shahar Shitrit <[email protected]>
net/mlx5e: Add a check for the return value from mlx5_port_set_eth_ptys

Moshe Shemesh <[email protected]>
net/mlx5: Fix missing lock on sync reset reload

Mark Bloch <[email protected]>
net/mlx5: Lag, don't use the hardcoded value of the first port

Kuniyuki Iwashima <[email protected]>
netfilter: iptables: Fix potential null-ptr-deref in ip6table_nat_table_init().

Kuniyuki Iwashima <[email protected]>
netfilter: iptables: Fix null-ptr-deref in iptable_nat_table_init().

Takashi Iwai <[email protected]>
ALSA: hda: Conditionally use snooping for AMD HDMI

Dan Carpenter <[email protected]>
net: mvpp2: Don't re-use loop iterator

Suraj Kandpal <[email protected]>
drm/i915/hdcp: Fix HDCP2_STREAM_STATUS macro

Alexandra Winter <[email protected]>
net/iucv: fix use after free in iucv_sock_close()

Maciej Fijalkowski <[email protected]>
ice: add missing WRITE_ONCE when clearing ice_rx_ring::xdp_prog

Maciej Fijalkowski <[email protected]>
ice: replace synchronize_rcu with synchronize_net

Maciej Fijalkowski <[email protected]>
ice: don't busy wait for Rx queue disable in ice_qp_dis()

Michal Kubiak <[email protected]>
ice: respect netif readiness in AF_XDP ZC related ndo's

Kuniyuki Iwashima <[email protected]>
rtnetlink: Don't ignore IFLA_TARGET_NETNSID when ifname is specified in rtnl_dellink().

Andy Chiu <[email protected]>
net: axienet: start napi before enabling Rx/Tx

Luiz Augusto von Dentz <[email protected]>
Bluetooth: hci_sync: Fix suspending with wrong filter policy

songxiebing <[email protected]>
ALSA: hda: conexant: Fix headset auto detect fail in the polling mode

Takashi Iwai <[email protected]>
ALSA: hda: conexant: Reduce CONFIG_PM dependencies

Eric Dumazet <[email protected]>
sched: act_ct: take care of padding in struct zones_ht_key

Ian Forbes <[email protected]>
drm/vmwgfx: Trigger a modeset when the screen moves

Ian Forbes <[email protected]>
drm/vmwgfx: Fix overlay when using Screen Targets

Danilo Krummrich <[email protected]>
drm/nouveau: prime: fix refcount underflow

Basavaraj Natikar <[email protected]>
HID: amd_sfh: Move sensor discovery before HID device initialization

Basavaraj Natikar <[email protected]>
HID: amd_sfh: Split sensor and HID initialization

Basavaraj Natikar <[email protected]>
HID: amd_sfh: Remove duplicate cleanup

Jiaxun Yang <[email protected]>
MIPS: dts: loongson: Fix ls2k1000-rtc interrupt

Jiaxun Yang <[email protected]>
MIPS: dts: loongson: Fix liointc IRQ polarity

Jiaxun Yang <[email protected]>
MIPS: Loongson64: DTS: Fix PCIe port nodes for ls7a

Binbin Zhou <[email protected]>
MIPS: Loongson64: DTS: Add RTC support to Loongson-2K1000

Imre Deak <[email protected]>
drm/i915/dp: Don't switch the LTTPR mode on an active link

Thomas Zimmermann <[email protected]>
drm/udl: Remove DRM_CONNECTOR_POLL_HPD

Thomas Zimmermann <[email protected]>
drm/udl: Move connector to modesetting code

Thomas Zimmermann <[email protected]>
drm/udl: Various improvements to the connector

Thomas Zimmermann <[email protected]>
drm/udl: Use USB timeout constant when reading EDID

Thomas Zimmermann <[email protected]>
drm/udl: Test pixel limit in mode-config's mode-valid function

Thomas Zimmermann <[email protected]>
drm/udl: Rename struct udl_drm_connector to struct udl_connector

Herve Codina <[email protected]>
irqdomain: Fixed unbalanced fwnode get and put

Jaegeuk Kim <[email protected]>
f2fs: assign CURSEG_ALL_DATA_ATGC if blkaddr is valid

Zhiguo Niu <[email protected]>
f2fs: fix to avoid use SSR allocate when do defragment

Li Zhijian <[email protected]>

    mm/page_alloc: fix pcp->count race between drain_pages_zone() vs __rmqueue_pcplist()

Lucas Stach <[email protected]>
mm: page_alloc: control latency caused by zone PCP draining

Huang Ying <[email protected]>
mm: restrict the pcp batch scale factor to avoid too long latency

Thomas Weißschuh <[email protected]>
leds: triggers: Flush pending brightness before activating trigger

Hans de Goede <[email protected]>

    leds: trigger: Call synchronize_rcu() before calling trig->activate()

Heiner Kallweit <[email protected]>
leds: trigger: Store brightness set by led_trigger_event()

Heiner Kallweit <[email protected]>
leds: trigger: Remove unused function led_trigger_rename_static()

Javier Carrasco <[email protected]>
cpufreq: qcom-nvmem: fix memory leaks in probe error paths

Stephan Gerhold <[email protected]>
cpufreq: qcom-nvmem: Simplify driver data allocation

Yangtao Li <[email protected]>
cpufreq: qcom-nvmem: Convert to platform remove callback returning void

Zhang Yi <[email protected]>
ext4: check the extent status again before inserting delalloc block

Zhang Yi <[email protected]>
ext4: factor out a common helper to query extent map

Zhang Yi <[email protected]>
ext4: convert to exclusive lock while inserting delalloc extents

Zhang Yi <[email protected]>
ext4: refactor ext4_da_map_blocks()

Baokun Li <[email protected]>
ext4: make ext4_es_insert_extent() return void

Thomas Weißschuh <[email protected]>
sysctl: always initialize i_uid/i_gid

Thomas Weißschuh <[email protected]>
sysctl: treewide: drop unused argument ctl_table_root::set_ownership(table)

Alexey Gladkov <[email protected]>
sysctl: allow to change limits for posix messages queues

Alexey Gladkov <[email protected]>
sysctl: allow change system v ipc sysctls inside ipc namespace

Krishna Kurapati <[email protected]>
arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB

Krishna Kurapati <[email protected]>
arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB

Dmitry Baryshkov <[email protected]>
arm64: dts: qcom: msm8998: switch USB QMP PHY to new style of bindings

-------------

Diffstat:

 Makefile                                           |   4 +-
 arch/arm64/boot/dts/qcom/ipq8074.dtsi              |   2 +
 arch/arm64/boot/dts/qcom/msm8998.dtsi              |  36 +++---
 arch/arm64/include/asm/jump_label.h                |   1 +
 arch/arm64/kernel/jump_label.c                     |  11 +-
 arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi |  84 +++++++++----
 arch/riscv/mm/fault.c                              |  17 +--
 drivers/cpufreq/qcom-cpufreq-nvmem.c               |  56 ++++-----
 .../gpu/drm/i915/display/intel_dp_link_training.c  |  54 +++++++-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c      |   6 +-
 drivers/gpu/drm/i915/display/intel_hdcp_regs.h     |   2 +-
 drivers/gpu/drm/nouveau/nouveau_prime.c            |   3 +-
 drivers/gpu/drm/udl/Makefile                       |   2 +-
 drivers/gpu/drm/udl/udl_connector.c                | 139 ---------------------
 drivers/gpu/drm/udl/udl_connector.h                |  15 ---
 drivers/gpu/drm/udl/udl_drv.h                      |  11 ++
 drivers/gpu/drm/udl/udl_modeset.c                  | 135 ++++++++++++++++++++
 drivers/gpu/drm/vmwgfx/vmwgfx_fence.c              |  17 ++-
 drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c            |   2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c               |  29 ++++-
 drivers/hid/amd-sfh-hid/amd_sfh_client.c           |  55 ++++----
 drivers/hid/wacom_wac.c                            |   3 +-
 drivers/leds/led-triggers.c                        |  32 ++---
 drivers/leds/trigger/ledtrig-timer.c               |   5 -
 drivers/net/ethernet/intel/ice/ice_txrx.c          |   2 +-
 drivers/net/ethernet/intel/ice/ice_xsk.c           |  19 +--
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c    |   6 +-
 .../net/ethernet/mellanox/mlx5/core/en_ethtool.c   |   7 +-
 drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c |   5 +-
 drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c  |   2 +-
 drivers/net/ethernet/realtek/r8169_main.c          |   8 +-
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c  |   2 +-
 drivers/net/usb/sr9700.c                           |  11 +-
 drivers/platform/chrome/cros_ec_proto.c            |   2 +
 fs/btrfs/block-group.c                             |  13 +-
 fs/btrfs/extent-tree.c                             |   3 +-
 fs/btrfs/free-space-cache.c                        |   4 +-
 fs/btrfs/space-info.c                              |   2 +-
 fs/btrfs/space-info.h                              |   1 +
 fs/ext4/extents.c                                  |   5 +-
 fs/ext4/extents_status.c                           |  14 +--
 fs/ext4/extents_status.h                           |   6 +-
 fs/ext4/inode.c                                    | 115 +++++++++--------
 fs/f2fs/segment.c                                  |   4 +-
 fs/file.c                                          |   1 +
 fs/proc/proc_sysctl.c                              |   8 +-
 include/linux/leds.h                               |  30 +++--
 include/linux/sysctl.h                             |   1 -
 include/trace/events/btrfs.h                       |   8 ++
 include/trace/events/mptcp.h                       |   2 +-
 init/Kconfig                                       |   1 +
 ipc/ipc_sysctl.c                                   |  36 +++++-
 ipc/mq_sysctl.c                                    |  35 ++++++
 kernel/irq/irqdomain.c                             |   7 +-
 mm/Kconfig                                         |  11 ++
 mm/page_alloc.c                                    |  19 ++-
 net/bluetooth/hci_sync.c                           |  21 ++++
 net/core/rtnetlink.c                               |   2 +-
 net/ipv4/netfilter/iptable_nat.c                   |  18 +--
 net/ipv6/ndisc.c                                   |  34 ++---
 net/ipv6/netfilter/ip6table_nat.c                  |  14 ++-
 net/iucv/af_iucv.c                                 |   4 +-
 net/mptcp/options.c                                |   2 +-
 net/mptcp/pm_netlink.c                             |  28 +++--
 net/mptcp/protocol.c                               |  18 +--
 net/mptcp/protocol.h                               |   1 +
 net/mptcp/subflow.c                                |  17 ++-
 net/netfilter/ipset/ip_set_list_set.c              |   3 +
 net/sched/act_ct.c                                 |   4 +-
 net/sysctl_net.c                                   |   1 -
 sound/firewire/amdtp-stream.c                      |  38 +++---
 sound/firewire/amdtp-stream.h                      |   1 +
 sound/pci/hda/hda_controller.h                     |   2 +-
 sound/pci/hda/hda_intel.c                          |  10 +-
 sound/pci/hda/patch_conexant.c                     |  58 ++-------
 sound/pci/hda/patch_realtek.c                      |   1 +
 sound/usb/stream.c                                 |   4 +-
 tools/testing/selftests/net/mptcp/mptcp_connect.c  |   8 +-
 78 files changed, 813 insertions(+), 587 deletions(-)
#1 lore raw

Hi Greg,

Quoted 7 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

Sorry for bothering you again with it (see previous comment on 6.1.103, respectively 6.1.104-rc1): bpftool still would fail to compile:

gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS -c -MMD prog.c -o prog.o prog.c: In function ‘load_with_options’:
prog.c:1710:23: warning: implicit declaration of function ‘create_and_mount_bpffs_dir’ [-Wimplicit-function-declaration]

 1710 |                 err = create_and_mount_bpffs_dir(pinmaps);
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~

gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS btf.o btf_dumper.o cfg.o cgroup.o common.o feature.o gen.o iter.o json_writer.o link.o main.o map.o map_perf_ring.o net.o netlink_dumper.o perf.o pids.o prog.o struct_ops.o tracelog.o xlated_dumper.o disasm.o /home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/libbpf.a -lelf -lz -lcap -o bpftool /bin/ld: prog.o: in function `load_with_options':
prog.c:(.text+0x2f98): undefined reference to `create_and_mount_bpffs_dir'
/bin/ld: prog.c:(.text+0x2ff2): undefined reference to `create_and_mount_bpffs_dir'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:216: bpftool] Error 1
make: *** [Makefile:113: bpftool] Error 2

Reverting 65dd9cbafec2f6f7908cebcab0386f750fc352af fixes the issue. In fact 65dd9cbafec2f6f7908cebcab0386f750fc352af is the only commit adding call to create_and_mount_bpffs_dir:

$ git grep create_and_mount_bpffs_dir
tools/bpf/bpftool/prog.c:               err = create_and_mount_bpffs_dir(pinmaps);

Regards,
Salvatore

#2 lore raw

Hi Greg,

[adding as well people involved in the original commit and the backporting for 6.1.y branch]

Quoted 28 lines · Salvatore Bonaccorso

Hi Greg,

Quoted 7 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

Sorry for bothering you again with it (see previous comment on 6.1.103, respectively 6.1.104-rc1): bpftool still would fail to compile:

gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS -c -MMD prog.c -o prog.o prog.c: In function ‘load_with_options’:
prog.c:1710:23: warning: implicit declaration of function ‘create_and_mount_bpffs_dir’ [-Wimplicit-function-declaration]

 1710 |                 err = create_and_mount_bpffs_dir(pinmaps);
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~

gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS btf.o btf_dumper.o cfg.o cgroup.o common.o feature.o gen.o iter.o json_writer.o link.o main.o map.o map_perf_ring.o net.o netlink_dumper.o perf.o pids.o prog.o struct_ops.o tracelog.o xlated_dumper.o disasm.o /home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/libbpf.a -lelf -lz -lcap -o bpftool /bin/ld: prog.o: in function `load_with_options':
prog.c:(.text+0x2f98): undefined reference to `create_and_mount_bpffs_dir'
/bin/ld: prog.c:(.text+0x2ff2): undefined reference to `create_and_mount_bpffs_dir'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:216: bpftool] Error 1
make: *** [Makefile:113: bpftool] Error 2

Quoted 6 lines

Reverting 65dd9cbafec2f6f7908cebcab0386f750fc352af fixes the issue. In fact 65dd9cbafec2f6f7908cebcab0386f750fc352af is the only commit adding call to create_and_mount_bpffs_dir:

$ git grep create_and_mount_bpffs_dir
tools/bpf/bpftool/prog.c:               err = create_and_mount_bpffs_dir(pinmaps);

Just one additional note, at least 478a535ae54a ("bpftool: Mount bpffs on provided dir instead of parent dir") would be a reqisite where the code was refactored introducing create_and_mount_bpffs_dir() (but won't apply cleanly to 6.1.y). But are more requisites needed?

Should it be safest to just revert the breaking commit for the bpftool build?

Regards,
Salvatore

#3 lore raw

2024-08-10 07:02 UTC+0200 ~ Salvatore Bonaccorso <[email protected]>

Quoted 46 lines

Hi Greg,

[adding as well people involved in the original commit and the backporting for 6.1.y branch]

Quoted 28 lines · Salvatore Bonaccorso

Hi Greg,

Quoted 7 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

Sorry for bothering you again with it (see previous comment on 6.1.103, respectively 6.1.104-rc1): bpftool still would fail to compile:

gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS -c -MMD prog.c -o prog.o prog.c: In function ‘load_with_options’:
prog.c:1710:23: warning: implicit declaration of function ‘create_and_mount_bpffs_dir’ [-Wimplicit-function-declaration]

 1710 |                 err = create_and_mount_bpffs_dir(pinmaps);
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~

gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS btf.o btf_dumper.o cfg.o cgroup.o common.o feature.o gen.o iter.o json_writer.o link.o main.o map.o map_perf_ring.o net.o netlink_dumper.o perf.o pids.o prog.o struct_ops.o tracelog.o xlated_dumper.o disasm.o /home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/libbpf.a -lelf -lz -lcap -o bpftool /bin/ld: prog.o: in function `load_with_options':
prog.c:(.text+0x2f98): undefined reference to `create_and_mount_bpffs_dir'
/bin/ld: prog.c:(.text+0x2ff2): undefined reference to `create_and_mount_bpffs_dir'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:216: bpftool] Error 1
make: *** [Makefile:113: bpftool] Error 2

Quoted 6 lines

Reverting 65dd9cbafec2f6f7908cebcab0386f750fc352af fixes the issue. In fact 65dd9cbafec2f6f7908cebcab0386f750fc352af is the only commit adding call to create_and_mount_bpffs_dir:

$ git grep create_and_mount_bpffs_dir
tools/bpf/bpftool/prog.c:               err = create_and_mount_bpffs_dir(pinmaps);

Just one additional note, at least 478a535ae54a ("bpftool: Mount bpffs on provided dir instead of parent dir") would be a reqisite where the code was refactored introducing create_and_mount_bpffs_dir() (but won't apply cleanly to 6.1.y). But are more requisites needed?

Quoted 6 lines

Should it be safest to just revert the breaking commit for the bpftool build?

Regards,
Salvatore

Hi,

You should be able to fix the build by first cherry-picking commit 2a36c26fe3b8 ("bpftool: Support bpffs mountpoint as pin path for prog loadall"), and then commit 478a535ae54a ("bpftool: Mount bpffs on provided dir instead of parent dir") as you figured. Both commits have a minor conflict on tools/bpf/bpftool/struct_ops.c, which should be addressed by discarding the relevant hunk (for both commit).

Alternatively, it's also fine to revert the breaking commit. It's a quality of life improvement without which users may have to manually mount the bpffs at the location they want to pin their maps when loading multiple BPF programs with "bpftool prog loadall", in the unlikely event they're not using /sys/kernel/bpf, prior to running the bpftool command. It's not in use during the kernel build process or for the BPF selftests, so not necessary on stable branches.

I hope this helps,
Quentin

author maintainer
#4 lore raw
Quoted 54 lines · Quentin Monnet

2024-08-10 07:02 UTC+0200 ~ Salvatore Bonaccorso <[email protected]>

Quoted 46 lines

Hi Greg,

[adding as well people involved in the original commit and the backporting for 6.1.y branch]

Quoted 28 lines · Salvatore Bonaccorso

Hi Greg,

Quoted 7 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

Sorry for bothering you again with it (see previous comment on 6.1.103, respectively 6.1.104-rc1): bpftool still would fail to compile:

gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS -c -MMD prog.c -o prog.o prog.c: In function ‘load_with_options’:
prog.c:1710:23: warning: implicit declaration of function ‘create_and_mount_bpffs_dir’ [-Wimplicit-function-declaration]

 1710 |                 err = create_and_mount_bpffs_dir(pinmaps);
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~

gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS btf.o btf_dumper.o cfg.o cgroup.o common.o feature.o gen.o iter.o json_writer.o link.o main.o map.o map_perf_ring.o net.o netlink_dumper.o perf.o pids.o prog.o struct_ops.o tracelog.o xlated_dumper.o disasm.o /home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/libbpf.a -lelf -lz -lcap -o bpftool /bin/ld: prog.o: in function `load_with_options':
prog.c:(.text+0x2f98): undefined reference to `create_and_mount_bpffs_dir'
/bin/ld: prog.c:(.text+0x2ff2): undefined reference to `create_and_mount_bpffs_dir'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:216: bpftool] Error 1
make: *** [Makefile:113: bpftool] Error 2

Quoted 6 lines

Reverting 65dd9cbafec2f6f7908cebcab0386f750fc352af fixes the issue. In fact 65dd9cbafec2f6f7908cebcab0386f750fc352af is the only commit adding call to create_and_mount_bpffs_dir:

$ git grep create_and_mount_bpffs_dir
tools/bpf/bpftool/prog.c:               err = create_and_mount_bpffs_dir(pinmaps);

Just one additional note, at least 478a535ae54a ("bpftool: Mount bpffs on provided dir instead of parent dir") would be a reqisite where the code was refactored introducing create_and_mount_bpffs_dir() (but won't apply cleanly to 6.1.y). But are more requisites needed?

Quoted 6 lines

Should it be safest to just revert the breaking commit for the bpftool build?

Regards,
Salvatore

Quoted 5 lines

Hi,

You should be able to fix the build by first cherry-picking commit 2a36c26fe3b8 ("bpftool: Support bpffs mountpoint as pin path for prog loadall"),

That commit does not apply cleanly :(

I'll just go revert the original here, that makes it simpler overall.

thanks,

greg k-h

Tested-by on the v1 series
#5 lore raw
In reply to Greg Kroah-Hartman
Quoted 8 lines · On Thu, 08 Aug 2024 11:11:49 +0200 Greg Kroah-Hartman…

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

Boot-tested under QEMU for Rust x86_64:

Thanks!

Cheers,
Miguel

#6 lore raw
In reply to Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 9 lines
	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.

thanks,

greg k-h

I'm seeing a build failure.

sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct hda_codec_ops’ has no member named ‘suspend’
  273 |         .suspend = cx_auto_suspend,
      |          ^~~~~~~
sound/pci/hda/patch_conexant.c:273:20: error: initialization of ‘void (*)(struct hda_codec *, hda_nid_t,  unsigned int)’ {aka ‘void (*)(struct hda_codec *, short unsigned int,  unsigned int)’} from incompatible pointer type ‘int (*)(struct hda_codec *)’ [-Werror=incompatible-pointer-types] 273 |         .suspend = cx_auto_suspend,
      |                    ^~~~~~~~~~~~~~~
sound/pci/hda/patch_conexant.c:273:20: note: (near initialization for ‘cx_auto_patch_ops.set_power_state’)
sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct hda_codec_ops’ has no member named ‘check_power_status’; did you mean ‘set_power_state’?
  274 |         .check_power_status = snd_hda_gen_check_power_status,
      |          ^~~~~~~~~~~~~~~~~~
      |          set_power_state
sound/pci/hda/patch_conexant.c:274:31: error: ‘snd_hda_gen_check_power_status’ undeclared here (not in a function); did you mean ‘snd_hda_check_power_state’?
  274 |         .check_power_status = snd_hda_gen_check_power_status,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                               snd_hda_check_power_state

This is triggered because my config does not include CONFIG_PM. But the error is caused by upstream patch 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce CONFIG_PM dependencies" being missing. This patch removes the #ifdef CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not set, some structure members are missing and the the build fails.

#7 lore raw
Quoted 38 lines · Ron Economos
Quoted 11 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one.  If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:
    https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz

Quoted 8 lines

or in the git tree and branch at:
    git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y and the diffstat can be found below.

thanks,

greg k-h

I'm seeing a build failure.

sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct hda_codec_ops’ has no member named ‘suspend’
  273 |         .suspend = cx_auto_suspend,
      |          ^~~~~~~
sound/pci/hda/patch_conexant.c:273:20: error: initialization of ‘void (*)(struct hda_codec *, hda_nid_t,  unsigned int)’ {aka ‘void (*)(struct hda_codec *, short unsigned int,  unsigned int)’} from incompatible pointer type ‘int (*)(struct hda_codec *)’ [-Werror=incompatible-pointer-types] 273 |         .suspend = cx_auto_suspend,
      |                    ^~~~~~~~~~~~~~~
sound/pci/hda/patch_conexant.c:273:20: note: (near initialization for ‘cx_auto_patch_ops.set_power_state’)
sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct hda_codec_ops’ has no member named ‘check_power_status’; did you mean ‘set_power_state’?
  274 |         .check_power_status = snd_hda_gen_check_power_status,
      |          ^~~~~~~~~~~~~~~~~~
      |          set_power_state
sound/pci/hda/patch_conexant.c:274:31: error: ‘snd_hda_gen_check_power_status’ undeclared here (not in a function); did you mean ‘snd_hda_check_power_state’?
  274 |         .check_power_status = snd_hda_gen_check_power_status,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                               snd_hda_check_power_state

Quoted 3 lines

This is triggered because my config does not include CONFIG_PM. But the error is caused by upstream patch 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce CONFIG_PM dependencies" being missing. This patch removes the #ifdef CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not set, some structure members are missing and the the build fails.

Same failure occurs in 6.6.45-rc1 if CONFIG_PM is not set.

#8 lore raw
Quoted 39 lines · Ron Economos
Quoted 38 lines · Ron Economos
Quoted 11 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one.  If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:
    https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz

Quoted 8 lines

or in the git tree and branch at:
    git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y and the diffstat can be found below.

thanks,

greg k-h

I'm seeing a build failure.

sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct hda_codec_ops’ has no member named ‘suspend’
  273 |         .suspend = cx_auto_suspend,
      |          ^~~~~~~
sound/pci/hda/patch_conexant.c:273:20: error: initialization of ‘void (*)(struct hda_codec *, hda_nid_t,  unsigned int)’ {aka ‘void (*)(struct hda_codec *, short unsigned int,  unsigned int)’} from incompatible pointer type ‘int (*)(struct hda_codec *)’ [-Werror=incompatible-pointer-types] 273 |         .suspend = cx_auto_suspend,
      |                    ^~~~~~~~~~~~~~~
sound/pci/hda/patch_conexant.c:273:20: note: (near initialization for ‘cx_auto_patch_ops.set_power_state’)
sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct hda_codec_ops’ has no member named ‘check_power_status’; did you mean ‘set_power_state’?
  274 |         .check_power_status = snd_hda_gen_check_power_status,
      |          ^~~~~~~~~~~~~~~~~~
      |          set_power_state
sound/pci/hda/patch_conexant.c:274:31: error: ‘snd_hda_gen_check_power_status’ undeclared here (not in a function); did you mean ‘snd_hda_check_power_state’?
  274 |         .check_power_status = snd_hda_gen_check_power_status,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                               snd_hda_check_power_state

Quoted 6 lines
Quoted 3 lines

This is triggered because my config does not include CONFIG_PM. But the error is caused by upstream patch 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce CONFIG_PM dependencies" being missing. This patch removes the #ifdef CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not set, some structure members are missing and the the build fails.

Same failure occurs in 6.6.45-rc1 if CONFIG_PM is not set.

Note: Both upstream 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce CONFIG_PM dependencies" and 6c8fd3499423fc3ebb735f32d4a52bc5825f6301 "ALSA: hda: generic: Reduce CONFIG_PM dependencies" are required to fix the build if CONFIG_PM is not set.

author maintainer
#9 lore raw
Quoted 59 lines · Ron Economos
Quoted 58 lines · Ron Economos
Quoted 57 lines · Ron Economos
Quoted 11 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one.  If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:
    https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz

Quoted 9 lines

or in the git tree and branch at:
    git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-6.1.y
and the diffstat can be found below.

thanks,

greg k-h

I'm seeing a build failure.

sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct hda_codec_ops’ has no member named ‘suspend’
  273 |         .suspend = cx_auto_suspend,
      |          ^~~~~~~ sound/pci/hda/patch_conexant.c:273:20: error: initialization of ‘void (*)(struct hda_codec *, hda_nid_t,  unsigned int)’ {aka ‘void (*)(struct hda_codec *, short unsigned int,  unsigned int)’} from incompatible pointer type ‘int (*)(struct hda_codec *)’ [-Werror=incompatible-pointer-types]
  273 |         .suspend = cx_auto_suspend,
      |                    ^~~~~~~~~~~~~~~ sound/pci/hda/patch_conexant.c:273:20: note: (near initialization for ‘cx_auto_patch_ops.set_power_state’) sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct hda_codec_ops’ has no member named ‘check_power_status’; did you mean ‘set_power_state’?
  274 |         .check_power_status = snd_hda_gen_check_power_status, |          ^~~~~~~~~~~~~~~~~~
      |          set_power_state sound/pci/hda/patch_conexant.c:274:31: error:
‘snd_hda_gen_check_power_status’ undeclared here (not in a function); did you mean ‘snd_hda_check_power_state’?
  274 |         .check_power_status = snd_hda_gen_check_power_status, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                               snd_hda_check_power_state

This is triggered because my config does not include CONFIG_PM. But the error is caused by upstream patch 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce CONFIG_PM dependencies" being missing. This patch removes the #ifdef CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not set, some structure members are missing and the the build fails.

Quoted 8 lines
Quoted 3 lines

Same failure occurs in 6.6.45-rc1 if CONFIG_PM is not set.

Note: Both upstream 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda:
codec: Reduce CONFIG_PM dependencies" and 6c8fd3499423fc3ebb735f32d4a52bc5825f6301 "ALSA: hda: generic: Reduce CONFIG_PM dependencies" are required to fix the build if CONFIG_PM is not set.

thanks, I have fixed this all now up.

greg k-h

Tested-by on the v1 series
#11 lore raw
In reply to Greg Kroah-Hartman

Hi!

Quoted 4 lines

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-6.1.y

Best regards,
Pavel

Signature · 2 lines
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Tested-by Linux Kernel Functional Testing on the v1 series
#12 lore raw
In reply to Greg Kroah-Hartman
Quoted 10 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
        https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.

thanks,

greg k-h

Results from Linaro's test farm.
No regressions on arm64, arm, x86_64, and i386.

## Build
* kernel: 6.1.104-rc2
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git commit: 54b8e3a13b43747af658936db1fa59a365d52997
* git describe: v6.1.103-87-g54b8e3a13b43
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.103-87-g54b8e3a13b43

## Test Regressions (compared to v6.1.102-441-gdbbffaaee188)

## Metric Regressions (compared to v6.1.102-441-gdbbffaaee188)

## Test Fixes (compared to v6.1.102-441-gdbbffaaee188)

## Metric Fixes (compared to v6.1.102-441-gdbbffaaee188)

## Test result summary
total: 219072, pass: 188702, fail: 2594, skip: 27408, xfail: 368

## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 135 total, 135 passed, 0 failed
* arm64: 38 total, 38 passed, 0 failed
* i386: 28 total, 28 passed, 0 failed
* mips: 26 total, 25 passed, 1 failed
* parisc: 4 total, 3 passed, 1 failed
* powerpc: 36 total, 35 passed, 1 failed
* riscv: 11 total, 11 passed, 0 failed
* s390: 14 total, 12 passed, 2 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 7 total, 7 passed, 0 failed
* x86_64: 33 total, 33 passed, 0 failed

## Test suites summary
* boot
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-efivarfs
* kselftest-exec
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-kcmp
* kselftest-kvm
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-mincore
* kselftest-mqueue
* kselftest-net
* kselftest-net-mptcp
* kselftest-openat2
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-tc-testing
* kselftest-timers
* kselftest-timesync-off
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user_events
* kselftest-vDSO
* kselftest-watchdog
* kselftest-x86
* kunit
* kvm-unit-tests
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-test
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-smoke
* ltp-smoketest
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture

--
Linaro LKFT
https://lkft.linaro.org

Tested-by on the v1 series
#13 lore raw
In reply to Greg Kroah-Hartman

Am 08.08.2024 um 11:11 schrieb Greg Kroah-Hartman:

Quoted 4 lines

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Builds, boots and works on my 2-socket Ivy Bridge Xeon E5-2697 v2 server. No dmesg oddities or regressions found.

Beste Grüße,
Peter Schneider

Signature · 8 lines
Climb the mountain not to plant your flag, but to embrace the challenge,
enjoy the air and behold the view. Climb it so you can see the world,
not so the world can see you.                    -- David McCullough Jr.

OpenPGP:  0xA3828BD796CCE11A8CADE8866E3A92C92C3FF244
Download: https://www.peters-netzplatz.de/download/pschneider1968_pub.asc
https://keys.mailvelope.com/pks/lookup?op=get&[email protected]
https://keys.mailvelope.com/pks/lookup?op=get&[email protected]
maintainer Tested-by on the v1 series
#14 lore raw
In reply to Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.

thanks,

greg k-h

All tests passing for Tegra ...

Test results for stable-v6.1:

    10 builds:	10 pass, 0 fail
    26 boots:	26 pass, 0 fail
    116 tests:	116 pass, 0 fail

Linux version: 6.1.104-rc2-g54b8e3a13b43
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,

                tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
                tegra20-ventana, tegra210-p2371-2180,
                tegra210-p3450-0000, tegra30-cardhu-a04

Jon

Tested-by kernelci.org bot on the v1 series
#15 lore raw
In reply to Greg Kroah-Hartman

---- On Thu, 08 Aug 2024 14:41:49 +0530 Greg Kroah-Hartman wrote ---

Quoted 8 lines

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

Quoted 8 lines

The whole patch series can be found in one patch at:
    https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
or in the git tree and branch at:
    git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y and the diffstat can be found below.

thanks,

Date: 2024-08-07

## Build failures:

No **new** build failures seen for the stable-rc/linux-6.1.y commit head \o/

## Boot failures:

No **new** boot failures seen for the stable-rc/linux-6.1.y commit head \o/

Tested-by on the v1 series
#16 lore raw
In reply to Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.

thanks,

greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on BMIPS_GENERIC:

Signature · 1 line
Florian
#17 lore raw
In reply to Greg Kroah-Hartman

Hi,

Quoted 14 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.

...

Quoted 3 lines

Naohiro Aota <[email protected]>
btrfs: zoned: fix zone_unusable accounting on making block group read-write again

This patch results in a variety of problems with the parisc64 qemu emulation. Some examples from various test runs:

[   10.527204] alg: akcipher: test 1 failed for rsa-generic, err=-22
[   10.529743] alg: self-tests for rsa using rsa-generic failed (rc=-22)
[   10.529905] ------------[ cut here ]------------
[   10.530276] alg: self-tests for rsa using rsa-generic failed (rc=-22)
[   10.530732] WARNING: CPU: 0 PID: 50 at crypto/testmgr.c:5907 alg_test+0x618/0x688
[    7.420056] ==================================================================
[    7.420507] BUG: KFENCE: invalid read in walk_stackframe.isra.0+0xb4/0x138
[    7.420507]
[    7.420827] Invalid read at 0x0000000042f07000:
[    7.421037]  walk_stackframe.isra.0+0xb4/0x138
[    7.421204]  arch_stack_walk+0x38/0x50
[    7.421338]  stack_trace_save_regs+0x58/0x70
[    7.421498]  kfence_report_error+0x14c/0x730
[    7.421649]  kfence_handle_page_fault+0x2c8/0x2d0
[    7.421996]  handle_interruption+0x9b0/0xb58
[    7.422168]  intr_check_sig+0x0/0x3c
[    8.891194] =============================================================================
[    8.891558] BUG sgpool-32 (Tainted: G    B   W        N): Wrong object count. Counter is 3 but counted were 18
[    0.403174] =============================================================================
[    0.403568] BUG audit_buffer (Not tainted): Wrong object count. Counter is 1 but counted were 34
[    0.505914] =============================================================================
[    0.506258] BUG skbuff_head_cache (Tainted: G    B             ): Freechain corrupt
[    2.831636] =============================================================================
[    2.832144] BUG skbuff_head_cache (Tainted: G    B             ): Left Redzone overwritten

Reverting it fixes the problem.

Bisect log is attached for reference.

I tried to repeat the test with v6.1.105-rc1, but that fails to compile for parisc64.

/home/groeck/src/linux-stable/include/linux/slab.h:228: warning: "ARCH_KMALLOC_MINALIGN" redefined
228 | #define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN

This is due to commit 96423e23e05b ("parisc: fix a possible DMA corruption"). After reverting that patch I don't see the above problems anymore in v6.1.105-rc1, so it looks like the btrfs patches in v6.1.105-rc1 may have fixed it (or maybe there is another hidden bug in the parisc64 qemu emulation).

Guenter

---
# bad: [36790ef5e00b69ccb92817f95ba1928eea24eebb] Linux 6.1.104
# good: [48d525b0e4634c487cf46a41c1e2824e9ee258ce] Linux 6.1.103
git bisect start 'HEAD' 'v6.1.103'
# good: [d06daf0ad645d9225a3ff6958dd82e1f3988fa64] sched: act_ct: take care of padding in struct zones_ht_key git bisect good d06daf0ad645d9225a3ff6958dd82e1f3988fa64
# good: [ed15fdf30736a255c0e4f5d0263e12cf6636fade] rust: SHADOW_CALL_STACK is incompatible with Rust git bisect good ed15fdf30736a255c0e4f5d0263e12cf6636fade
# bad: [5670466033d14329aaa87e726a481a6c56892eff] drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll() git bisect bad 5670466033d14329aaa87e726a481a6c56892eff
# bad: [47ab33e1d6a796a82f9b7a70ed95c9649e92d7d2] mptcp: sched: check both directions for backup
git bisect bad 47ab33e1d6a796a82f9b7a70ed95c9649e92d7d2
# good: [8bb9cf2edf490e65678f2d57634ac763a778aeb6] HID: wacom: Modify pen IDs
git bisect good 8bb9cf2edf490e65678f2d57634ac763a778aeb6
# bad: [5db999fff545b924b24c9afd368ef5c17279b176] protect the fetch of ->fd[fd] in do_dup2() from mispredictions git bisect bad 5db999fff545b924b24c9afd368ef5c17279b176
# bad: [36dac679722e5aa68c9efa822a38a5ea0c107342] btrfs: zoned: fix zone_unusable accounting on making block group read- write again
git bisect bad 36dac679722e5aa68c9efa822a38a5ea0c107342

# first bad commit: [36dac679722e5aa68c9efa822a38a5ea0c107342] btrfs: zoned: fix zone_unusable accounting on making bloc
k group read-write again
#18 lore raw
Quoted 62 lines · Guenter Roeck

Hi,

Quoted 14 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.104 release. There are 86 patches in this series, all will be posted as a response to this one.  If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:
    https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
or in the git tree and branch at:
    git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y and the diffstat can be found below.

...

Quoted 3 lines

Naohiro Aota <[email protected]>
     btrfs: zoned: fix zone_unusable accounting on making block group read-write again

This patch results in a variety of problems with the parisc64 qemu emulation. Some examples from various test runs:

[   10.527204] alg: akcipher: test 1 failed for rsa-generic, err=-22
[   10.529743] alg: self-tests for rsa using rsa-generic failed (rc=-22) [   10.529905] ------------[ cut here ]------------
[   10.530276] alg: self-tests for rsa using rsa-generic failed (rc=-22) [   10.530732] WARNING: CPU: 0 PID: 50 at crypto/testmgr.c:5907 alg_test+0x618/0x688

[    7.420056] ================================================================== [    7.420507] BUG: KFENCE: invalid read in walk_stackframe.isra.0+0xb4/0x138 [    7.420507]
[    7.420827] Invalid read at 0x0000000042f07000:
[    7.421037]  walk_stackframe.isra.0+0xb4/0x138
[    7.421204]  arch_stack_walk+0x38/0x50
[    7.421338]  stack_trace_save_regs+0x58/0x70
[    7.421498]  kfence_report_error+0x14c/0x730
[    7.421649]  kfence_handle_page_fault+0x2c8/0x2d0
[    7.421996]  handle_interruption+0x9b0/0xb58
[    7.422168]  intr_check_sig+0x0/0x3c

[    8.891194] =============================================================================
[    8.891558] BUG sgpool-32 (Tainted: G    B   W        N): Wrong object count. Counter is 3 but counted were 18

[    0.403174] ============================================================================= [    0.403568] BUG audit_buffer (Not tainted): Wrong object count. Counter is 1 but counted were 34

[    0.505914] ============================================================================= [    0.506258] BUG skbuff_head_cache (Tainted: G    B             ): Freechain corrupt

[    2.831636] ============================================================================= [    2.832144] BUG skbuff_head_cache (Tainted: G    B             ): Left Redzone overwritten

Reverting it fixes the problem.

Bisect log is attached for reference.

I tried to repeat the test with v6.1.105-rc1, but that fails to compile for parisc64.

Quoted 8 lines

/home/groeck/src/linux-stable/include/linux/slab.h:228: warning: "ARCH_KMALLOC_MINALIGN" redefined
  228 | #define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN

This is due to commit 96423e23e05b ("parisc: fix a possible DMA corruption"). After reverting that patch I don't see the above problems anymore in v6.1.105-rc1, so it looks like the btrfs patches in v6.1.105-rc1 may have fixed it (or maybe there is another hidden bug in the parisc64 qemu emulation).

Oh, never mind. I did a reverse bisect on v6.1.105-rc1 (after fixing the build failure there), and it points to an unrelated commit. Looks like another qemu emulation bug. Sorry for the noise.

Guenter