arm64: dts: imx8mm/n-beacon-kit: Fix the order of ADV7535 reg entries
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 arm64: dts: imx8mm/n-beacon-kit: Fix the order of ADV7535 reg entries
From: Fabio Estevam <[email protected]>
According to adi,adv7533.yaml, the order for the reg and reg-names entries must be: main, edid, cec, and packet.
Fix it accordingly to remove the following dt-schema warnings:
hdmi@3d: reg-names:1: 'edid' was expected
hdmi@3d: reg-names:2: 'cec' was expected
--- arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts | 4 ++-- arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts +2 -2
@@ -62,8 +62,8 @@ adv_bridge: hdmi@3d { compatible = "adi,adv7535"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_hdmi_bridge>; - reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>; - reg-names = "main", "cec", "edid", "packet"; + reg = <0x3d>, <0x3e>, <0x3c>, <0x3f>; + reg-names = "main", "edid", "cec", "packet"; adi,dsi-lanes = <4>; avdd-supply = <®_hdmi>; a2vdd-supply = <®_hdmi>;
arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts +2 -2
@@ -62,8 +62,8 @@ adv_bridge: hdmi@3d { compatible = "adi,adv7535"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_hdmi_bridge>; - reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>; - reg-names = "main", "cec", "edid", "packet"; + reg = <0x3d>, <0x3e>, <0x3c>, <0x3f>; + reg-names = "main", "edid", "cec", "packet"; adi,dsi-lanes = <4>; avdd-supply = <®_hdmi>; a2vdd-supply = <®_hdmi>;
Signature · 1 line
2.34.1
Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
According to adi,adv7533.yaml, the order for the reg and reg-names entries must be: main, edid, cec, and packet.
Quoted 6 lines
Fix it accordingly to remove the following dt-schema warnings:
hdmi@3d: reg-names:1: 'edid' was expected
hdmi@3d: reg-names:2: 'cec' was expectedSigned-off-by Fabio Estevam <[email protected]>
I am traveling, but LGTM.
If this needs a V2 for some reason, we could probably delete the optional reg settings since I think these are using the defaults anyway. I don't have the datasheets in front of me nor the source code, so I am not 100% sure.
adam
Quoted 38 lines
--- arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts | 4 ++-- arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dts +2
-2@@ -62,8 +62,8 @@ adv_bridge: hdmi@3d { compatible = "adi,adv7535"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_hdmi_bridge>; - reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>; - reg-names = "main", "cec", "edid", "packet"; + reg = <0x3d>, <0x3e>, <0x3c>, <0x3f>; + reg-names = "main", "edid", "cec", "packet"; adi,dsi-lanes = <4>; avdd-supply = <®_hdmi>; a2vdd-supply = <®_hdmi>;arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts +2
-3@@ -62,8 +62,8 @@ adv_bridge: hdmi@3d { compatible = "adi,adv7535"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_hdmi_bridge>; - reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>; - reg-names = "main", "cec", "edid", "packet"; + reg = <0x3d>, <0x3e>, <0x3c>, <0x3f>; + reg-names = "main", "edid", "cec", "packet"; adi,dsi-lanes = <4>; avdd-supply = <®_hdmi>; a2vdd-supply = <®_hdmi>; --2.34.1
Shawn Guo
AppliedQuoted 11 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
According to adi,adv7533.yaml, the order for the reg and reg-names entries must be: main, edid, cec, and packet.
Fix it accordingly to remove the following dt-schema warnings:
hdmi@3d: reg-names:1: 'edid' was expected
hdmi@3d: reg-names:2: 'cec' was expectedSigned-off-by Fabio Estevam <[email protected]>
Applied, thanks!