mlx5 misc fixes 2024-08-08
Tariq Toukan
maintainercover mlx5 misc fixes 2024-08-08
Hi,
This patchset provides misc bug fixes from the team to the mlx5 core and Eth drivers.
Series generated against:
commit b928e7d19dfd ("Merge tag 'for-net-2024-08-07' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth")
Thanks,
Tariq.
Cosmin Ratiu (1):
net/mlx5e: Correctly report errors for ethtool rx flows
Dragos Tatulea (2):
net/mlx5e: SHAMPO, Increase timeout to improve latency net/mlx5e: Take state lock during tx timeout reporter
Gal Pressman (1):
net/mlx5e: Fix queue stats access to non-existing channels splat
Tariq Toukan (1):
net/mlx5: SD, Do not query MPIR register if no sd_group
drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- .../ethernet/mellanox/mlx5/core/en/params.c | 16 +++++++++++++++- .../ethernet/mellanox/mlx5/core/en/params.h | 1 + .../mellanox/mlx5/core/en/reporter_tx.c | 2 ++ .../mellanox/mlx5/core/en_fs_ethtool.c | 2 +- .../net/ethernet/mellanox/mlx5/core/en_main.c | 17 ++++------------- .../net/ethernet/mellanox/mlx5/core/lib/sd.c | 18 +++++++++--------- 7 files changed, 33 insertions(+), 25 deletions(-)
Signature · 1 line
2.44.0
Tariq Toukan
maintainerPATCH 1/5 net/mlx5: SD, Do not query MPIR register if no sd_group
Unconditionally calling the MPIR query on BF separate mode yields the FW syndrome below [1]. Do not call it unless admin clearly specified the SD group, i.e. expressing the intention of using the multi-PF netdev feature.
This fix covers cases not covered in
commit fca3b4791850 ("net/mlx5: Do not query MPIR on embedded CPU function").
[1]
mlx5_cmd_out_err:808:(pid 8267): ACCESS_REG(0x805) op_mod(0x1) failed, status bad system state(0x4), syndrome (0x685f19), err(-5)
--- .../net/ethernet/mellanox/mlx5/core/lib/sd.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c +9 -9
@@ -126,7 +126,7 @@ static bool mlx5_sd_is_supported(struct mlx5_core_dev *dev, u8 host_buses) }static int mlx5_query_sd (struct mlx5_core_dev *dev,bool *sdm, -u8 *host_buses,u8 *sd_group) +u8 *host_buses) {u32 out[MLX5_ST_SZ_DW (mpir_reg)];int err;
@@ -135,10 +135,6 @@ static int mlx5_query_sd(struct mlx5_core_dev *dev, bool *sdm,if (err)return err; - err =mlx5_query_nic_vport_sd_group (dev, sd_group); -if (err) -return err; - *sdm =MLX5_GET (mpir_reg, out, sdm); *host_buses =MLX5_GET (mpir_reg, out, host_buses);
@@ -166,19 +162,23 @@ static int sd_init(struct mlx5_core_dev *dev)if (mlx5_core_is_ecpf (dev))return 0 ; + err =mlx5_query_nic_vport_sd_group (dev, &sd_group); +if (err) +return err; + +if (!sd_group) +return 0 ; +if (!MLX5_CAP_MCAM_REG (dev, mpir))return 0 ; - err =mlx5_query_sd (dev, &sdm, &host_buses, &sd_group); + err =mlx5_query_sd (dev, &sdm, &host_buses);if (err)return err;if (!sdm)return 0 ; -if (!sd_group) -return 0 ; - group_id =mlx5_sd_group_id (dev, sd_group);if (!mlx5_sd_is_supported (dev, host_buses)) {
Signature · 1 line
2.44.0
Tariq Toukan
maintainerPATCH 2/5 net/mlx5e: SHAMPO, Increase timeout to improve latency
In reply to Tariq ToukanFrom: Dragos Tatulea <[email protected]>
During latency tests (netperf TCP_RR) a 30% degradation of HW GRO vs SW GRO was observed. This is due to SHAMPO triggering timeout filler CQEs instead of delivering the CQE for the packet.
Having a short timeout for SHAMPO doesn't bring any benefits as it is the driver that does the merging, not the hardware. On the contrary, it can have a negative impact: additional filler CQEs are generated due to the timeout. As there is no way to disable this timeout, this change sets it to the maximum value.
Instead of using the packet_merge.timeout parameter which is also used for LRO, set the value directly when filling in the rest of the SHAMPO parameters in mlx5e_build_rq_param().
--- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- .../net/ethernet/mellanox/mlx5/core/en/params.c | 16 +++++++++++++++- .../net/ethernet/mellanox/mlx5/core/en/params.h | 1 + .../net/ethernet/mellanox/mlx5/core/en_main.c | 12 ------------ 4 files changed, 17 insertions(+), 14 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en.h +1 -1
@@ -130,7 +130,7 @@ struct page_pool;#define MLX5E_PARAMS_MINIMUM_LOG_RQ_SIZE_MPW 0x2#define MLX5E_DEFAULT_LRO_TIMEOUT 32 -#define MLX5E_LRO_TIMEOUT_ARR_SIZE 4 +#define MLX5E_DEFAULT_SHAMPO_TIMEOUT 1024#define MLX5E_PARAMS_DEFAULT_RX_CQ_MODERATION_USEC 0x10#define MLX5E_PARAMS_DEFAULT_RX_CQ_MODERATION_USEC_FROM_CQE 0x3
drivers/net/ethernet/mellanox/mlx5/core/en/params.c +15 -1
@@ -928,7 +928,7 @@ int mlx5e_build_rq_param(struct mlx5_core_dev *mdev,MLX5_SET (wq, wq, log_headers_entry_size,mlx5e_shampo_get_log_hd_entry_size (mdev, params));MLX5_SET (rqc, rqc, reservation_timeout, - params->packet_merge.timeout); +mlx5e_choose_lro_timeout (mdev,MLX5E_DEFAULT_SHAMPO_TIMEOUT ));MLX5_SET (rqc, rqc, shampo_match_criteria_type, params->packet_merge.shampo.match_criteria_type); MLX5_SET(rqc, rqc, shampo_no_match_alignment_granularity,
@@ -1087,6 +1087,20 @@ static u32 mlx5e_shampo_icosq_sz(struct mlx5_core_dev *mdev,return wqebbs; } +#define MLX5E_LRO_TIMEOUT_ARR_SIZE 4 + +u32 mlx5e_choose_lro_timeout (struct mlx5_core_dev *mdev,u32 wanted_timeout) +{ +int i; + +/* The supported periods are organized in ascending order */ +for (i =0 ; i <MLX5E_LRO_TIMEOUT_ARR_SIZE -1 ; i++) +if (MLX5_CAP_ETH (mdev, lro_timer_supported_periods[i]) >= wanted_timeout) +break ; + +return MLX5_CAP_ETH (mdev, lro_timer_supported_periods[i]); +} +static u32 mlx5e_mpwrq_total_umr_wqebbs (struct mlx5_core_dev *mdev,struct mlx5e_params *params,struct mlx5e_xsk_param *xsk)
drivers/net/ethernet/mellanox/mlx5/core/en/params.h +1 -0
@@ -108,6 +108,7 @@ u32 mlx5e_shampo_hd_per_wqe(struct mlx5_core_dev *mdev,u32 mlx5e_shampo_hd_per_wq (struct mlx5_core_dev *mdev,struct mlx5e_params *params,struct mlx5e_rq_param *rq_param); +u32 mlx5e_choose_lro_timeout (struct mlx5_core_dev *mdev,u32 wanted_timeout);u8 mlx5e_mpwqe_get_log_stride_size (struct mlx5_core_dev *mdev,struct mlx5e_params *params,struct mlx5e_xsk_param *xsk);
drivers/net/ethernet/mellanox/mlx5/core/en_main.c +0 -12
@@ -5167,18 +5167,6 @@ const struct net_device_ops mlx5e_netdev_ops = {#endif }; -static u32 mlx5e_choose_lro_timeout (struct mlx5_core_dev *mdev,u32 wanted_timeout) -{ -int i; - -/* The supported periods are organized in ascending order */ -for (i =0 ; i <MLX5E_LRO_TIMEOUT_ARR_SIZE -1 ; i++) -if (MLX5_CAP_ETH (mdev, lro_timer_supported_periods[i]) >= wanted_timeout) -break ; - -return MLX5_CAP_ETH (mdev, lro_timer_supported_periods[i]); -} -void mlx5e_build_nic_params (struct mlx5e_priv *priv,struct mlx5e_xsk *xsk,u16 mtu) {struct mlx5e_params *params = &priv->channels.params;
Signature · 1 line
2.44.0
Tariq Toukan
maintainerPATCH 3/5 net/mlx5e: Take state lock during tx timeout reporter
In reply to Tariq ToukanFrom: Dragos Tatulea <[email protected]>
mlx5e_safe_reopen_channels() requires the state lock taken. The referenced changed in the Fixes tag removed the lock to fix another issue. This patch adds it back but at a later point (when calling mlx5e_safe_reopen_channels()) to avoid the deadlock referenced in the Fixes tag.
--- drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c +2 -0
@@ -146,7 +146,9 @@ static int mlx5e_tx_reporter_timeout_recover(void *ctx)return err; } +mutex_lock (&priv->state_lock); err =mlx5e_safe_reopen_channels (priv); +mutex_unlock (&priv->state_lock);if (!err) { to_ctx->status =1 ;/* all channels recovered */ return err;
Signature · 1 line
2.44.0
Tariq Toukan
maintainerPATCH 4/5 net/mlx5e: Correctly report errors for ethtool rx flows
In reply to Tariq ToukanFrom: Cosmin Ratiu <[email protected]>
Previously, an ethtool rx flow with no attrs would not be added to the NIC as it has no rules to configure the hw with, but it would be reported as successful to the caller (return code 0). This is confusing for the user as ethtool then reports "Added rule $num", but no rule was actually added.
This change corrects that by instead reporting these wrong rules as -EINVAL.
--- drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c +1 -1
@@ -734,7 +734,7 @@ mlx5e_ethtool_flow_replace(struct mlx5e_priv *priv,if (num_tuples <=0 ) {netdev_warn (priv->netdev,"%s: flow is not valid %d\n" , __func__, num_tuples); -return num_tuples; +return num_tuples <0 ? num_tuples : -EINVAL ; } eth_ft =get_flow_table (priv, fs, num_tuples);
Signature · 1 line
2.44.0
Tariq Toukan
maintainerPATCH 5/5 net/mlx5e: Fix queue stats access to non-existing channels splat
In reply to Tariq ToukanFrom: Gal Pressman <[email protected]>
The queue stats API queries the queues according to the real_num_[tr]x_queues, in case the device is down and channels were not yet created, don't try to query their statistics.
To trigger the panic, run this command before the interface is brought
up:
./cli.py --spec ../../../Documentation/netlink/specs/netdev.yaml --dump qstats-get --json '{"ifindex": 4}'
BUG: kernel NULL pointer dereference, address: 0000000000000c00 PGD 0 P4D 0 Oops: Oops: 0000 [#1] SMP PTI CPU: 3 UID: 0 PID: 977 Comm: python3 Not tainted 6.10.0+ #40 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014 RIP: 0010:mlx5e_get_queue_stats_rx+0x3c/0xb0 [mlx5_core] Code: fc 55 48 63 ee 53 48 89 d3 e8 40 3d 70 e1 85 c0 74 58 4c 89 ef e8 d4 07 04 00 84 c0 75 41 49 8b 84 24 f8 39 00 00 48 8b 04 e8 <48> 8b 90 00 0c 00 00 48 03 90 40 0a 00 00 48 89 53 08 48 8b 90 08 RSP: 0018:ffff888116be37d0 EFLAGS: 00010246 RAX: 0000000000000000 RBX: ffff888116be3868 RCX: 0000000000000004 RDX: ffff88810ada4000 RSI: 0000000000000000 RDI: ffff888109df09c0 RBP: 0000000000000000 R08: 0000000000000004 R09: 0000000000000004 R10: ffff88813461901c R11: ffffffffffffffff R12: ffff888109df0000 R13: ffff888109df09c0 R14: ffff888116be38d0 R15: 0000000000000000 FS: 00007f4375d5c740(0000) GS:ffff88852c980000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000c00 CR3: 0000000106ada006 CR4: 0000000000370eb0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> ? __die+0x1f/0x60 ? page_fault_oops+0x14e/0x3d0 ? exc_page_fault+0x73/0x130 ? asm_exc_page_fault+0x22/0x30 ? mlx5e_get_queue_stats_rx+0x3c/0xb0 [mlx5_core] netdev_nl_stats_by_netdev+0x2a6/0x4c0 ? __rmqueue_pcplist+0x351/0x6f0 netdev_nl_qstats_get_dumpit+0xc4/0x1b0 genl_dumpit+0x2d/0x80 netlink_dump+0x199/0x410 __netlink_dump_start+0x1aa/0x2c0 genl_family_rcv_msg_dumpit+0x94/0xf0 ? __pfx_genl_start+0x10/0x10 ? __pfx_genl_dumpit+0x10/0x10 ? __pfx_genl_done+0x10/0x10 genl_rcv_msg+0x116/0x2b0 ? __pfx_netdev_nl_qstats_get_dumpit+0x10/0x10 ? __pfx_genl_rcv_msg+0x10/0x10 netlink_rcv_skb+0x54/0x100 genl_rcv+0x24/0x40 netlink_unicast+0x21a/0x340 netlink_sendmsg+0x1f4/0x440 __sys_sendto+0x1b6/0x1c0 ? do_sock_setsockopt+0xc3/0x180 ? __sys_setsockopt+0x60/0xb0 __x64_sys_sendto+0x20/0x30 do_syscall_64+0x50/0x110 entry_SYSCALL_64_after_hwframe+0x76/0x7e RIP: 0033:0x7f43757132b0 Code: c0 ff ff ff ff eb b8 0f 1f 00 f3 0f 1e fa 41 89 ca 64 8b 04 25 18 00 00 00 85 c0 75 1d 45 31 c9 45 31 c0 b8 2c 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 68 c3 0f 1f 80 00 00 00 00 41 54 48 83 ec 20 RSP: 002b:00007ffd258da048 EFLAGS: 00000246 ORIG_RAX: 000000000000002c RAX: ffffffffffffffda RBX: 00007ffd258da0f8 RCX: 00007f43757132b0 RDX: 000000000000001c RSI: 00007f437464b850 RDI: 0000000000000003 RBP: 00007f4375085de0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: ffffffffc4653600 R14: 0000000000000001 R15: 00007f43751a6147 </TASK> Modules linked in: netconsole xt_conntrack xt_MASQUERADE nf_conntrack_netlink nfnetlink xt_addrtype iptable_nat nf_nat br_netfilter rpcsec_gss_krb5 auth_rpcgss oid_registry overlay rpcrdma rdma_ucm ib_iser libiscsi scsi_transport_iscsi ib_umad rdma_cm ib_ipoib iw_cm ib_cm mlx5_ib ib_uverbs ib_core zram zsmalloc mlx5_core fuse [last unloaded: netconsole] CR2: 0000000000000c00 ---[ end trace 0000000000000000 ]--- RIP: 0010:mlx5e_get_queue_stats_rx+0x3c/0xb0 [mlx5_core] Code: fc 55 48 63 ee 53 48 89 d3 e8 40 3d 70 e1 85 c0 74 58 4c 89 ef e8 d4 07 04 00 84 c0 75 41 49 8b 84 24 f8 39 00 00 48 8b 04 e8 <48> 8b 90 00 0c 00 00 48 03 90 40 0a 00 00 48 89 53 08 48 8b 90 08 RSP: 0018:ffff888116be37d0 EFLAGS: 00010246 RAX: 0000000000000000 RBX: ffff888116be3868 RCX: 0000000000000004 RDX: ffff88810ada4000 RSI: 0000000000000000 RDI: ffff888109df09c0 RBP: 0000000000000000 R08: 0000000000000004 R09: 0000000000000004 R10: ffff88813461901c R11: ffffffffffffffff R12: ffff888109df0000 R13: ffff888109df09c0 R14: ffff888116be38d0 R15: 0000000000000000 FS: 00007f4375d5c740(0000) GS:ffff88852c980000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000c00 CR3: 0000000106ada006 CR4: 0000000000370eb0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
--- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/en_main.c +4 -1
@@ -5296,7 +5296,7 @@ static void mlx5e_get_queue_stats_rx(struct net_device *dev, int i,struct mlx5e_rq_stats *rq_stats;ASSERT_RTNL (); -if (mlx5e_is_uplink_rep (priv)) +if (mlx5e_is_uplink_rep (priv) || !priv->stats_nch)return ; channel_stats = priv->channel_stats[i];
@@ -5316,6 +5316,9 @@ static void mlx5e_get_queue_stats_tx(struct net_device *dev, int i,struct mlx5e_sq_stats *sq_stats;ASSERT_RTNL (); +if (!priv->stats_nch) +return ; +/* no special case needed for ptp htb etc since txq2sq_stats is kept up * to date for active sq_stats, otherwise get_base_stats takes care of * inactive sqs.
Signature · 1 line
2.44.0
Re: [PATCH net 5/5] net/mlx5e: Fix queue stats access to non-existing channels splat
Quoted 5 lines · Tariq Toukan
From: Gal Pressman <[email protected]>
The queue stats API queries the queues according to the real_num_[tr]x_queues, in case the device is down and channels were not yet created, don't try to query their statistics.
[...]
Quoted 29 lines
--- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/net/ethernet/mellanox/mlx5/core/en_main.c +4
-1@@ -5296,7 +5296,7 @@ static void mlx5e_get_queue_stats_rx(struct net_device *dev, int i,struct mlx5e_rq_stats *rq_stats;ASSERT_RTNL (); -if (mlx5e_is_uplink_rep (priv)) +if (mlx5e_is_uplink_rep (priv) || !priv->stats_nch)return ; channel_stats = priv->channel_stats[i];@@ -5316,6 +5316,9 @@ static void mlx5e_get_queue_stats_tx(struct net_device *dev, int i,struct mlx5e_sq_stats *sq_stats;ASSERT_RTNL (); +if (!priv->stats_nch) +return ; +/* no special case needed for ptp htb etc since txq2sq_stats is kept up * to date for active sq_stats, otherwise get_base_stats takes care of * inactive sqs. Signature · 1 line
2.44.0
This series was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Thu, 8 Aug 2024 17:41:01 +0300 you wrote:
Hi,
This patchset provides misc bug fixes from the team to the mlx5 core and Eth drivers.
Series generated against:
commitb928e7d19dfd("Merge tag 'for-net-2024-08-07' ofgit://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth")[...]
Here is the summary with links:
- [net,1/5] net/mlx5: SD, Do not query MPIR register if no sd_group
https://git.kernel.org/netdev/net/c/c31fe2b5095d - [net,2/5] net/mlx5e: SHAMPO, Increase timeout to improve latency https://git.kernel.org/netdev/net/c/ab6013a59b4d - [net,3/5] net/mlx5e: Take state lock during tx timeout reporter https://git.kernel.org/netdev/net/c/e6b5afd30b99 - [net,4/5] net/mlx5e: Correctly report errors for ethtool rx flows https://git.kernel.org/netdev/net/c/cbc796be1779 - [net,5/5] net/mlx5e: Fix queue stats access to non-existing channels splat https://git.kernel.org/netdev/net/c/0b4a4534d083
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html