Skip to contentSkip to conversation

selftests/sched/Makefile: remove relative rpath usage

PATCH In review Eugene Syromiatnikov 2 participants 2 messages Aug 8, 2024 Kselftest

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/sched/Makefile: remove relative rpath usage

The relative RPATH ("./") supplied to linker options in CFLAGS is resolved relative to current working directory and not the executable directory, which will lead in incorrect resolution when the test executables are run from elsewhere. However, the sole sched test (cs_prctl_test) does not require any locally-built libraries to run, so the RPATH directive can be removed.

Discovered by the /usr/lib/rpm/check-rpaths script[1][2] that checks for insecure RPATH/RUNPATH[3], such as containing relative directories, during an attempt to package BPF selftests for later use in CI:

ERROR 0004: file '/usr/libexec/kselftests/bpf/urandom_read' contains an insecure runpath '.' in [.]

[1] https://github.com/rpm-software-management/rpm/blob/master/scripts/check-rpaths
[2] https://github.com/rpm-software-management/rpm/blob/master/scripts/check-rpaths-worker
[3] https://cwe.mitre.org/data/definitions/426.html

---
 tools/testing/selftests/sched/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tools/testing/selftests/sched/Makefile +1 -2
index 099ee9213557..0e4581ded9d6 100644
@@ -4,8 +4,7 @@ ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
 CLANG_FLAGS += -no-integrated-as
 endif
 
-CFLAGS += -O2 -Wall -g -I./ $(KHDR_INCLUDES) -Wl,-rpath=./ \
-	  $(CLANG_FLAGS)
+CFLAGS += -O2 -Wall -g -I./ $(KHDR_INCLUDES) $(CLANG_FLAGS)
 LDLIBS += -lpthread
 
 TEST_GEN_FILES := cs_prctl_test
Signature · 1 line
2.28.0
maintainer
#1 lore raw
Quoted 27 lines · Eugene Syromiatnikov

The relative RPATH ("./") supplied to linker options in CFLAGS is resolved relative to current working directory and not the executable directory, which will lead in incorrect resolution when the test executables are run from elsewhere. However, the sole sched test (cs_prctl_test) does not require any locally-built libraries to run, so the RPATH directive can be removed.

Discovered by the /usr/lib/rpm/check-rpaths script[1][2] that checks for insecure RPATH/RUNPATH[3], such as containing relative directories, during an attempt to package BPF selftests for later use in CI:

ERROR 0004: file '/usr/libexec/kselftests/bpf/urandom_read' contains an insecure runpath '.' in [.]

[1] https://github.com/rpm-software-management/rpm/blob/master/scripts/check-rpaths
[2] https://github.com/rpm-software-management/rpm/blob/master/scripts/check-rpaths-worker
[3] https://cwe.mitre.org/data/definitions/426.html

---
  tools/testing/selftests/sched/Makefile | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
tools/testing/selftests/sched/Makefile +0 -0
index 099ee9213557..0e4581ded9d6 100644

tools/testing/selftests/sched/Makefile ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),) · line 10

Quoted 9 lines
tools/testing/selftests/sched/Makefile +1 -2
@@ -4,8 +4,7 @@ ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
  CLANG_FLAGS += -no-integrated-as
  endif
 
-CFLAGS += -O2 -Wall -g -I./ $(KHDR_INCLUDES) -Wl,-rpath=./ \
-	  $(CLANG_FLAGS)
+CFLAGS += -O2 -Wall -g -I./ $(KHDR_INCLUDES) $(CLANG_FLAGS)
  LDLIBS += -lpthread
 
  TEST_GEN_FILES := cs_prctl_test

Wouldn't make sense to fix fix this in selftests main Makefile instead of changing the all the test makefiles

Same comment on all other files. It would be easier to send these as series - please mentioned the tests run as well after this change.

thanks,
-- Shuah