Skip to contentSkip to conversation

Removal of a few obsolete input drivers

RFC PATCH In review Dmitry Torokhov 3 participants 14 messages Aug 8, 2024 – Apr 8

Subsystems (2)
lore
Share & tools
lore

Dmitry Torokhov

author maintainer
#0 lore raw

cover Removal of a few obsolete input drivers

Hi,

I am wondering if it is not the time to retire bus mice drivers since they have been out of favor for close to 30 years, as well as 3 drivers for portables from late '90s to early 2000.

Please let me know what you think.

Thanks,
Dmitry

Dmitry Torokhov (5):
Input: inport - remove driver
Input: logibm - remove driver
Input: pc110pad - remove driver
Input: mk712 - remove driver
Input: ct82c710 - remove driver

 drivers/input/mouse/Kconfig        |  36 -----
 drivers/input/mouse/Makefile       |   3 -
 drivers/input/mouse/inport.c       | 177 ---------------------
 drivers/input/mouse/logibm.c       | 166 --------------------
 drivers/input/mouse/pc110pad.c     | 160 -------------------
 drivers/input/serio/Kconfig        |  13 --
 drivers/input/serio/Makefile       |   1 -
 drivers/input/serio/ct82c710.c     | 239 -----------------------------
 drivers/input/touchscreen/Kconfig  |  12 --
 drivers/input/touchscreen/Makefile |   1 -
 drivers/input/touchscreen/mk712.c  | 215 --------------------------
 11 files changed, 1023 deletions(-)
 delete mode 100644 drivers/input/mouse/inport.c
 delete mode 100644 drivers/input/mouse/logibm.c
 delete mode 100644 drivers/input/mouse/pc110pad.c
 delete mode 100644 drivers/input/serio/ct82c710.c
 delete mode 100644 drivers/input/touchscreen/mk712.c
Signature · 1 line
2.46.0.76.ge559c4bf1a-goog
author maintainer
#1 lore raw

RFC PATCH 1/5 Input: inport - remove driver

Inport (ATI XL and Microsoft) mice use specialized bus interface implemented via an ISA add-in card. Have been superseded by PS/2 and then USB, and are historical curiosity by now.

Remove the driver.

---
 drivers/input/mouse/Kconfig  |  16 ----
 drivers/input/mouse/Makefile |   1 -
 drivers/input/mouse/inport.c | 177 -----------------------------------
 3 files changed, 194 deletions(-)
 delete mode 100644 drivers/input/mouse/inport.c
drivers/input/mouse/Kconfig +0 -16
index 8a27a20d04b0..9c3102fa8e3c 100644
@@ -312,22 +312,6 @@ config MOUSE_ELAN_I2C_SMBUS
 
 	   If unsure, say Y.
 
-config MOUSE_INPORT
-	tristate "InPort/MS/ATIXL busmouse"
-	depends on ISA
-	help
-	  Say Y here if you have an InPort, Microsoft or ATI XL busmouse.
-	  They are rather rare these days.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called inport.
-
-config MOUSE_ATIXL
-	bool "ATI XL variant"
-	depends on MOUSE_INPORT
-	help
-	  Say Y here if your mouse is of the ATI XL variety.
-
 config MOUSE_LOGIBM
 	tristate "Logitech busmouse"
 	depends on ISA
drivers/input/mouse/Makefile +0 -1
index 563029551529..ef96db1fc945 100644
@@ -12,7 +12,6 @@ obj-$(CONFIG_MOUSE_BCM5974)		+= bcm5974.o
 obj-$(CONFIG_MOUSE_CYAPA)		+= cyapatp.o
 obj-$(CONFIG_MOUSE_ELAN_I2C)		+= elan_i2c.o
 obj-$(CONFIG_MOUSE_GPIO)		+= gpio_mouse.o
-obj-$(CONFIG_MOUSE_INPORT)		+= inport.o
 obj-$(CONFIG_MOUSE_LOGIBM)		+= logibm.o
 obj-$(CONFIG_MOUSE_MAPLE)		+= maplemouse.o
 obj-$(CONFIG_MOUSE_PC110PAD)		+= pc110pad.o
drivers/input/mouse/inport.c deleted +0 -177

177 lines not on this page · raw message

Signature · 1 line
2.46.0.76.ge559c4bf1a-goog
author maintainer
#2 lore raw

RFC PATCH 2/5 Input: logibm - remove driver

In reply to Dmitry Torokhov

Bus mice use specialized bus interface implemented via an ISA add-in cards. They were superseded by PS/2 and later USB.

Kconfig entry for the Logitech bus mice states that they "are rather rare these days". This statement was true in 2002 and is no less true in 2024.

Remove the driver.

---
 drivers/input/mouse/Kconfig  |  10 ---
 drivers/input/mouse/Makefile |   1 -
 drivers/input/mouse/logibm.c | 166 -----------------------------------
 3 files changed, 177 deletions(-)
 delete mode 100644 drivers/input/mouse/logibm.c
drivers/input/mouse/Kconfig +0 -10
index 9c3102fa8e3c..f660e6ba24c2 100644
@@ -312,16 +312,6 @@ config MOUSE_ELAN_I2C_SMBUS
 
 	   If unsure, say Y.
 
-config MOUSE_LOGIBM
-	tristate "Logitech busmouse"
-	depends on ISA
-	help
-	  Say Y here if you have a Logitech busmouse.
-	  They are rather rare these days.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called logibm.
-
 config MOUSE_PC110PAD
 	tristate "IBM PC110 touchpad"
 	depends on ISA
drivers/input/mouse/Makefile +0 -1
index ef96db1fc945..e745b64fed49 100644
@@ -12,7 +12,6 @@ obj-$(CONFIG_MOUSE_BCM5974)		+= bcm5974.o
 obj-$(CONFIG_MOUSE_CYAPA)		+= cyapatp.o
 obj-$(CONFIG_MOUSE_ELAN_I2C)		+= elan_i2c.o
 obj-$(CONFIG_MOUSE_GPIO)		+= gpio_mouse.o
-obj-$(CONFIG_MOUSE_LOGIBM)		+= logibm.o
 obj-$(CONFIG_MOUSE_MAPLE)		+= maplemouse.o
 obj-$(CONFIG_MOUSE_PC110PAD)		+= pc110pad.o
 obj-$(CONFIG_MOUSE_PS2)			+= psmouse.o
drivers/input/mouse/logibm.c deleted +0 -166

166 lines not on this page · raw message

Signature · 1 line
2.46.0.76.ge559c4bf1a-goog
author maintainer
#3 lore raw

RFC PATCH 3/5 Input: pc110pad - remove driver

In reply to Dmitry Torokhov

Palm Top PC 110 is a handheld personal computer with 80486SX CPU that was released exclusively in Japan in September 1995.

While the kernel still supports 486 CPU it is highly unlikely that anyone is using this device with the latest kernel.

Remove the driver.

---
 drivers/input/mouse/Kconfig    |  10 ---
 drivers/input/mouse/Makefile   |   1 -
 drivers/input/mouse/pc110pad.c | 160 ---------------------------------
 3 files changed, 171 deletions(-)
 delete mode 100644 drivers/input/mouse/pc110pad.c
drivers/input/mouse/Kconfig +0 -10
index f660e6ba24c2..7b7053c57588 100644
@@ -312,16 +312,6 @@ config MOUSE_ELAN_I2C_SMBUS
 
 	   If unsure, say Y.
 
-config MOUSE_PC110PAD
-	tristate "IBM PC110 touchpad"
-	depends on ISA
-	help
-	  Say Y if you have the IBM PC-110 micro-notebook and want its
-	  touchpad supported.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called pc110pad.
-
 config MOUSE_AMIGA
 	tristate "Amiga mouse"
 	depends on AMIGA
drivers/input/mouse/Makefile +0 -1
index e745b64fed49..4f9fb7d87a37 100644
@@ -13,7 +13,6 @@ obj-$(CONFIG_MOUSE_CYAPA)		+= cyapatp.o
 obj-$(CONFIG_MOUSE_ELAN_I2C)		+= elan_i2c.o
 obj-$(CONFIG_MOUSE_GPIO)		+= gpio_mouse.o
 obj-$(CONFIG_MOUSE_MAPLE)		+= maplemouse.o
-obj-$(CONFIG_MOUSE_PC110PAD)		+= pc110pad.o
 obj-$(CONFIG_MOUSE_PS2)			+= psmouse.o
 obj-$(CONFIG_MOUSE_RISCPC)		+= rpcmouse.o
 obj-$(CONFIG_MOUSE_SERIAL)		+= sermouse.o
drivers/input/mouse/pc110pad.c deleted +0 -160

160 lines not on this page · raw message

Signature · 1 line
2.46.0.76.ge559c4bf1a-goog
#4 lore raw

Re: [RFC PATCH 3/5] Input: pc110pad - remove driver

[+cc Maciej]

Quoted 9 lines · Dmitry Torokhov

Palm Top PC 110 is a handheld personal computer with 80486SX CPU that was released exclusively in Japan in September 1995.

While the kernel still supports 486 CPU it is highly unlikely that anyone is using this device with the latest kernel.

Remove the driver.

I applied this patch only to remove pc110pad to pci/enumeration for v7.1, since "x86/cpu: Remove M486/M486SX/ELAN support" has been queued for v7.1:
https://lore.kernel.org/all/[email protected]/

I put this in the PCI tree because pc110pad was the only user of no_pci_devices(), which we can now remove as well.

Quoted 209 lines
---
 drivers/input/mouse/Kconfig    |  10 ---
 drivers/input/mouse/Makefile   |   1 -
 drivers/input/mouse/pc110pad.c | 160 ---------------------------------
 3 files changed, 171 deletions(-)
 delete mode 100644 drivers/input/mouse/pc110pad.c
drivers/input/mouse/Kconfig +0 -10
index f660e6ba24c2..7b7053c57588 100644
@@ -312,16 +312,6 @@ config MOUSE_ELAN_I2C_SMBUS
 
 	   If unsure, say Y.
 
-config MOUSE_PC110PAD
-	tristate "IBM PC110 touchpad"
-	depends on ISA
-	help
-	  Say Y if you have the IBM PC-110 micro-notebook and want its
-	  touchpad supported.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called pc110pad.
-
 config MOUSE_AMIGA
 	tristate "Amiga mouse"
 	depends on AMIGA
drivers/input/mouse/Makefile +0 -1
index e745b64fed49..4f9fb7d87a37 100644
@@ -13,7 +13,6 @@ obj-$(CONFIG_MOUSE_CYAPA)		+= cyapatp.o
 obj-$(CONFIG_MOUSE_ELAN_I2C)		+= elan_i2c.o
 obj-$(CONFIG_MOUSE_GPIO)		+= gpio_mouse.o
 obj-$(CONFIG_MOUSE_MAPLE)		+= maplemouse.o
-obj-$(CONFIG_MOUSE_PC110PAD)		+= pc110pad.o
 obj-$(CONFIG_MOUSE_PS2)			+= psmouse.o
 obj-$(CONFIG_MOUSE_RISCPC)		+= rpcmouse.o
 obj-$(CONFIG_MOUSE_SERIAL)		+= sermouse.o
drivers/input/mouse/pc110pad.c deleted +0 -160
deleted file mode 100644
index efa58049f746..000000000000
@@ -1,160 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-/*
- *  Copyright (c) 2000-2001 Vojtech Pavlik
- *
- *  Based on the work of:
- *	Alan Cox	Robin O'Leary
- */
-
-/*
- * IBM PC110 touchpad driver for Linux
- */
-
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/errno.h>
-#include <linux/ioport.h>
-#include <linux/input.h>
-#include <linux/init.h>
-#include <linux/interrupt.h>
-#include <linux/pci.h>
-#include <linux/delay.h>
-
-#include <asm/io.h>
-#include <asm/irq.h>
-
-MODULE_AUTHOR("Vojtech Pavlik <[email protected]>");
-MODULE_DESCRIPTION("IBM PC110 touchpad driver");
-MODULE_LICENSE("GPL");
-
-#define PC110PAD_OFF	0x30
-#define PC110PAD_ON	0x38
-
-static int pc110pad_irq = 10;
-static int pc110pad_io = 0x15e0;
-
-static struct input_dev *pc110pad_dev;
-static int pc110pad_data[3];
-static int pc110pad_count;
-
-static irqreturn_t pc110pad_interrupt(int irq, void *ptr)
-{
-	int value     = inb_p(pc110pad_io);
-	int handshake = inb_p(pc110pad_io + 2);
-
-	outb(handshake |  1, pc110pad_io + 2);
-	udelay(2);
-	outb(handshake & ~1, pc110pad_io + 2);
-	udelay(2);
-	inb_p(0x64);
-
-	pc110pad_data[pc110pad_count++] = value;
-
-	if (pc110pad_count < 3)
-		return IRQ_HANDLED;
-
-	input_report_key(pc110pad_dev, BTN_TOUCH,
-		pc110pad_data[0] & 0x01);
-	input_report_abs(pc110pad_dev, ABS_X,
-		pc110pad_data[1] | ((pc110pad_data[0] << 3) & 0x80) | ((pc110pad_data[0] << 1) & 0x100));
-	input_report_abs(pc110pad_dev, ABS_Y,
-		pc110pad_data[2] | ((pc110pad_data[0] << 4) & 0x80));
-	input_sync(pc110pad_dev);
-
-	pc110pad_count = 0;
-	return IRQ_HANDLED;
-}
-
-static void pc110pad_close(struct input_dev *dev)
-{
-	outb(PC110PAD_OFF, pc110pad_io + 2);
-}
-
-static int pc110pad_open(struct input_dev *dev)
-{
-	pc110pad_interrupt(0, NULL);
-	pc110pad_interrupt(0, NULL);
-	pc110pad_interrupt(0, NULL);
-	outb(PC110PAD_ON, pc110pad_io + 2);
-	pc110pad_count = 0;
-
-	return 0;
-}
-
-/*
- * We try to avoid enabling the hardware if it's not
- * there, but we don't know how to test. But we do know
- * that the PC110 is not a PCI system. So if we find any
- * PCI devices in the machine, we don't have a PC110.
- */
-static int __init pc110pad_init(void)
-{
-	int err;
-
-	if (!no_pci_devices())
-		return -ENODEV;
-
-	if (!request_region(pc110pad_io, 4, "pc110pad")) {
-		printk(KERN_ERR "pc110pad: I/O area %#x-%#x in use.\n",
-				pc110pad_io, pc110pad_io + 4);
-		return -EBUSY;
-	}
-
-	outb(PC110PAD_OFF, pc110pad_io + 2);
-
-	if (request_irq(pc110pad_irq, pc110pad_interrupt, 0, "pc110pad", NULL)) {
-		printk(KERN_ERR "pc110pad: Unable to get irq %d.\n", pc110pad_irq);
-		err = -EBUSY;
-		goto err_release_region;
-	}
-
-	pc110pad_dev = input_allocate_device();
-	if (!pc110pad_dev) {
-		printk(KERN_ERR "pc110pad: Not enough memory.\n");
-		err = -ENOMEM;
-		goto err_free_irq;
-	}
-
-	pc110pad_dev->name = "IBM PC110 TouchPad";
-	pc110pad_dev->phys = "isa15e0/input0";
-	pc110pad_dev->id.bustype = BUS_ISA;
-	pc110pad_dev->id.vendor = 0x0003;
-	pc110pad_dev->id.product = 0x0001;
-	pc110pad_dev->id.version = 0x0100;
-
-	pc110pad_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
-	pc110pad_dev->absbit[0] = BIT_MASK(ABS_X) | BIT_MASK(ABS_Y);
-	pc110pad_dev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
-
-	input_abs_set_max(pc110pad_dev, ABS_X, 0x1ff);
-	input_abs_set_max(pc110pad_dev, ABS_Y, 0x0ff);
-
-	pc110pad_dev->open = pc110pad_open;
-	pc110pad_dev->close = pc110pad_close;
-
-	err = input_register_device(pc110pad_dev);
-	if (err)
-		goto err_free_dev;
-
-	return 0;
-
- err_free_dev:
-	input_free_device(pc110pad_dev);
- err_free_irq:
-	free_irq(pc110pad_irq, NULL);
- err_release_region:
-	release_region(pc110pad_io, 4);
-
-	return err;
-}
-
-static void __exit pc110pad_exit(void)
-{
-	outb(PC110PAD_OFF, pc110pad_io + 2);
-	free_irq(pc110pad_irq, NULL);
-	input_unregister_device(pc110pad_dev);
-	release_region(pc110pad_io, 4);
-}
-
-module_init(pc110pad_init);
-module_exit(pc110pad_exit);
Signature · 1 line
2.46.0.76.ge559c4bf1a-goog
author maintainer
#5 lore raw

Re: [RFC PATCH 3/5] Input: pc110pad - remove driver

Quoted 13 lines · Bjorn Helgaas

[+cc Maciej]

Quoted 9 lines · Dmitry Torokhov

Palm Top PC 110 is a handheld personal computer with 80486SX CPU that was released exclusively in Japan in September 1995.

While the kernel still supports 486 CPU it is highly unlikely that anyone is using this device with the latest kernel.

Remove the driver.

Quoted 7 lines

I applied this patch only to remove pc110pad to pci/enumeration for v7.1, since "x86/cpu: Remove M486/M486SX/ELAN support" has been queued for v7.1:
https://lore.kernel.org/all/[email protected]/

I put this in the PCI tree because pc110pad was the only user of no_pci_devices(), which we can now remove as well.

And I am going to apply the rest of the series. They are really simply a historical curiosity now.

Thanks.

Signature · 1 line
Dmitry
author maintainer
#6 lore raw

RFC PATCH 4/5 Input: mk712 - remove driver

In reply to Dmitry Torokhov

This touchscreen controller was used om Gateway AOL Connected Touchpad released in 2000 and, according to Wikipedia, removed from the market in October 2001 due to slow sales.

It looks like it can still be bought on eBay for $1000 but I really doubt anyone will actually use it.

Remove the driver.

---
 drivers/input/touchscreen/Kconfig  |  12 --
 drivers/input/touchscreen/Makefile |   1 -
 drivers/input/touchscreen/mk712.c  | 215 -----------------------------
 3 files changed, 228 deletions(-)
 delete mode 100644 drivers/input/touchscreen/mk712.c
drivers/input/touchscreen/Kconfig +0 -12
index 1ac26fc2e3eb..4685660faaf6 100644
@@ -687,18 +687,6 @@ config TOUCHSCREEN_INEXIO
 	  To compile this driver as a module, choose M here: the
 	  module will be called inexio.
 
-config TOUCHSCREEN_MK712
-	tristate "ICS MicroClock MK712 touchscreen"
-	depends on ISA
-	help
-	  Say Y here if you have the ICS MicroClock MK712 touchscreen
-	  controller chip in your system.
-
-	  If unsure, say N.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called mk712.
-
 config TOUCHSCREEN_HP600
 	tristate "HP Jornada 6xx touchscreen"
 	depends on SH_HP6XX && SH_ADC
drivers/input/touchscreen/Makefile +0 -1
index 82bc837ca01e..23d19ba7dc6e 100644
@@ -65,7 +65,6 @@ obj-$(CONFIG_TOUCHSCREEN_MIGOR)		+= migor_ts.o
 obj-$(CONFIG_TOUCHSCREEN_MMS114)	+= mms114.o
 obj-$(CONFIG_TOUCHSCREEN_MSG2638)	+= msg2638.o
 obj-$(CONFIG_TOUCHSCREEN_MTOUCH)	+= mtouch.o
-obj-$(CONFIG_TOUCHSCREEN_MK712)		+= mk712.o
 obj-$(CONFIG_TOUCHSCREEN_NOVATEK_NVT_TS)	+= novatek-nvt-ts.o
 obj-$(CONFIG_TOUCHSCREEN_HP600)		+= hp680_ts_input.o
 obj-$(CONFIG_TOUCHSCREEN_HP7XX)		+= jornada720_ts.o
drivers/input/touchscreen/mk712.c deleted +0 -215

215 lines not on this page · raw message

Signature · 1 line
2.46.0.76.ge559c4bf1a-goog
author maintainer
#7 lore raw

RFC PATCH 5/5 Input: ct82c710 - remove driver

In reply to Dmitry Torokhov

This is a PS/2 mouse interface chip from Chips & Technologies that was used in TI TravelMate and Gateway Nomad laptops, which used 386 and 486 CPUs. While the kernel still supports 486 CPU it is highly unlikely that anyone is using these devices with the latest kernel.

Remove the driver.

---
 drivers/input/serio/Kconfig    |  13 --
 drivers/input/serio/Makefile   |   1 -
 drivers/input/serio/ct82c710.c | 239 ---------------------------------
 3 files changed, 253 deletions(-)
 delete mode 100644 drivers/input/serio/ct82c710.c
drivers/input/serio/Kconfig +0 -13
index 17edc1597446..cf449f7cbaa5 100644
@@ -55,19 +55,6 @@ config SERIO_SERPORT
 	  To compile this driver as a module, choose M here: the
 	  module will be called serport.
 
-config SERIO_CT82C710
-	tristate "ct82c710 Aux port controller"
-	depends on X86
-	help
-	  Say Y here if you have a Texas Instruments TravelMate notebook
-	  equipped with the ct82c710 chip and want to use a mouse connected
-	  to the "QuickPort".
-
-	  If unsure, say N.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called ct82c710.
-
 config SERIO_Q40KBD
 	tristate "Q40 keyboard controller"
 	depends on Q40
drivers/input/serio/Makefile +0 -1
index 6d97bad7b844..8ab98f4aa28d 100644
@@ -9,7 +9,6 @@ obj-$(CONFIG_SERIO)		+= serio.o
 obj-$(CONFIG_SERIO_I8042)	+= i8042.o
 obj-$(CONFIG_SERIO_PARKBD)	+= parkbd.o
 obj-$(CONFIG_SERIO_SERPORT)	+= serport.o
-obj-$(CONFIG_SERIO_CT82C710)	+= ct82c710.o
 obj-$(CONFIG_SERIO_RPCKBD)	+= rpckbd.o
 obj-$(CONFIG_SERIO_SA1111)	+= sa1111ps2.o
 obj-$(CONFIG_SERIO_AMBAKMI)	+= ambakmi.o
drivers/input/serio/ct82c710.c deleted +0 -239

239 lines not on this page · raw message

Signature · 1 line
2.46.0.76.ge559c4bf1a-goog
#8 lore raw
In reply to Dmitry Torokhov
Quoted 3 lines · Dmitry Torokhov

I am wondering if it is not the time to retire bus mice drivers since they have been out of favor for close to 30 years, as well as 3 drivers for portables from late '90s to early 2000.

Are these drivers broken, e.g. fail to compile or crash the system?
Otherwise what's the gain from removal?

Maciej

author maintainer
#9 lore raw
Quoted 7 lines · Maciej W. Rozycki
Quoted 3 lines · Dmitry Torokhov

I am wondering if it is not the time to retire bus mice drivers since they have been out of favor for close to 30 years, as well as 3 drivers for portables from late '90s to early 2000.

Are these drivers broken, e.g. fail to compile or crash the system?

I have no idea because I doubt that anyone has tested them since forever.

Quoted 1 line

Otherwise what's the gain from removal?

The same gain that we get from removing obsolete boards and architectures - less maintenance burden, less work when we need to change some APIs, less energy burnt by 0-day and other bots, CI systems, etc, compiling useless drivers over and over and over.

Thanks.

Signature · 1 line
Dmitry
#10 lore raw
Quoted 8 lines · Dmitry Torokhov
Quoted 5 lines
Quoted 3 lines

I am wondering if it is not the time to retire bus mice drivers since they have been out of favor for close to 30 years, as well as 3 drivers for portables from late '90s to early 2000.

Are these drivers broken, e.g. fail to compile or crash the system?

I have no idea because I doubt that anyone has tested them since forever.

What's the rationale for your conclusion? How do you know nobody uses
them?

Quoted 6 lines
Quoted 1 line

Otherwise what's the gain from removal?

The same gain that we get from removing obsolete boards and architectures - less maintenance burden, less work when we need to change some APIs, less energy burnt by 0-day and other bots, CI systems, etc, compiling useless drivers over and over and over.

Well, you don't have do do anything about these drivers, do you? They
don't scream for food. And as to the energy, well I doubt this really matters, the amount is noise lost in the overall consumption.

Maciej

author maintainer
#11 lore raw
Quoted 6 lines · Maciej W. Rozycki
Quoted 4 lines · Dmitry Torokhov
Quoted 4 lines
Quoted 3 lines

I am wondering if it is not the time to retire bus mice drivers since they have been out of favor for close to 30 years, as well as 3 drivers for portables from late '90s to early 2000.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Are these drivers broken, e.g. fail to compile or crash the system?

I have no idea because I doubt that anyone has tested them since forever.

What's the rationale for your conclusion? How do you know nobody uses
them?

Because they are either require ISA add-on cards and it is quite hard to find devices that still work, and are supported by the current kernel, or internal peripherals in devices that are no longer useful. Do you expect anyone using "Gateway AOL Connected Touchpad" in the year of our Lord 2024?

Quoted 11 lines
Quoted 7 lines
Quoted 2 lines

Otherwise what's the gain from removal?

The same gain that we get from removing obsolete boards and architectures - less maintenance burden, less work when we need to change some APIs, less energy burnt by 0-day and other bots, CI systems, etc, compiling useless drivers over and over and over.

Well, you don't have do do anything about these drivers, do you? They
don't scream for food. And as to the energy, well I doubt this really matters, the amount is noise lost in the overall consumption.

I kind of do even if they did not require much involvement.

Let me ask this: why do you want to keep them? Do you know of a large (or small) userbase of bus mice enthusiasts? Note that it would be very easy to "git revert" the removal if someone actually needs this.

Thanks.

Signature · 1 line
Dmitry
#12 lore raw
Quoted 5 lines · Dmitry Torokhov
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

Are these drivers broken, e.g. fail to compile or crash the system?

I have no idea because I doubt that anyone has tested them since forever.

Quoted 8 lines
Quoted 2 lines

What's the rationale for your conclusion? How do you know nobody uses
them?

Because they are either require ISA add-on cards and it is quite hard to find devices that still work, and are supported by the current kernel, or internal peripherals in devices that are no longer useful. Do you expect anyone using "Gateway AOL Connected Touchpad" in the year of our Lord 2024?

Maybe, maybe not.

I certainly use Linux with actual ISA hardware, i.e. systems with ISA or
EISA slots and option cards within, as well as other hardware dating back to 1989. I'm told people use Linux with m68k hardware going back in time even further. I don't use any of the bus mice themselves though (having had perhaps a more common serial mouse instead), but if the drivers build just fine, then I fail to see a reason to dump them.

Quoted 9 lines
Quoted 8 lines
Quoted 4 lines

The same gain that we get from removing obsolete boards and architectures - less maintenance burden, less work when we need to change some APIs, less energy burnt by 0-day and other bots, CI systems, etc, compiling useless drivers over and over and over.

Well, you don't have do do anything about these drivers, do you? They
don't scream for food. And as to the energy, well I doubt this really matters, the amount is noise lost in the overall consumption.

Quoted 5 lines

I kind of do even if they did not require much involvement.

Let me ask this: why do you want to keep them? Do you know of a large (or small) userbase of bus mice enthusiasts? Note that it would be very easy to "git revert" the removal if someone actually needs this.

There is burden involved as well as repo clutter from going through an
apply/revert cycle though.

Sometimes we do want to discard code, because it causes burden elsewhere.
It was the case with the removal of support for the original 80386 CPU due to its lack of user page write-protection in the kernel mode, which in turn required us to have explicit checks carefully sprinkled throughout and painfully maintained. That hindered generic code and was a good argument in favour to removal as soon as 80386 became unimportant enough.

In this case the decision seems arbitrary, the presence of these drivers
does not hurt anything else. I agree it might well be that nobody uses them anymore (though someone may come across a relevant piece of hardware anytime and wish to try it with Linux; I do it from time to time, and I also have old stuff even I'd like to write entirely new drivers for if I ever find some time for that, i.e. I have sorted higher priority stuff), which I can sort of recognise as an argument in favour of discarding them.

I'm not entirely convinced it's enough of an argument by itself, however
if there are other people who think otherwise, can we please at least do it in stages such as some other projects do? That is require an explicit action for any interested party to keep the drivers enabled, say by hiding them behind CONFIG_DEPRECATED or suchlike (with clear documentation saying it's for stuff slated for removal), wait a year or two, and only if nobody speaks out during that period, then actually retire the code in question?

A part of the joy with Linux for me and I believe other people as well it
has been the ability to do odd stuff just for the sake of it. It used not to be business back in 1990s and it still not is, not at least entirely, for such a Linux old-timer as I have now oddly enough become.

Maciej

author maintainer
#13 lore raw
Quoted 16 lines · Maciej W. Rozycki
Quoted 5 lines · Dmitry Torokhov
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

Are these drivers broken, e.g. fail to compile or crash the system?

I have no idea because I doubt that anyone has tested them since forever.

Quoted 8 lines
Quoted 2 lines

What's the rationale for your conclusion? How do you know nobody uses
them?

Because they are either require ISA add-on cards and it is quite hard to find devices that still work, and are supported by the current kernel, or internal peripherals in devices that are no longer useful. Do you expect anyone using "Gateway AOL Connected Touchpad" in the year of our Lord 2024?

Quoted 8 lines

Maybe, maybe not.

I certainly use Linux with actual ISA hardware, i.e. systems with ISA or
EISA slots and option cards within, as well as other hardware dating back to 1989. I'm told people use Linux with m68k hardware going back in time even further. I don't use any of the bus mice themselves though (having had perhaps a more common serial mouse instead), but if the drivers build just fine, then I fail to see a reason to dump them.

OK, so here is an example:

https://lore.kernel.org/all/20241010194533.GA575181@bhelgaas/

We need to cleanup PCI core and the driver uses a hack. So we need to patch it.

Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
Quoted 5 lines

The same gain that we get from removing obsolete boards and architectures - less maintenance burden, less work when we need to change some APIs, less energy burnt by 0-day and other bots, CI systems, etc, compiling useless drivers over and over and over.

Well, you don't have do do anything about these drivers, do you? They
don't scream for food. And as to the energy, well I doubt this really matters, the amount is noise lost in the overall consumption.

Quoted 8 lines
Quoted 5 lines

I kind of do even if they did not require much involvement.

Let me ask this: why do you want to keep them? Do you know of a large (or small) userbase of bus mice enthusiasts? Note that it would be very easy to "git revert" the removal if someone actually needs this.

There is burden involved as well as repo clutter from going through an
apply/revert cycle though.

You are assuming that somebody actually needs them and will have to restore them.

Quoted 16 lines

Sometimes we do want to discard code, because it causes burden elsewhere.
It was the case with the removal of support for the original 80386 CPU due to its lack of user page write-protection in the kernel mode, which in turn required us to have explicit checks carefully sprinkled throughout and painfully maintained. That hindered generic code and was a good argument in favour to removal as soon as 80386 became unimportant enough.

In this case the decision seems arbitrary, the presence of these drivers
does not hurt anything else. I agree it might well be that nobody uses them anymore (though someone may come across a relevant piece of hardware anytime and wish to try it with Linux; I do it from time to time, and I also have old stuff even I'd like to write entirely new drivers for if I ever find some time for that, i.e. I have sorted higher priority stuff), which I can sort of recognise as an argument in favour of discarding them.

Quoted 7 lines

I'm not entirely convinced it's enough of an argument by itself, however
if there are other people who think otherwise, can we please at least do it in stages such as some other projects do? That is require an explicit action for any interested party to keep the drivers enabled, say by hiding them behind CONFIG_DEPRECATED or suchlike (with clear documentation saying it's for stuff slated for removal), wait a year or two, and only if nobody speaks out during that period, then actually retire the code in question?

I do not see how CONFIG_DEPRECATED help any better than revert. The driver will disappear, people will start looking for it and will complain on Linux Input/LKML. At which point we will revert either the config change or driver removal patch.

If the argument that with config someone does not need git tree but rather can work with a tarball I say I really do not care for this case.

Quoted 5 lines

A part of the joy with Linux for me and I believe other people as well it
has been the ability to do odd stuff just for the sake of it. It used not to be business back in 1990s and it still not is, not at least entirely, for such a Linux old-timer as I have now oddly enough become.

We are still willing to support old hardware, but only when it is actually used.

Thanks.

Signature · 1 line
Dmitry