usb: chipidea: Use of_property_present()
PATCH 1/1 usb: chipidea: Use of_property_present()
Use of_property_present() to test for property presence rather than of_get_property(). This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.
Signed-off-by Rob Herring (Arm) <[email protected]>
--- drivers/usb/chipidea/ci_hdrc_imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/chipidea/ci_hdrc_imx.c +1 -1
@@ -128,7 +128,7 @@ static struct imx_usbmisc_data *usbmisc_get_init_data(struct device *dev)* In case the fsl,usbmisc property is not present this device doesn't * need usbmisc. Return NULL (which is no error here) */ -if (!of_get_property (np,"fsl,usbmisc" ,NULL )) +if (!of_property_present (np,"fsl,usbmisc" ))return NULL ; data =devm_kzalloc (dev,sizeof (*data),GFP_KERNEL );
Signature · 1 line
2.43.0
Quoted 7 lines · Rob Herring (Arm)
Use
of_property_present()to test for property presence rather thanof_get_property(). This is part of a larger effort to remove callers ofof_get_property()and similar functions.of_get_property()leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.Signed-off-by Rob Herring (Arm) <[email protected]>
Acked-by Peter Chen <[email protected]>
Quoted 20 lines
--- drivers/usb/chipidea/ci_hdrc_imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/chipidea/ci_hdrc_imx.c +1
-1@@ -128,7 +128,7 @@ static struct imx_usbmisc_data *usbmisc_get_init_data(struct device *dev)* In case the fsl,usbmisc property is not present this device doesn't * need usbmisc. Return NULL (which is no error here) */ -if (!of_get_property (np,"fsl,usbmisc" ,NULL )) +if (!of_property_present (np,"fsl,usbmisc" ))return NULL ; data =devm_kzalloc (dev,sizeof (*data),GFP_KERNEL );Signature · 1 line
2.43.0