Skip to contentSkip to conversation

drm/vmwgfx: Handle possible ENOMEM in vmw_stdu_connector_atomic_check

PATCH In review Ian Forbes 3 participants 3 messages Aug 9, 2024 – Aug 19, 2024

Subsystems (3)
lore
Share & tools
lore

Ian Forbes

author
#0 lore raw

PATCH 1/1 drm/vmwgfx: Handle possible ENOMEM in vmw_stdu_connector_atomic_check

Handle unlikely ENOMEN condition and other errors in vmw_stdu_connector_atomic_check.

Fixes 75c3e8a26a35 ("drm/vmwgfx: Trigger a modeset when the screen moves")
---
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c +4 -0
index 571e157fe22e9..3223fd278a598 100644
@@ -886,6 +886,10 @@ static int vmw_stdu_connector_atomic_check(struct drm_connector *conn,
 	struct drm_crtc_state *new_crtc_state;
 
 	conn_state = drm_atomic_get_connector_state(state, conn);
+
+	if (IS_ERR(conn_state))
+		return PTR_ERR(conn_state);
+
 	du = vmw_connector_to_stdu(conn);
 
 	if (!conn_state->crtc)
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · Ian Forbes

Handle unlikely ENOMEN condition and other errors in vmw_stdu_connector_atomic_check.

Fixes 75c3e8a26a35 ("drm/vmwgfx: Trigger a modeset when the screen moves")
---
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c +4 -1
index 571e157fe22e9..3223fd278a598 100644
@@ -886,6 +886,10 @@ static int vmw_stdu_connector_atomic_check(struct drm_connector *conn,
        struct drm_crtc_state *new_crtc_state;
 
        conn_state = drm_atomic_get_connector_state(state, conn);
+
+       if (IS_ERR(conn_state))
+               return PTR_ERR(conn_state);
+
        du = vmw_connector_to_stdu(conn);
 
        if (!conn_state->crtc)
--
Quoted 2 lines

2.34.1

z

Reviewed-by on v1 1/1
#2 lore raw
In reply to Ian Forbes

LGTM.

Regards,
Martin

Quoted 29 lines · Ian Forbes

Handle unlikely ENOMEN condition and other errors in vmw_stdu_connector_atomic_check.

Fixes 75c3e8a26a35 ("drm/vmwgfx: Trigger a modeset when the screen moves")
---
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c +4 -1
index 571e157fe22e9..3223fd278a598 100644
@@ -886,6 +886,10 @@ static int vmw_stdu_connector_atomic_check(struct drm_connector *conn,
        struct drm_crtc_state *new_crtc_state;
 
        conn_state = drm_atomic_get_connector_state(state, conn);
+
+       if (IS_ERR(conn_state))
+               return PTR_ERR(conn_state);
+
        du = vmw_connector_to_stdu(conn);
 
        if (!conn_state->crtc)
--

2.34.1