ubifs: Call ubifs_iput when ubifs_iget is used
PATCH v2 1/1 ubifs: Call ubifs_iput when ubifs_iget is used
The inode should be freed after a reference is get to avoid memory leak
---V1->V2:
- fix compilation problem on super.cRFC->V1:
- Heiko gives more points to address on the patch and review it
- Alexander Dahl test on top of his own series reported in the commit message
- add leak on super.c file too from Heiko
--- fs/ubifs/super.c | 1 + fs/ubifs/ubifs.c | 9 ++++++--- 2 files changed, 7 insertions(+), 3 deletions(-)
fs/ubifs/super.c +1 -0
@@ -2321,6 +2321,7 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent) goto out_umount; }#else +ubifs_iput (root); sb->s_root =NULL ;#endif
fs/ubifs/ubifs.c +6 -3
@@ -319,9 +319,7 @@ static int filldir(struct ubifs_info *c, const char *name, int namlen, }ctime_r ((time_t *)&inode->i_mtime, filetime);printf ("%9lld %24.24s " , inode->i_size, filetime); -#ifndef __UBOOT__ubifs_iput (inode); -#endif printf ("%s\n" , name);
@@ -557,6 +555,7 @@ static unsigned long ubifs_findfile(struct super_block *sb, char *filename)/* We have some sort of symlink recursion, bail out */ if (symlink_count++ >8 ) { +ubifs_iput (inode);printf ("Symlink recursion, aborting\n" );return 0 ; }
@@ -568,6 +567,7 @@ static unsigned long ubifs_findfile(struct super_block *sb, char *filename)* the leading slash */ next = name = link_name +1 ; root_inum =1 ; +ubifs_iput (inode);continue ; }/* Relative to cur dir */
@@ -575,6 +575,7 @@ static unsigned long ubifs_findfile(struct super_block *sb, char *filename) link_name, next == NULL ? "" : next);memcpy (symlinkpath, buf,sizeof (buf)); next = name = symlinkpath; +ubifs_iput (inode);continue ; }
@@ -583,8 +584,10 @@ static unsigned long ubifs_findfile(struct super_block *sb, char *filename)*/ /* Found the node! */ -if (!next || *next =='\0' ) +if (!next || *next =='\0' ) { +ubifs_iput (inode);return inum; + } root_inum = inum; name = next;
Signature · 1 line
2.43.0
Hello Micahel,
Quoted 16 lines · Michael Trimarchi
The inode should be freed after a reference is get to avoid memory leak
Tested-by Alexander Dahl <[email protected]>Co-Developed-by Heiko Schocher <[email protected]>Signed-off-by Michael Trimarchi <[email protected]>---
V1->V2:
- fix compilation problem onsuper.cRFC->V1:
- Heiko gives more points to address on the patch and review it
- Alexander Dahl test on top of his own series reported in the commit message
- add leak onsuper.cfile too from Heiko
Quoted 4 lines
--- fs/ubifs/super.c | 1 + fs/ubifs/ubifs.c | 9 ++++++--- 2 files changed, 7 insertions(+), 3 deletions(-)
Thanks!
I get:
WARNING: 'Co-developed-by:' is the preferred signature form #126:
Fixed this when I applied the patch, hope this is okay for you! Azure build started.
bye,
Heiko
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]