Skip to contentSkip to conversation

fwupd: skip buildpaths errors

PATCH In review Armin Kuster 2 participants 8 messages Aug 10, 2024 – Aug 30, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/7 fwupd: skip buildpaths errors

From: Mikko Rapeli <[email protected]>

Test binaries are embeddding build paths and can't easily figure out why. Thus ignore the errors in these binaries for now.

(cherry picked from commit e77f9f2feb6b9b9c86e3d815415e4bb521444538)
---
 meta-oe/recipes-bsp/fwupd/fwupd_1.9.18.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-bsp/fwupd/fwupd_1.9.18.bb +2 -0
index e6c276ba4e..a98ed67f76 100644
@@ -140,3 +140,5 @@ FILES:${PN} += "${libdir}/fwupd-plugins-* \
 FILES:${PN}-ptest += "${libexecdir}/installed-tests/ \
                       ${datadir}/installed-tests/"
 RDEPENDS:${PN}-ptest += "gnome-desktop-testing"
+
+INSANE_SKIP:${PN}-ptest += "buildpaths"
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/7 gcab: ignore buildpaths error from sources

From: Mikko Rapeli <[email protected]>

gcab-src has some meson generated files which embed absolute paths from build environment. meson seems ot do this on purpose to fix other issues.

Ignored those issues for now.

(cherry picked from commit db91757e7bd98494666ca00bc7727a7607b6004f)
---
 meta-oe/recipes-gnome/gcab/gcab_1.6.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-gnome/gcab/gcab_1.6.bb +3 -0
index 4278fc9453..49c64f0ba6 100644
@@ -22,3 +22,6 @@ PACKAGECONFIG[nls] = "-Dnls=true,-Dnls=false"
 PACKAGECONFIG[tests] = "-Dtests=true -Dinstalled_tests=true,-Dtests=false -Dinstalled_tests=false"
 
 BBCLASSEXTEND = "native"
+
+# meson embeds absolute paths to generated files on purpose
+INSANE_SKIP:gcab-src += "buildpaths"
Signature · 1 line
2.34.1
#2 lore raw

Re: [oe] [meta-oe][scarthgap][PATCH 2/7] gcab: ignore buildpaths error from sources

This doesn't work with multilib where the package is named ${PN}-src (e.g. lib32-gcab-src) and it's better to just lower buildpaths from ERROR_QA to WARN_QA instead of skipping it completely, because it's still an issue which should be fixed (at least to improve hashserv efficiency if you don't care about reproducibility itself)

Why was this even backported to scarthgap where buildpaths QA issues aren't fatal?

Quoted 40 lines · Armin Kuster via lists.openembedded.org

From: Mikko Rapeli <[email protected]>

gcab-src has some meson generated files which embed absolute paths from build environment. meson seems ot do this on purpose to fix other issues.

Ignored those issues for now.

(cherry picked from commit db91757e7bd98494666ca00bc7727a7607b6004f)
---
 meta-oe/recipes-gnome/gcab/gcab_1.6.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-gnome/gcab/gcab_1.6.bb +3 -1
index 4278fc9453..49c64f0ba6 100644
@@ -22,3 +22,6 @@ PACKAGECONFIG[nls] = "-Dnls=true,-Dnls=false"
 PACKAGECONFIG[tests] = "-Dtests=true -Dinstalled_tests=true,-Dtests=false -Dinstalled_tests=false"
 
 BBCLASSEXTEND = "native"
+
+# meson embeds absolute paths to generated files on purpose
+INSANE_SKIP:gcab-src += "buildpaths"
--

2.34.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#111739): https://lists.openembedded.org/g/openembedded-devel/message/111739
Mute This Topic: https://lists.openembedded.org/mt/107826456/3617156
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw

PATCH 3/7 libjcat: skip buildpaths check

In reply to Armin Kuster

From: Mikko Rapeli <[email protected]>

Test binary has embedded build time paths. Ignore
for now.

(cherry picked from commit e02e22063433adb1b4fbba562f9efd6e68941309)
---
 meta-oe/recipes-gnome/libjcat/libjcat_0.2.1.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-gnome/libjcat/libjcat_0.2.1.bb +2 -0
index 2d95e14447..7dc88d7279 100644
@@ -32,3 +32,5 @@ GTKDOC_MESON_OPTION = "gtkdoc"
 RDEPENDS:${PN}:class-target = "\
     ${@bb.utils.contains('PACKAGECONFIG', 'gpg', 'gnupg', '', d)} \
 "
+
+INSANE_SKIP:${PN}-ptest += "buildpaths"
Signature · 1 line
2.34.1
#4 lore raw

PATCH 4/7 znc: Fix buildpaths QA errors

In reply to Armin Kuster

From: "J. S." <[email protected]>

(cherry picked from commit 28d77dddad1c86ac5771859e59504e662eb68813)
---
 meta-networking/recipes-irc/znc/znc_1.8.2.bb | 1 +
 1 file changed, 1 insertion(+)
meta-networking/recipes-irc/znc/znc_1.8.2.bb +1 -0
index 1517384eca..68dd0702f7 100644
@@ -29,4 +29,5 @@ do_configure:prepend() {
 
 do_install:append() {
     sed -i -e 's|${DEBUG_PREFIX_MAP}||g; s|--sysroot=${STAGING_DIR_TARGET}||g' ${D}${libdir}/pkgconfig/*.pc
+    sed -i -e 's|${DEBUG_PREFIX_MAP}||g; s|--sysroot=${STAGING_DIR_TARGET}||g' ${D}${bindir}/znc-buildmod
 }
Signature · 1 line
2.34.1
#5 lore raw

PATCH 5/7 log4cpp: Fix buildpaths QA error

In reply to Armin Kuster

From: Khem Raj <[email protected]>

Fixes
do_package_qa: QA Issue: File /usr/bin/log4cpp-config in package log4cpp contains reference to TMPDIR [buildpaths]

(cherry picked from commit 78a69186be5db3f6995101e0f94a1d11e1155421)
---
 meta-oe/recipes-support/log4cpp/log4cpp_1.1.4.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta-oe/recipes-support/log4cpp/log4cpp_1.1.4.bb +4 -0
index 729857eb62..a8b9b9a019 100644
@@ -20,3 +20,7 @@ EXTRA_OECONF = "\
 "
 
 CXXFLAGS += "-std=c++14"
+
+do_install:append() {
+	sed -i -e 's|${DEBUG_PREFIX_MAP}||g; s|--sysroot=${STAGING_DIR_TARGET}||g' ${D}${bindir}/log4cpp-config
+}
Signature · 1 line
2.34.1
#6 lore raw

PATCH 6/7 tayga: Fix contains reference to TMPDIR [buildpaths] warning

In reply to Armin Kuster

From: alperak <[email protected]>

WARNING: tayga-0.9.2-r0 do_package_qa: QA Issue: File /usr/sbin/.debug/tayga in package tayga-dbg contains reference to TMPDIR [buildpaths]

Make sure that the OE provided CFLAGS are passed to the compiler.

(cherry picked from commit d1bf2db7cc2bcb8b6ac45bb382c3f2b6bb762053)
---
 meta-networking/recipes-connectivity/tayga/tayga_0.9.2.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-networking/recipes-connectivity/tayga/tayga_0.9.2.bb +3 -0
index 36d35e6dee..40dbccb840 100644
@@ -12,6 +12,8 @@ SRC_URI[sha256sum] = "2b1f7927a9d2dcff9095aff3c271924b052ccfd2faca9588b277431a44
 SYSTEMD_PACKAGES = "${PN}"
 SYSTEMD_SERVICE:${PN} = "tayga.service"
 
+EXTRA_OEMAKE += "CFLAGS='${CFLAGS}'"
+
 do_install:append() {
   install -m 0644 ${WORKDIR}/tayga.conf ${D}${sysconfdir}/tayga.conf
   install -d ${D}${systemd_unitdir}/system/
@@ -19,3 +21,4 @@ do_install:append() {
 }
 
 inherit autotools systemd
+
Signature · 1 line
2.34.1
#7 lore raw

PATCH 7/7 etcd-cpp-apiv3: Fix contains reference to TMPDIR [buildpaths] warning

In reply to Armin Kuster

From: alperak <[email protected]>

WARNING: etcd-cpp-apiv3-0.15.4-r0 do_package_qa: QA Issue: File /usr/lib/cmake/etcd-cpp-api/etcd-targets.cmake in package etcd-cpp-apiv3-dev contains reference to TMPDIR [buildpaths]

(cherry picked from commit a70cacd0c25dbeb641e364ecc0e28fc4b924e59b)
---
 meta-oe/recipes-extended/etcd/etcd-cpp-apiv3_0.15.3.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta-oe/recipes-extended/etcd/etcd-cpp-apiv3_0.15.3.bb +4 -0
index 401d53c79c..e6fe8af890 100644
@@ -19,5 +19,9 @@ S = "${WORKDIR}/git"
 
 EXTRA_OECONF += "-DCPPREST_EXCLUDE_WEBSOCKETS=ON"
 
+do_install:append() {
+	sed -i -e 's#${RECIPE_SYSROOT}##g' ${D}${libdir}/cmake/etcd-cpp-api/etcd-targets.cmake
+}
+
 SOLIBS = ".so"
 FILES_SOLIBSDEV = ""
Signature · 1 line
2.34.1