Add input voltage suppliers for PMIC MCP16502 regulators
Subsystems (4)
Andrei Simion
maintainerv2 cover Add input voltage suppliers for PMIC MCP16502 regulators
In this series of patches, support for the *-supply property [1] is added (correlated with supply_name [2]) from the core regulator.
Link [1]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L471
Link [2]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L2064
I modified the mcp16502.c driver and the dts that use this PMIC.
We added these improvements to provide a complete description of the board power scheme.
Snippet (as an example) from /sys/kernel/debug/regulator/regulator_summary (for at91-sama7g5ek):
# cat regulator_summary
regulator use open bypass opmode voltage current min max
---------------------------------------------------------------------------------------
regulator-dummy 1 0 0 unknown 0mV 0mA 0mV 0mV
5V_MAIN 6 6 0 unknown 5000mV 0mA 5000mV 5000mV
VDD_IO 5 4 0 normal 3300mV 0mA 3300mV 3300mV
e1208000.mmc-vqmmc 1 0mA 0mV 0mV
e1208000.mmc-vmmc 1 0mA 3300mV 3400mV
e1204000.mmc-vmmc 1 0mA 3300mV 3400mV
VDDOUT25 3 2 0 unknown 2500mV 0mA 2500mV 2500mV
e1000000.adc-vref 1 0mA 0mV 0mV
e1000000.adc-vddana 1 0mA 0mV 0mV
VDD_DDR 1 0 0 normal 1350mV 0mA 1350mV 1350mV
VDD_CORE 1 0 0 normal 1150mV 0mA 1150mV 1150mV
VDD_OTHER 2 1 0 normal 1050mV 0mA 1050mV 1250mV
cpu0-cpu 1 0mA 1050mV 1225mV
LDO1 2 1 0 unknown 1800mV 0mA 1800mV 1800mV
e1204000.mmc-vqmmc 1 0mA 0mV 0mV
LDO2-------------------------------------------------------------------------------------------
Changelog:
v1 -> v2:
- drop (lvin|pvin[1-4])-supply from each regulators sub-node
- add voltage input supply documentation in the yaml schema
- add lvin-supply, pvin[1-4]-supply to PMIC node
Andrei Simion (7):
regulator: mcp16502: Add supplier for regulators
regulator: dt-bindings: microchip,mcp16502: Add voltage input supply
documentation
ARM: dts: microchip: at91-sama7g5ek: Add reg_5v to supply PMIC nodes
ARM: dts: microchip: at91-sama7g54_curiosity: Add reg_5v to supply
PMIC nodes
ARM: dts: microchip: at91-sama5d2_icp: Add reg_5v to supply PMIC nodes
ARM: dts: microchip: at91-sama5d27_wlsom1: Add reg_5v to supply PMIC
nodes
ARM: dts: microchip: sama5d29_curiosity: Add reg_5v to supply PMIC
nodes
.../regulator/microchip,mcp16502.yaml | 20 +++++++++++++++++++ .../dts/microchip/at91-sama5d27_wlsom1.dtsi | 13 ++++++++++++ .../dts/microchip/at91-sama5d29_curiosity.dts | 13 ++++++++++++ .../boot/dts/microchip/at91-sama5d2_icp.dts | 13 ++++++++++++ .../dts/microchip/at91-sama7g54_curiosity.dts | 13 ++++++++++++ .../arm/boot/dts/microchip/at91-sama7g5ek.dts | 13 ++++++++++++ drivers/regulator/mcp16502.c | 17 ++++++++-------- 7 files changed, 94 insertions(+), 8 deletions(-)
base-commit: 9e6869691724b12e1f43655eeedc35fade38120c
Signature · 1 line
2.34.1
Andrei Simion
maintainerPATCH v2 1/7 regulator: mcp16502: Add supplier for regulators
Based on the datasheet [1] (Block Diagram) PVIN[1-4] and LVIN represent the input voltage supply for each BUCKs respective LDOs. Update the driver to align with the datasheet [1].
---
v1 -> v2:
- no update
--- drivers/regulator/mcp16502.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
drivers/regulator/mcp16502.c +9 -8
@@ -107,9 +107,10 @@ static unsigned int mcp16502_of_map_mode(unsigned int mode)return REGULATOR_MODE_INVALID ; } -#define MCP16502_REGULATOR (_name, _id, _ranges, _ops, _ramp_table) \ +#define MCP16502_REGULATOR (_name, _id, _sn, _ranges, _ops, _ramp_table) \ [_id] = { \ .name = _name, \ + .supply_name = #_sn, \ .regulators_node = "regulators", \ .id = _id, \ .ops = &(_ops), \
@@ -467,18 +468,18 @@ static const struct linear_range b234_ranges[] = { };static const struct regulator_desc mcp16502_desc[] = { -/* MCP16502_REGULATOR(_name, _id, ranges, regulator_ops, ramp_table) */ -MCP16502_REGULATOR ("VDD_IO" ,BUCK1 , b1l12_ranges, mcp16502_buck_ops, +/* MCP16502_REGULATOR(_name, _id, _sn, _ranges, _ops, _ramp_table) */ +MCP16502_REGULATOR ("VDD_IO" ,BUCK1 , pvin1, b1l12_ranges, mcp16502_buck_ops, mcp16502_ramp_b1l12), -MCP16502_REGULATOR ("VDD_DDR" ,BUCK2 , b234_ranges, mcp16502_buck_ops, +MCP16502_REGULATOR ("VDD_DDR" ,BUCK2 , pvin2, b234_ranges, mcp16502_buck_ops, mcp16502_ramp_b234), -MCP16502_REGULATOR ("VDD_CORE" ,BUCK3 , b234_ranges, mcp16502_buck_ops, +MCP16502_REGULATOR ("VDD_CORE" ,BUCK3 , pvin3, b234_ranges, mcp16502_buck_ops, mcp16502_ramp_b234), -MCP16502_REGULATOR ("VDD_OTHER" ,BUCK4 , b234_ranges, mcp16502_buck_ops, +MCP16502_REGULATOR ("VDD_OTHER" ,BUCK4 , pvin4, b234_ranges, mcp16502_buck_ops, mcp16502_ramp_b234), -MCP16502_REGULATOR ("LDO1" ,LDO1 , b1l12_ranges, mcp16502_ldo_ops, +MCP16502_REGULATOR ("LDO1" ,LDO1 , lvin, b1l12_ranges, mcp16502_ldo_ops, mcp16502_ramp_b1l12), -MCP16502_REGULATOR ("LDO2" ,LDO2 , b1l12_ranges, mcp16502_ldo_ops, +MCP16502_REGULATOR ("LDO2" ,LDO2 , lvin, b1l12_ranges, mcp16502_ldo_ops, mcp16502_ramp_b1l12) };
Signature · 1 line
2.34.1
Andrei Simion
maintainerPATCH v2 2/7 regulator: dt-bindings: microchip,mcp16502: Add voltage input supply documentation
In reply to Andrei SimionUpdate the yaml schema with info about input supply phandle for each buck and ldo according with the PMIC MCP16502 Datasheet.
---
v1 -> v2:
- added in v2
--- .../regulator/microchip,mcp16502.yaml | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)
Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml +20 -0
@@ -28,6 +28,21 @@ properties: reg: maxItems: 1 + lvin-supply: + description: Input supply phandle for LDO1 and LDO2 + + pvin1-supply: + description: Input supply phandle for VDD_IO (BUCK1) + + pvin2-supply: + description: Input supply phandle for VDD_DDR (BUCK2) + + pvin3-supply: + description: Input supply phandle for VDD_CORE (BUCK3) + + pvin4-supply: + description: Input supply phandle for VDD_OTHER (BUCK4) + regulators: type: object additionalProperties: false
@@ -68,6 +83,11 @@ examples: pmic@5b { compatible = "microchip,mcp16502"; reg = <0x5b>; + lvin-supply = <®_5v>; + pvin1-supply = <®_5v>; + pvin2-supply = <®_5v>; + pvin3-supply = <®_5v>; + pvin4-supply = <®_5v>; regulators { VDD_IO {
Signature · 1 line
2.34.1
Re: [PATCH v2 2/7] regulator: dt-bindings: microchip,mcp16502: Add voltage input supply documentation
Quoted 16 lines · Andrei Simion
Update the yaml schema with info about input supply phandle for each buck and ldo according with the PMIC MCP16502 Datasheet.
Signed-off-by Andrei Simion <[email protected]>---
v1 -> v2:
- added in v2--- .../regulator/microchip,mcp16502.yaml | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml +0
-0
Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml properties: · line 32
Quoted 5 lines
Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml +2
-0@@ -28,6 +28,21 @@ properties: reg: maxItems: 1 + lvin-supply: + description: Input supply phandle for LDO1 and LDO2
If there is going to be respin, drop phandle. Stating obvious is not helping - you describe here hardware, not DT.
Best regards,
Krzysztof
Andrei Simion
maintainerPATCH v2 3/7 ARM: dts: microchip: at91-sama7g5ek: Add reg_5v to supply PMIC nodes
In reply to Andrei SimionAlign with the datasheet by adding regulator-5v which supplies each node from the regulator using phandle to regulator-5v through pvin[1-4]-supply and lvin-supply.
---
v1 -> v2:
- drop (lvin|pvin[1-4])-supply from each regulators sub-node
- add lvin-supply, pvin[1-4]-supply to PMIC node
--- arch/arm/boot/dts/microchip/at91-sama7g5ek.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm/boot/dts/microchip/at91-sama7g5ek.dts +13 -0
@@ -88,6 +88,14 @@ memory@60000000 { reg = <0x60000000 0x20000000>; }; + reg_5v: regulator-5v { + compatible = "regulator-fixed"; + regulator-name = "5V_MAIN"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + }; + sound: sound { compatible = "simple-audio-card"; simple-audio-card,name = "sama7g5ek audio";
@@ -239,6 +247,11 @@ i2c1: i2c@600 { mcp16502@5b { compatible = "microchip,mcp16502"; reg = <0x5b>; + lvin-supply = <®_5v>; + pvin1-supply = <®_5v>; + pvin2-supply = <®_5v>; + pvin3-supply = <®_5v>; + pvin4-supply = <®_5v>; status = "okay"; regulators {
Signature · 1 line
2.34.1
Andrei Simion
maintainerPATCH v2 4/7 ARM: dts: microchip: at91-sama7g54_curiosity: Add reg_5v to supply PMIC nodes
In reply to Andrei SimionAlign with the datasheet by adding regulator-5v which supplies each node from the regulator using phandle to regulator-5v through pvin[1-4]-supply and lvin-supply.
---
v1 -> v2:
- drop (lvin|pvin[1-4])-supply from each regulators sub-node
- add lvin-supply, pvin[1-4]-supply to PMIC node
--- .../boot/dts/microchip/at91-sama7g54_curiosity.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm/boot/dts/microchip/at91-sama7g54_curiosity.dts +13 -0
@@ -72,6 +72,14 @@ memory@60000000 { device_type = "memory"; reg = <0x60000000 0x10000000>; /* 256 MiB DDR3L-1066 16-bit */ }; + + reg_5v: regulator-5v { + compatible = "regulator-fixed"; + regulator-name = "5V_MAIN"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + }; }; &adc {
@@ -189,6 +197,11 @@ eeprom@51 { pmic@5b { compatible = "microchip,mcp16502"; reg = <0x5b>; + lvin-supply = <®_5v>; + pvin1-supply = <®_5v>; + pvin2-supply = <®_5v>; + pvin3-supply = <®_5v>; + pvin4-supply = <®_5v>; regulators { vdd_3v3: VDD_IO {
Signature · 1 line
2.34.1
Andrei Simion
maintainerPATCH v2 5/7 ARM: dts: microchip: at91-sama5d2_icp: Add reg_5v to supply PMIC nodes
In reply to Andrei SimionAlign with the datasheet by adding regulator-5v which supplies each node from the regulator using phandle to regulator-5v through pvin[1-4]-supply and lvin-supply.
---
v1 -> v2:
- drop (lvin|pvin[1-4])-supply from each regulators sub-node
- add lvin-supply, pvin[1-4]-supply to PMIC node
--- arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts +13 -0
@@ -78,6 +78,14 @@ led-blue { linux,default-trigger = "heartbeat"; }; }; + + reg_5v: regulator-5v { + compatible = "regulator-fixed"; + regulator-name = "VDD_MAIN_5V"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + }; }; &adc {
@@ -190,6 +198,11 @@ i2c6: i2c@600 { mcp16502@5b { compatible = "microchip,mcp16502"; reg = <0x5b>; + lvin-supply = <®_5v>; + pvin1-supply = <®_5v>; + pvin2-supply = <®_5v>; + pvin3-supply = <®_5v>; + pvin4-supply = <®_5v>; status = "okay"; lpm-gpios = <&pioBU 7 GPIO_ACTIVE_LOW>;
Signature · 1 line
2.34.1
Andrei Simion
maintainerPATCH v2 6/7 ARM: dts: microchip: at91-sama5d27_wlsom1: Add reg_5v to supply PMIC nodes
In reply to Andrei SimionAlign with the datasheet by adding regulator-5v which supplies each node from the regulator using phandle to regulator-5v through pvin[1-4]-supply and lvin-supply.
---
v1 -> v2:
- drop (lvin|pvin[1-4])-supply from each regulators sub-node
- add lvin-supply, pvin[1-4]-supply to PMIC node
--- .../boot/dts/microchip/at91-sama5d27_wlsom1.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1.dtsi +13 -0
@@ -31,6 +31,14 @@ main_xtal { }; }; + reg_5v: regulator-5v { + compatible = "regulator-fixed"; + regulator-name = "VDD_MAIN"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + }; + wifi_pwrseq: wifi_pwrseq { compatible = "mmc-pwrseq-wilc1000"; reset-gpios = <&pioA PIN_PA27 GPIO_ACTIVE_HIGH>;
@@ -70,6 +78,11 @@ &i2c1 { mcp16502@5b { compatible = "microchip,mcp16502"; reg = <0x5b>; + lvin-supply = <®_5v>; + pvin1-supply = <®_5v>; + pvin2-supply = <®_5v>; + pvin3-supply = <®_5v>; + pvin4-supply = <®_5v>; status = "okay"; lpm-gpios = <&pioBU 0 GPIO_ACTIVE_LOW>;
Signature · 1 line
2.34.1
Andrei Simion
maintainerPATCH v2 7/7 ARM: dts: microchip: sama5d29_curiosity: Add reg_5v to supply PMIC nodes
In reply to Andrei SimionAlign with the datasheet by adding regulator-5v which supplies each node from the regulator using phandle to regulator-5v through pvin[1-4]-supply and lvin-supply.
---
v1 -> v2:
- drop (lvin|pvin[1-4])-supply from each regulators sub-node
- add lvin-supply, pvin[1-4]-supply to PMIC node
--- .../boot/dts/microchip/at91-sama5d29_curiosity.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts +13 -0
@@ -84,6 +84,14 @@ memory@20000000 { device_type = "memory"; reg = <0x20000000 0x20000000>; }; + + reg_5v: regulator-5v { + compatible = "regulator-fixed"; + regulator-name = "5V_MAIN"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + }; }; &adc {
@@ -144,6 +152,11 @@ &i2c0 { mcp16502@5b { compatible = "microchip,mcp16502"; reg = <0x5b>; + lvin-supply = <®_5v>; + pvin1-supply = <®_5v>; + pvin2-supply = <®_5v>; + pvin3-supply = <®_5v>; + pvin4-supply = <®_5v>; status = "okay"; lpm-gpios = <&pioBU 0 GPIO_ACTIVE_LOW>;
Signature · 1 line
2.34.1
Rob Herring (Arm)
maintainerQuoted 62 lines · Andrei Simion
In this series of patches, support for the *-supply property [1] is added (correlated with
supply_name[2]) from the core regulator.
Link [1]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L471
Link [2]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L2064I modified the
mcp16502.cdriver and the dts that use this PMIC.
We added these improvements to provide a complete description of the board power scheme.Snippet (as an example) from
/sys/kernel/debug/regulator/regulator_summary(for at91-sama7g5ek):# cat regulator_summary regulator use open bypass opmode voltage current min max --------------------------------------------------------------------------------------- regulator-dummy 1 0 0 unknown 0mV 0mA 0mV 0mV 5V_MAIN 6 6 0 unknown 5000mV 0mA 5000mV 5000mV VDD_IO 5 4 0 normal 3300mV 0mA 3300mV 3300mV e1208000.mmc-vqmmc 1 0mA 0mV 0mV e1208000.mmc-vmmc 1 0mA 3300mV 3400mV e1204000.mmc-vmmc 1 0mA 3300mV 3400mV VDDOUT25 3 2 0 unknown 2500mV 0mA 2500mV 2500mV e1000000.adc-vref 1 0mA 0mV 0mV e1000000.adc-vddana 1 0mA 0mV 0mV VDD_DDR 1 0 0 normal 1350mV 0mA 1350mV 1350mV VDD_CORE 1 0 0 normal 1150mV 0mA 1150mV 1150mV VDD_OTHER 2 1 0 normal 1050mV 0mA 1050mV 1250mV cpu0-cpu 1 0mA 1050mV 1225mV LDO1 2 1 0 unknown 1800mV 0mA 1800mV 1800mV e1204000.mmc-vqmmc 1 0mA 0mV 0mV LDO2-------------------------------------------------------------------------------------------
Changelog:
v1 -> v2:
- drop (lvin|pvin[1-4])-supply from each regulators sub-node
- add voltage input supply documentation in the yaml schema
- add lvin-supply, pvin[1-4]-supply to PMIC nodeAndrei Simion (7):
regulator: mcp16502: Add supplier for regulators
regulator: dt-bindings: microchip,mcp16502: Add voltage input supply
documentation
ARM: dts: microchip: at91-sama7g5ek: Addreg_5vto supply PMIC nodes
ARM: dts: microchip: at91-sama7g54_curiosity: Addreg_5vto supply
PMIC nodes
ARM: dts: microchip: at91-sama5d2_icp: Addreg_5vto supply PMIC nodes
ARM: dts: microchip: at91-sama5d27_wlsom1: Addreg_5vto supply PMIC
nodes
ARM: dts: microchip:sama5d29_curiosity: Addreg_5vto supply PMIC
nodes.../regulator/microchip,mcp16502.yaml | 20 +++++++++++++++++++ .../dts/microchip/at91-sama5d27_wlsom1.dtsi | 13 ++++++++++++ .../dts/microchip/at91-sama5d29_curiosity.dts | 13 ++++++++++++ .../boot/dts/microchip/at91-sama5d2_icp.dts | 13 ++++++++++++ .../dts/microchip/at91-sama7g54_curiosity.dts | 13 ++++++++++++ .../arm/boot/dts/microchip/at91-sama7g5ek.dts | 13 ++++++++++++ drivers/regulator/mcp16502.c | 17 ++++++++-------- 7 files changed, 94 insertions(+), 8 deletions(-)
Quoted 6 lines
base-commit:
9e6869691724b12e1f43655eeedc35fade38120c--
2.34.1
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y microchip/at91-sama5d29_curiosity.dtb microchip/at91-sama5d2_icp.dtb microchip/at91-sama7g54_curiosity.dtb microchip/at91-sama7g5ek.dtb' for [email protected]:
arch/arm/boot/dts/microchip/at91-sama7g5ek.dtb: /soc/chipid@e0020000: failed to match any schema with compatible: ['microchip,sama7g5-chipid'] arch/arm/boot/dts/microchip/at91-sama7g5ek.dtb: /soc/mmc@e120c000: failed to match any schema with compatible: ['microchip,sama7g5-sdhci', 'microchip,sam9x60-sdhci'] arch/arm/boot/dts/microchip/at91-sama7g5ek.dtb: /soc/mmc@e120c000: failed to match any schema with compatible: ['microchip,sama7g5-sdhci', 'microchip,sam9x60-sdhci']
Mark Brown
maintainerRe: (subset) [PATCH v2 0/7] Add input voltage suppliers for PMIC MCP16502 regulators
In reply to Andrei SimionQuoted 9 lines · Andrei Simion
In this series of patches, support for the *-supply property [1] is added (correlated with
supply_name[2]) from the core regulator.
Link [1]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L471
Link [2]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L2064I modified the
mcp16502.cdriver and the dts that use this PMIC.
We added these improvements to provide a complete description of the board power scheme.[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/7] regulator: mcp16502: Add supplier for regulators
commit: 861289835002b733aa8715442ba555b1daa84baa
[2/7] regulator: dt-bindings: microchip,mcp16502: Add voltage input supply documentation
commit: bf5ba94fa0b90c9433167bf143780af6c8805479All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 5 lines · Andrei Simion
In this series of patches, support for the *-supply property [1] is added (correlated with
supply_name[2]) from the core regulator.
Link [1]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L471
Link [2]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L2064
[ ... ]
Quoted 2 lines
Andrei Simion (7):
[ ... ]
Quoted 8 lines
ARM: dts: microchip: at91-sama7g5ek: Add
reg_5vto supply PMIC nodes
ARM: dts: microchip: at91-sama7g54_curiosity: Addreg_5vto supply
PMIC nodes
ARM: dts: microchip: at91-sama5d2_icp: Addreg_5vto supply PMIC nodes
ARM: dts: microchip: at91-sama5d27_wlsom1: Addreg_5vto supply PMIC
nodes
ARM: dts: microchip:sama5d29_curiosity: Addreg_5vto supply PMIC
nodes
Applied to at91-dt, thanks!