Skip to contentSkip to conversation

package/hiawatha: update to 11.6

PATCH In review Waldemar Brodkorb 2 participants 6 messages Aug 11, 2024 – Aug 13, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/hiawatha: update to 11.6

See here for a changelog:
https://hiawatha.leisink.net/changelog

Update Config.in to use the new homepage.
Update download site to use the new homepage.

---
 package/hiawatha/Config.in     | 2 +-
 package/hiawatha/hiawatha.hash | 2 +-
 package/hiawatha/hiawatha.mk   | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)
package/hiawatha/Config.in +1 -1
index 0c35734c34..8bcee3f098 100644
@@ -27,7 +27,7 @@ config BR2_PACKAGE_HIAWATHA
 	  pipelining, keep alive connections, URL rewriting and many
 	  more.
 
-	  http://www.hiawatha-webserver.org/
+	  https://hiawatha.leisink.net/
 
 if BR2_PACKAGE_HIAWATHA
 
package/hiawatha/hiawatha.hash +1 -1
index 1ee94ee69a..14b8cf8d63 100644
@@ -1,3 +1,3 @@
 # Locally calculated
-sha256  99c64f76927f93469f062ab76b74eb79a397ea4be12da86bf746b2bb57cf1bc5  hiawatha-11.2.tar.gz
+sha256  b3c5eb7be007509b7e1f3d88cc03a99904d3b6e5e05d980f9d5bdaa424864dd6  hiawatha-11.6.tar.gz
 sha256  ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6  LICENSE
package/hiawatha/hiawatha.mk +2 -2
index 3e9cf2571b..dc82e6ffde 100644
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-HIAWATHA_VERSION = 11.2
-HIAWATHA_SITE = https://www.hiawatha-webserver.org/files
+HIAWATHA_VERSION = 11.6
+HIAWATHA_SITE = https://hiawatha.leisink.net/files
 HIAWATHA_DEPENDENCIES = zlib
 HIAWATHA_LICENSE = GPL-2.0
 HIAWATHA_LICENSE_FILES = LICENSE
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Waldemar,

Quoted 6 lines · On Sun, 11 Aug 2024 07:25:20 +0200 Waldemar Brodkorb <[email protected]> wrote:

See here for a changelog:
https://hiawatha.leisink.net/changelog

Update Config.in to use the new homepage.
Update download site to use the new homepage.

Quoted 6 lines
---
 package/hiawatha/Config.in     | 2 +-
 package/hiawatha/hiawatha.hash | 2 +-
 package/hiawatha/hiawatha.mk   | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

You're going to hate me, but this bump also doesn't build.

Try to build:

BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_ARMV7_EABIHF_MUSL_STABLE=y BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set BR2_PACKAGE_HIAWATHA=y
# BR2_TARGET_ROOTFS_TAR is not set

Successful before your bump, fails after your bump.

Also, it is worth nothing that there is also an issue with the 11.2 version of hiawatha: the hash we have in Buildroot no longer matches the one from the upstream tarball:

ERROR: while checking hashes from package/hiawatha/hiawatha.hash
ERROR: hiawatha-11.2.tar.gz has wrong sha256 hash:
ERROR: expected: 99c64f76927f93469f062ab76b74eb79a397ea4be12da86bf746b2bb57cf1bc5
ERROR: got : e00a659225b5f201b1fd81014277bcfe96da476a165f92fc057f3d7036c8b993
ERROR: Incomplete download, or man-in-the-middle (MITM) attack

It "works" because we fallback to sources.buildroot.net, which has the "right" tarball, but it would be nice to understand what's going on.

Could you have a look?

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Hi Thomas,
Thomas Petazzoni wrote,

Quoted 34 lines

Hello Waldemar,

Quoted 6 lines · On Sun, 11 Aug 2024 07:25:20 +0200 Waldemar Brodkorb <[email protected]> wrote:

See here for a changelog:
https://hiawatha.leisink.net/changelog

Update Config.in to use the new homepage.
Update download site to use the new homepage.

Quoted 6 lines
---
 package/hiawatha/Config.in     | 2 +-
 package/hiawatha/hiawatha.hash | 2 +-
 package/hiawatha/hiawatha.mk   | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

You're going to hate me, but this bump also doesn't build.

Try to build:

BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_ARMV7_EABIHF_MUSL_STABLE=y BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set BR2_PACKAGE_HIAWATHA=y
# BR2_TARGET_ROOTFS_TAR is not set

Quoted 1 line

Successful before your bump, fails after your bump.

I only tested with TLS on, sorry.

It seems upstream is broken regarding ENABLE_TLS=OFF.
I tried to patch CMakeFiles.txt to add the missing sha3.c, but then other symbols are missing. I added 5 missing files and still no go. Uptream is not very active anymore, he mentions on his website that he is doing releases, but no active development anymore.

We could remove TLS off case entirely and still have a small secure webserver. What do you think?

Quoted 10 lines

Also, it is worth nothing that there is also an issue with the 11.2 version of hiawatha: the hash we have in Buildroot no longer matches the one from the upstream tarball:

ERROR: while checking hashes from package/hiawatha/hiawatha.hash
ERROR: hiawatha-11.2.tar.gz has wrong sha256 hash:
ERROR: expected: 99c64f76927f93469f062ab76b74eb79a397ea4be12da86bf746b2bb57cf1bc5
ERROR: got : e00a659225b5f201b1fd81014277bcfe96da476a165f92fc057f3d7036c8b993
ERROR: Incomplete download, or man-in-the-middle (MITM) attack

Quoted 4 lines

It "works" because we fallback to sources.buildroot.net, which has the "right" tarball, but it would be nice to understand what's going on.

Could you have a look?

It is because the old URL is no longer available and a html is downloaded instead of the tar.gz.

best regards
Waldemar

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
Quoted 4 lines · On Tue, 13 Aug 2024 08:58:23 +0200 Waldemar Brodkorb <[email protected]> wrote:
Quoted 1 line

Successful before your bump, fails after your bump.

I only tested with TLS on, sorry.

Quoted 8 lines

It seems upstream is broken regarding ENABLE_TLS=OFF.
I tried to patch CMakeFiles.txt to add the missing sha3.c, but then other symbols are missing. I added 5 missing files and still no go. Uptream is not very active anymore, he mentions on his website that he is doing releases, but no active development anymore.

We could remove TLS off case entirely and still have a small secure webserver. What do you think?

Would be OK for me. However, if upstream is not active anymore, should we drop the package instead?

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw

Hi Thomas,
Thomas Petazzoni wrote,

Quoted 13 lines
Quoted 10 lines · On Tue, 13 Aug 2024 08:58:23 +0200 Waldemar Brodkorb <[email protected]> wrote:
Quoted 1 line

Successful before your bump, fails after your bump.

I only tested with TLS on, sorry.

It seems upstream is broken regarding ENABLE_TLS=OFF.
I tried to patch CMakeFiles.txt to add the missing sha3.c, but then other symbols are missing. I added 5 missing files and still no go. Uptream is not very active anymore, he mentions on his website that he is doing releases, but no active development anymore.

Quoted 5 lines
Quoted 2 lines

We could remove TLS off case entirely and still have a small secure webserver. What do you think?

Would be OK for me. However, if upstream is not active anymore, should we drop the package instead?

He is still doing releases and added TLS 1.3 support recently. I would like to update it and keep the package. I can sent him an email to report the issue with TLS off and see what he says.

Would you like two patches, one with URL updates for master and the update and TLS removal for next?

best regards
Waldemar
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw

Hello Waldemar,

Quoted 6 lines · On Tue, 13 Aug 2024 09:23:29 +0200 Waldemar Brodkorb <[email protected]> wrote:
Quoted 2 lines

Would be OK for me. However, if upstream is not active anymore, should we drop the package instead?

He is still doing releases and added TLS 1.3 support recently. I would like to update it and keep the package. I can sent him an email to report the issue with TLS off and see what he says.

Then please report the issue with building without TLS support, hopefully the maintainer will be interested in fixing what really is a regression.

Quoted 2 lines

Would you like two patches, one with URL updates for master and the update and TLS removal for next?

URL updates for master, for sure.

TLS removal, I would like to wait for the maintainer feedback. I'd prefer to see it fixed instead.

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot