Skip to contentSkip to conversation

Update the max31790 driver

PATCH Superseded Chanh Nguyen 5 participants 11 messages Aug 13, 2024 – Aug 14, 2024

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover Update the max31790 driver

Add device tree binding for the max31790 device.

Changes in v2:

 - Drop "driver" in the patch 1/3 commit title                           [Krzysztof]
 - Update filename of the maxim,max31790.yaml                            [Krzysztof]
 - Add the common fan schema to $ref                                     [Krzysztof]
 - Update the node name to "fan-controller" in maxim,max31790.yaml       [Krzysztof]
 - Update the vendor property name to "maxim,pwmout-pin-as-tach-input"   [Rob]
Changes in v3:
 - Drop redundant "bindings" in commit message                           [Krzysztof]
 - Add the clocks and resets property to example                         [Krzysztof]
 - Add child node refer to fan-common.yaml                               [Krzysztof, Conor]
 - Drop "Support config PWM output become TACH" patch                    [Chanh]
 - Drop "Add maxim,pwmout-pin-as-tach-input property" patch              [Chanh]

Chanh Nguyen (1):
dt-bindings: hwmon: Add maxim max31790

 .../bindings/hwmon/maxim,max31790.yaml        | 81 +++++++++++++++++++
 1 file changed, 81 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
Signature · 1 line
2.43.0
#1 lore raw

PATCH v3 1/1 dt-bindings: hwmon: Add maxim max31790

Add device tree bindings and an example for max31790 device.

---
Changes in v2:

 - Update filename of the maxim,max31790.yaml                        [Krzysztof]
 - Add the common fan schema to $ref                                 [Krzysztof]
 - Update the node name to "fan-controller" in maxim,max31790.yaml   [Krzysztof]
 - Drop "driver" in commit title                                     [Krzysztof]
Changes in v3:
 - Drop redundant "bindings" in commit title                         [Krzysztof]
 - Add the clocks and resets property in example                     [Krzysztof]
 - Add child node refer to fan-common.yaml                           [Krzysztof, Conor]
---
 .../bindings/hwmon/maxim,max31790.yaml        | 81 +++++++++++++++++++
 1 file changed, 81 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +81 -0
new file mode 100644
index 000000000000..d28a6373edd3
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: The Maxim MAX31790 Fan Controller
+
+maintainers:
+  - Guenter Roeck <[email protected]>
+
+description: >
+  The MAX31790 controls the speeds of up to six fans using six
+  independent PWM outputs. The desired fan speeds (or PWM duty cycles)
+  are written through the I2C interface.
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf
+
+properties:
+  compatible:
+    const: maxim,max31790
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 1
+
+patternProperties:
+  "^fan-[0-9]+$":
+    $ref: fan-common.yaml#
+    unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fan-controller@21 {
+        compatible = "maxim,max31790";
+        reg = <0x21>;
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;
+      };
+    };
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      pwm_provider: fan-controller@20 {
+        compatible = "maxim,max31790";
+        reg = <0x20>;
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;
+        #pwm-cells = <1>;
+
+        fan-0 {
+          pwms = <&pwm_provider 1>;
+        };
+
+        fan-1 {
+          pwms = <&pwm_provider 2>;
+        };
+      };
+    };
+
Signature · 1 line
2.43.0
#2 lore raw

Re: [PATCH v3 1/1] dt-bindings: hwmon: Add maxim max31790

Quoted 24 lines · Chanh Nguyen

Add device tree bindings and an example for max31790 device.

---
Changes in v2:

 - Update filename of the maxim,max31790.yaml                        [Krzysztof]
 - Add the common fan schema to $ref                                 [Krzysztof]
 - Update the node name to "fan-controller" in maxim,max31790.yaml   [Krzysztof]
 - Drop "driver" in commit title                                     [Krzysztof]
Changes in v3:
 - Drop redundant "bindings" in commit title                         [Krzysztof]
 - Add the clocks and resets property in example                     [Krzysztof]
 - Add child node refer to fan-common.yaml                           [Krzysztof, Conor]
---
 .../bindings/hwmon/maxim,max31790.yaml        | 81 +++++++++++++++++++
 1 file changed, 81 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +0 -0
new file mode 100644
index 000000000000..d28a6373edd3

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml line 10

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +10 -0
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: The Maxim MAX31790 Fan Controller
+
+maintainers:
+  - Guenter Roeck <[email protected]>

Why Guenter and not you?

Quoted 39 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +39 -0
+
+description: >
+  The MAX31790 controls the speeds of up to six fans using six
+  independent PWM outputs. The desired fan speeds (or PWM duty cycles)
+  are written through the I2C interface.
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf
+
+properties:
+  compatible:
+    const: maxim,max31790
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 1
+
+patternProperties:
+  "^fan-[0-9]+$":
+    $ref: fan-common.yaml#
+    unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml line 59

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +10 -0
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fan-controller@21 {
+        compatible = "maxim,max31790";
+        reg = <0x21>;
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;
+      };
+    };

What does this example demonstrate? The one below seems useful, this one I don't quite understand - what's the point of a fan controller with no fans connected to it? What am I missing?

Otherwise, this looks pretty good.

Cheers,
Conor.

Quoted 25 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +22 -0
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      pwm_provider: fan-controller@20 {
+        compatible = "maxim,max31790";
+        reg = <0x20>;
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;
+        #pwm-cells = <1>;
+
+        fan-0 {
+          pwms = <&pwm_provider 1>;
+        };
+
+        fan-1 {
+          pwms = <&pwm_provider 2>;
+        };
+      };
+    };
+
Signature · 1 line
2.43.0
maintainer
#3 lore raw

Re: [PATCH v3 1/1] dt-bindings: hwmon: Add maxim max31790

Quoted 29 lines · Conor Dooley
Quoted 28 lines · Chanh Nguyen

Add device tree bindings and an example for max31790 device.

---
Changes in v2:

  - Update filename of the maxim,max31790.yaml                        [Krzysztof]
  - Add the common fan schema to $ref                                 [Krzysztof]
  - Update the node name to "fan-controller" in maxim,max31790.yaml   [Krzysztof]
  - Drop "driver" in commit title                                     [Krzysztof]
Changes in v3:
  - Drop redundant "bindings" in commit title                         [Krzysztof]
  - Add the clocks and resets property in example                     [Krzysztof]
  - Add child node refer to fan-common.yaml                           [Krzysztof, Conor]
---
  .../bindings/hwmon/maxim,max31790.yaml        | 81 +++++++++++++++++++
  1 file changed, 81 insertions(+)

create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +4 -0
new file mode 100644
index 000000000000..d28a6373edd3
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
Quoted 9 lines

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml line 10

Quoted 6 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +6 -0
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: The Maxim MAX31790 Fan Controller
+
+maintainers:
+  - Guenter Roeck <[email protected]>

Why Guenter and not you?

Fine with me, actually. We don't expect individual driver maintainers in the hardware monitoring subsystem, and this chip doesn't have an explicit maintainer. Forcing people to act as maintainer for .yaml files they submit can only result in fewer submissions. I prefer to be listed as maintainer over having no devicetree bindings.

Quoted 45 lines
Quoted 45 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +45 -0
+
+description: >
+  The MAX31790 controls the speeds of up to six fans using six
+  independent PWM outputs. The desired fan speeds (or PWM duty cycles)
+  are written through the I2C interface.
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf
+
+properties:
+  compatible:
+    const: maxim,max31790
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 1
+
+patternProperties:
+  "^fan-[0-9]+$":
+    $ref: fan-common.yaml#
+    unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fan-controller@21 {
+        compatible = "maxim,max31790";
+        reg = <0x21>;
Quoted 9 lines

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml line 59

Quoted 4 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +4 -0
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;
+      };
+    };

What does this example demonstrate? The one below seems useful, this one I don't quite understand - what's the point of a fan controller with no fans connected to it? What am I missing?

Just guessing, but maybe this is supposed to reflect a system which only monitors fan speeds but does not implement fan control.

Guenter

Quoted 30 lines

Otherwise, this looks pretty good.

Cheers,
Conor.

Quoted 25 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +22 -0
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      pwm_provider: fan-controller@20 {
+        compatible = "maxim,max31790";
+        reg = <0x20>;
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;
+        #pwm-cells = <1>;
+
+        fan-0 {
+          pwms = <&pwm_provider 1>;
+        };
+
+        fan-1 {
+          pwms = <&pwm_provider 2>;
+        };
+      };
+    };
+
Signature · 1 line
2.43.0
#4 lore raw

Re: [PATCH v3 1/1] dt-bindings: hwmon: Add maxim max31790

Quoted 40 lines · Guenter Roeck
Quoted 29 lines · Conor Dooley
Quoted 28 lines · Chanh Nguyen

Add device tree bindings and an example for max31790 device.

---
Changes in v2:

  - Update filename of the maxim,max31790.yaml                        [Krzysztof]
  - Add the common fan schema to $ref                                 [Krzysztof]
  - Update the node name to "fan-controller" in maxim,max31790.yaml   [Krzysztof]
  - Drop "driver" in commit title                                     [Krzysztof]
Changes in v3:
  - Drop redundant "bindings" in commit title                         [Krzysztof]
  - Add the clocks and resets property in example                     [Krzysztof]
  - Add child node refer to fan-common.yaml                           [Krzysztof, Conor]
---
  .../bindings/hwmon/maxim,max31790.yaml        | 81 +++++++++++++++++++
  1 file changed, 81 insertions(+)

create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +4 -0
new file mode 100644
index 000000000000..d28a6373edd3
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
Quoted 9 lines

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml line 10

Quoted 6 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +6 -0
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: The Maxim MAX31790 Fan Controller
+
+maintainers:
+  - Guenter Roeck <[email protected]>

Why Guenter and not you?

Quoted 5 lines

Fine with me, actually. We don't expect individual driver maintainers in the hardware monitoring subsystem, and this chip doesn't have an explicit maintainer. Forcing people to act as maintainer for .yaml files they submit can only result in fewer submissions. I prefer to be listed as maintainer over having no devicetree bindings.

Sure, if you're happy with it. Having someone that knows about how the particular model works is usually preferred however!

Quoted 56 lines
Quoted 46 lines
Quoted 46 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +45 -0
+
+description: >
+  The MAX31790 controls the speeds of up to six fans using six
+  independent PWM outputs. The desired fan speeds (or PWM duty cycles)
+  are written through the I2C interface.
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf
+
+properties:
+  compatible:
+    const: maxim,max31790
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 1
+
+patternProperties:
+  "^fan-[0-9]+$":
+    $ref: fan-common.yaml#
+    unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fan-controller@21 {
+        compatible = "maxim,max31790";
+        reg = <0x21>;
Quoted 9 lines

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml line 59

Quoted 4 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +4 -0
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;
+      };
+    };

What does this example demonstrate? The one below seems useful, this one I don't quite understand - what's the point of a fan controller with no fans connected to it? What am I missing?

Quoted 2 lines

Just guessing, but maybe this is supposed to reflect a system which only monitors fan speeds but does not implement fan control.

Even without any control, I would expect to see fan-# child nodes, just no pwms property in them. Without the child nodes, how does software determine which fan is being monitored by which channel?

Cheers,
Conor.

Quoted 26 lines
Quoted 25 lines
Quoted 25 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +22 -0
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      pwm_provider: fan-controller@20 {
+        compatible = "maxim,max31790";
+        reg = <0x20>;
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;
+        #pwm-cells = <1>;
+
+        fan-0 {
+          pwms = <&pwm_provider 1>;
+        };
+
+        fan-1 {
+          pwms = <&pwm_provider 2>;
+        };
+      };
+    };
+
Signature · 1 line
2.43.0
#5 lore raw

Re: [PATCH v3 1/1] dt-bindings: hwmon: Add maxim max31790

Quoted 19 lines · Conor Dooley
Quoted 19 lines
Quoted 18 lines

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml line 59

Quoted 13 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +13 -0
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fan-controller@21 {
+        compatible = "maxim,max31790";
+        reg = <0x21>;
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;
+      };
+    };

What does this example demonstrate? The one below seems useful, this one I don't quite understand - what's the point of a fan controller with no fans connected to it? What am I missing?

Quoted 6 lines
Quoted 2 lines

Just guessing, but maybe this is supposed to reflect a system which only monitors fan speeds but does not implement fan control.

Even without any control, I would expect to see fan-# child nodes, just no pwms property in them. Without the child nodes, how does software determine which fan is being monitored by which channel?

Yeah, to me this example is confusing. If device's purpose is to also monitor, then hardware description in "description:" field should be a bit extended.

Best regards,
Krzysztof

#6 lore raw

Re: [PATCH v3 1/1] dt-bindings: hwmon: Add maxim max31790

Quoted 27 lines · Krzysztof Kozlowski
Quoted 19 lines · Conor Dooley
Quoted 19 lines
Quoted 18 lines

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml line 59

Quoted 13 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +13 -0
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fan-controller@21 {
+        compatible = "maxim,max31790";
+        reg = <0x21>;
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;
+      };
+    };

What does this example demonstrate? The one below seems useful, this one I don't quite understand - what's the point of a fan controller with no fans connected to it? What am I missing?

Quoted 6 lines
Quoted 2 lines

Just guessing, but maybe this is supposed to reflect a system which only monitors fan speeds but does not implement fan control.

Even without any control, I would expect to see fan-# child nodes, just no pwms property in them. Without the child nodes, how does software determine which fan is being monitored by which channel?

Quoted 7 lines

Yeah, to me this example is confusing. If device's purpose is to also monitor, then hardware description in "description:" field should be a bit extended.

Best regards,
Krzysztof

Thank all for your comments!

I'll keep only complete example. I'm going to push patch v4 in the coming days.

Regards!
Chanh

#7 lore raw

Re: [PATCH v3 1/1] dt-bindings: hwmon: Add maxim max31790

In reply to Conor Dooley
Quoted 41 lines · Conor Dooley
Quoted 40 lines · Guenter Roeck
Quoted 38 lines · Conor Dooley
Quoted 24 lines · Chanh Nguyen

Add device tree bindings and an example for max31790 device.

---
Changes in v2:

   - Update filename of the maxim,max31790.yaml                        [Krzysztof]
   - Add the common fan schema to $ref                                 [Krzysztof]
   - Update the node name to "fan-controller" in maxim,max31790.yaml   [Krzysztof]
   - Drop "driver" in commit title                                     [Krzysztof]
Changes in v3:
   - Drop redundant "bindings" in commit title                         [Krzysztof]
   - Add the clocks and resets property in example                     [Krzysztof]
   - Add child node refer to fan-common.yaml                           [Krzysztof, Conor]
---
   .../bindings/hwmon/maxim,max31790.yaml        | 81 +++++++++++++++++++
   1 file changed, 81 insertions(+)

create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +0 -0
new file mode 100644
index 000000000000..d28a6373edd3

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml line 10

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +10 -0
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: The Maxim MAX31790 Fan Controller
+
+maintainers:
+  - Guenter Roeck <[email protected]>

Why Guenter and not you?

Quoted 9 lines
Quoted 5 lines

Fine with me, actually. We don't expect individual driver maintainers in the hardware monitoring subsystem, and this chip doesn't have an explicit maintainer. Forcing people to act as maintainer for .yaml files they submit can only result in fewer submissions. I prefer to be listed as maintainer over having no devicetree bindings.

Sure, if you're happy with it. Having someone that knows about how the particular model works is usually preferred however!

Thank Guenter and Conor for your comments!

I will add me to maintainers list. I'm going to push the patch v4 with this update soon. It will be as below:

maintainers:
- Guenter Roeck <[email protected]>
- Chanh Nguyen <[email protected]>

I think I can support to reviewing any max31790 binding update later.

Thanks,
Chanh

Quoted 92 lines
Quoted 56 lines
Quoted 46 lines
Quoted 46 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +45 -0
+
+description: >
+  The MAX31790 controls the speeds of up to six fans using six
+  independent PWM outputs. The desired fan speeds (or PWM duty cycles)
+  are written through the I2C interface.
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf
+
+properties:
+  compatible:
+    const: maxim,max31790
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 1
+
+patternProperties:
+  "^fan-[0-9]+$":
+    $ref: fan-common.yaml#
+    unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fan-controller@21 {
+        compatible = "maxim,max31790";
+        reg = <0x21>;
Quoted 9 lines

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml line 59

Quoted 4 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +4 -0
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;
+      };
+    };

What does this example demonstrate? The one below seems useful, this one I don't quite understand - what's the point of a fan controller with no fans connected to it? What am I missing?

Quoted 2 lines

Just guessing, but maybe this is supposed to reflect a system which only monitors fan speeds but does not implement fan control.

Even without any control, I would expect to see fan-# child nodes, just no pwms property in them. Without the child nodes, how does software determine which fan is being monitored by which channel?

Cheers,
Conor.

Quoted 26 lines
Quoted 25 lines
Quoted 25 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +22 -0
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      pwm_provider: fan-controller@20 {
+        compatible = "maxim,max31790";
+        reg = <0x20>;
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;
+        #pwm-cells = <1>;
+
+        fan-0 {
+          pwms = <&pwm_provider 1>;
+        };
+
+        fan-1 {
+          pwms = <&pwm_provider 2>;
+        };
+      };
+    };
+
Signature · 1 line
2.43.0
Reviewed-by on v3 1/1
#8 lore raw

Re: [PATCH v3 1/1] dt-bindings: hwmon: Add maxim max31790

In reply to Chanh Nguyen
Quoted 7 lines · Chanh Nguyen

Add device tree bindings and an example for max31790 device.

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +2 -0
+
+examples:

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml line 57

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +10 -0
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fan-controller@21 {
+        compatible = "maxim,max31790";
+        reg = <0x21>;
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;

This node is incomplete. I asked to make the example complete, not by adding two incomplete examples or other ways... The binding description says this device controls fan. If so, where is the fan here?

IOW, keep only one, complete example.

Rest looks good. With this addressed (and optionally with maintainer change, which Conor asked):

Best regards,
Krzysztof

#9 lore raw

Re: [PATCH v3 1/1] dt-bindings: hwmon: Add maxim max31790

Quoted 23 lines · Krzysztof Kozlowski
Quoted 7 lines · Chanh Nguyen

Add device tree bindings and an example for max31790 device.

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +2 -0
+
+examples:

Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml line 57

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml new file +10 -0
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fan-controller@21 {
+        compatible = "maxim,max31790";
+        reg = <0x21>;
+        clocks = <&sys_clk>;
+        resets = <&reset 0>;

This node is incomplete. I asked to make the example complete, not by adding two incomplete examples or other ways... The binding description says this device controls fan. If so, where is the fan here?

Quoted 4 lines

IOW, keep only one, complete example.

Rest looks good. With this addressed (and optionally with maintainer change, which Conor asked):

Thank Krzysztof for your review!

I'll keep only complete example. I'm going to push patch v4 in the coming days.

Thanks,
Chanh

Quoted 6 lines

Best regards,
Krzysztof

#10 lore raw
In reply to Chanh Nguyen

Hi all,

I dropped the "Support config PWM output becomes TACH" patch. I'm implementing and testing the "Support config PWM output become TACH" support; I'll push this feature later. Now, I'm only adding the device tree binding for the max31790 device; it is necessary for some device tree upstreams that use the "maxim,max31790" compatible.

Best Regards,
Chanh

Quoted 22 lines · Chanh Nguyen

Add device tree binding for the max31790 device.

Changes in v2:

  - Drop "driver" in the patch 1/3 commit title                           [Krzysztof]
  - Update filename of the maxim,max31790.yaml                            [Krzysztof]
  - Add the common fan schema to $ref                                     [Krzysztof]
  - Update the node name to "fan-controller" in maxim,max31790.yaml       [Krzysztof]
  - Update the vendor property name to "maxim,pwmout-pin-as-tach-input"   [Rob]
Changes in v3:
  - Drop redundant "bindings" in commit message                           [Krzysztof]
  - Add the clocks and resets property to example                         [Krzysztof]
  - Add child node refer to fan-common.yaml                               [Krzysztof, Conor]
  - Drop "Support config PWM output become TACH" patch                    [Chanh]
  - Drop "Add maxim,pwmout-pin-as-tach-input property" patch              [Chanh]

Chanh Nguyen (1):
dt-bindings: hwmon: Add maxim max31790

  .../bindings/hwmon/maxim,max31790.yaml        | 81 +++++++++++++++++++
  1 file changed, 81 insertions(+)

create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml