Skip to contentSkip to conversation

ARM: dts: stm32: include st,stm32mp13-regulator.h in stm32mp131.dtsi

PATCH In review Rasmus Villemoes 2 participants 2 messages Aug 13, 2024 – Aug 30, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: include st,stm32mp13-regulator.h in stm32mp131.dtsi

From: Rasmus Villemoes <[email protected]>

The file stm32mp131.dtsi uses symbolic constants such as VOLTD_SCMI_REG11, VOLTD_SCMI_REG18 etc., but does not include the header where they are defined. So when adding a new .dts file that includes stm32mp131.dtsi, the build breaks unless the .dts itself includes st,stm32mp13-regulator.h.

---

OTOH, it seems that (if this is applied) stm32mp135f-dhcor-dhsbc.dts and stm32mp13xx-dhcor-som.dtsi could drop their #includes as they do not use any of the VOLTD_SCMI_* constants except through stm32mp131.dtsi.

 arch/arm/boot/dts/st/stm32mp131.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/st/stm32mp131.dtsi +1 -0
index e1a764d269d2..490d38dc8d54 100644
@@ -5,6 +5,7 @@
  */
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/clock/stm32mp13-clks.h>
+#include <dt-bindings/regulator/st,stm32mp13-regulator.h>
 #include <dt-bindings/reset/stm32mp13-resets.h>
 
 / {
Signature · 1 line
2.46.0
maintainer
#1 lore raw

Hi Rasmus

Quoted 8 lines · Rasmus Villemoes

From: Rasmus Villemoes <[email protected]>

The file stm32mp131.dtsi uses symbolic constants such as VOLTD_SCMI_REG11, VOLTD_SCMI_REG18 etc., but does not include the header where they are defined. So when adding a new .dts file that includes stm32mp131.dtsi, the build breaks unless the .dts itself includes st,stm32mp13-regulator.h.

Quoted 6 lines

---

OTOH, it seems that (if this is applied) stm32mp135f-dhcor-dhsbc.dts and stm32mp13xx-dhcor-som.dtsi could drop their #includes as they do not use any of the VOLTD_SCMI_* constants except through stm32mp131.dtsi.

Thanks for this fix. I think it would be nice to add to this series boards updates by removing "#include <dt-bindings/regulator/st,stm32mp13-regulator.h>".

Thanks in advance
Alex

Quoted 16 lines
  arch/arm/boot/dts/st/stm32mp131.dtsi | 1 +
  1 file changed, 1 insertion(+)
arch/arm/boot/dts/st/stm32mp131.dtsi +1 -0
index e1a764d269d2..490d38dc8d54 100644
@@ -5,6 +5,7 @@
   */
  #include <dt-bindings/interrupt-controller/arm-gic.h>
  #include <dt-bindings/clock/stm32mp13-clks.h>
+#include <dt-bindings/regulator/st,stm32mp13-regulator.h>
  #include <dt-bindings/reset/stm32mp13-resets.h>
 
  / {